JavaScript Function Don't Return Value.

Question

0.00/5 (No votes)

See more:

I have a JavaScript Function in an external JavaScript page. The function is at the below.

Script.js

JavaScript

function getVaria(){

strStartDate = document.getElementById("from_date").value;
strEndDate = document.getElementById("to_date").value;

//Following variable will be the query to the 1st chart.
strWsUrl = "https://www.googleapis.com/analytics/v3/data/ga?ids=ga%3A76546294&dimensions=ga%3Asource&metrics=ga%3Ausers&filters=ga%3Asource!%3D(direct)&sort=-ga%3Ausers&start-date=' + strStartDate + '&end-date=' + strEndDate + '&max-results=10";

alert(strStartDate);
alert(strEndDate);
alert(strWsUrl);

return strWsUrl;

}

This function shaould 'return strWsUrl'. To grab that value I have created another function outside of that perticular external JavaScript page. It is at below.

Dashboard.html

HTML

<script type="text/javascript" src="js/script.js"></script>
<script type="text/javascript">
	//Date Picker
	$(function() {
		$("#to_date").datepicker({  maxDate: new Date() });
		$("#from_date").datepicker({  maxDate: new Date() });
		$("div.ui-datepicker").css( { "font-size": "10px" } );
	});
</script>

<script type="text/javascript">

	function myTest(){
	
		getVaria();
		alert("This is UI Page " + strWsUrl);
}

However the result is This is UI Page Undefined. I think this is because the strWsUrl value does not pass to the HTML page. So What have I done wrong?

Could someone enlight me to solve the matter?
Chiranthaka

Posted 21-Jul-14 1:19am

Chiranthaka Sampath

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Kornfeld Eliyahu Peter · Accepted Answer · 2014-07-21T01:30:00

Your code is full of the worst part of JavaScript.
1. All your variables are globals - as no var used to declare them. A huge mistake!!!
2. If you write a function to return a value then use that value!!!
---

JavaScript

function myTest(){
        alert("This is UI Page " + getVaria());
}

..and...

JavaScript

function getVaria(){
  var strStartDate = document.getElementById("from_date").value;
  var strEndDate = document.getElementById("to_date").value;

  //Following variable will be the query to the 1st chart.
  var strWsUrl = "https://www.googleapis.com/analytics/v3/data/ga?ids=ga%3A76546294&dimensions=ga%3Asource&metrics=ga%3Ausers&filters=ga%3Asource!%3D(direct)&sort=-ga%3Ausers&start-date=' + strStartDate + '&end-date=' + strEndDate + '&max-results=10";

  alert(strStartDate);
  alert(strEndDate);
  alert(strWsUrl);

  return strWsUrl;
}

---
Do yourself a favor! Stop for a week and read some decent book about programming with JavaScript. Your development can go so wrong with JavaScript (it's a language permitting any kind of idiotic things) if you do not understand its base...