Problem in JavaScript

Question

2.00/5 (1 vote)

See more:

I have some lines of javascript as below:

C#

var start = str.split("-")[0];
var end = str.split("-")[1];
alert(start + " " + end);
for(strt=start;strt<=end;strt++)
{
    alert(strt);
}

Now, If i give value for str less than 10 i.e. 1-9, 7-9
or greater than equal to 10 i.e. 10-12, 10-15, 11-40 It works fine.. but of if I include 10 in between range i.e. 6-12, 8-12, 9-11 etc. It doesn't work.. I am unable to figure out.. still trying to debug... will anyone please join me to debug this out!

I fount the solution by breaking a case like 8-12 into parts to be processed like 8-9 and 10-12, but it'd be better if direct processing could be done.

Posted 31-Jul-14 9:07am

Manudhiman

Updated 31-Jul-14 9:25am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2014-07-31T09:24:00

Solution 1

You're comparing string values instead of numbers. Since the character '6' is greater than the character '1', your loop will never execute.

Convert the values to numbers before processing them:

JavaScript

var str = "6-10";

var parts = str.split("-");
var start = parseInt(parts[0]);
var end = parseInt(parts[1]);

alert(start + "-" + end);

for (var strt = start; strt <= end; strt++)
{
    alert(strt);
}

http://jsfiddle.net/YrGHx/[^]

Posted 31-Jul-14 9:24am

Richard Deeming

Comments

Manudhiman 31-Jul-14 15:29pm

Thanks Buddy. I just skipped about parsing. hehe :P :)

RaisKazi 31-Jul-14 15:39pm

Good Answer, my 5.

Sergey Alexandrovich Kryukov 31-Jul-14 15:49pm

Well spotted, a 5.

The worst thing is the general trend of these days, at least in the beginners: to try to work with strings representing data. So, I suspect that the whole thing is not yet a reasonable solution. Where the "str" comes from? It's possible that it could be some data structure in first place, not yest another unreliable string...

—SA

[no name] 1-Aug-14 0:07am

Nice answer, well found. My vote of 5. I used to have the same problem like this :)