How Do I Replace In Afile

Question

1.00/5 (1 vote)

See more:

I am trying to write a program that generates number plates and assigns them to customers. It successfully generates the number plates and are free to be assigned to customers, but during the assigning the program closes abnormally and can't assign in dev c? here is the code so please help me.

C++

//Program to print license number plates e.g UAA 548A
/**********Copy the headers "stdio.h" and "conio.h" in the file****************/
          /* CombinationGenerator.h for use in the makefile while
         "stdlib.h" and "string.h" in the CombiantionAssignment.h */
/*******************************************************************************/


#include <stdio.h>
#include <conio.h>
#include <stdlib.h>
#include <string.h>

int main ()
{
  FILE *fp;
  int a,b,c,d,e,f,g,h,i=0;
  int q,p,r,s,x,y,z;
  long int n,sk,wrt,totalcmbs=0;
  char chr[]="UA"; char free[]="Free"; char space[]=" ";
  char ch[1];
  char *name,*combn,*rd1,*rd2,*rd3;
  n=0; q=1;
  x=65; y=0; z=65;
  //clrscr();

  printf("We are generating a pattern of order of this type - UAA 000A \n");
  printf("The pattern has already been chosen in the code as a license number with 3 number and 1 space as defaults \n");

//Prompting user for number of "Numbers" and number of "Spaces" 
  pattern:
  printf("choose an option below: \n");
  printf("1. Numbers 0 to 9 \n");
  printf("2. Spaces \n");
  printf("3. Words - to assign names to license numbers choose this option if the file already exists \n");
  scanf("%d",&a);

  if(a==1)
  {
    printf("How many numbers after the first 3 letters? - 3 is preferred by default \n");
    scanf("%d",&c);
     //if value for numbers has been entered as 3 goto generate-block otherwise prompt again
    if(d==1)
    {
      goto generate;
    }
    goto pattern;
  }

  else if(a==2)
  {
    printf("How many Spaces between the first 3 letters and the remaining letter-number combination?- 1 is deafault \n");
    scanf("%d",&d);
    //if value for spaces has been entered as one go to generate-block otherwise prompt for more entry
     
    if(c==3)
    {
      goto generate;
    }
    goto pattern;
  }

//if file already exists go to assign-block to assign free license numbers in the file to individuals
  else
  {
    goto assign;
  }


/************************* This is the end of main file ***********************************************/
  /* Copy and paste the code above (except headers) in a file and name it Combination.c to be used 
            in a makefile but maintain this original file separate for reference
******************************************************************************************************/


/************************ Beginning of Block for generating the patterns*****************************
     Copy and paste the code below in the file and name it CombinationGenerator.c to used in
                          the makefile
*****************************************************************************************************/                                    

  generate:

  fp=fopen("file.txt","a+");//open a file named file.txt. if it does not exist it will be created
  goto C;

/* z holds the ASCII value of the characters to be printed at the end of the license number
     combination (A-Z) or 65-90.
 * y holds the value of the 3-digit number to be printed from 0-999
     the preceding zeros are formatted in the fprintf() function.
 * x holds the ASCII value of the characters to be printed at the start after
     the first letters on each part of the license number combination (A-Z) or 65-90. 
*/

//This A-block prints the word "Free" at the end of every license number  
  A:
  if(z<=90)
  {
    fprintf(fp,"%c   Free          \n",z);//write with a newline charater to move to the next line in the file
  }
  z++;
  if(z>90)
  {
    goto B;
  }
  goto C;//goto C to start writing a new combination on a new line

//This B-block prints the 3-digit number
  B:
  if(z>90)
  {
    y++;
    if(y>999)
    {
      goto C;
    }
    z=65;
    goto C;
  }

  if(y<=999)
  {
    fprintf(fp,"%03d",y);
  }
  goto A;

//This C-block prints the first characters e.g "UA" and the "space" on every combination
  C:
  if(x>90)
  {
    fclose(fp);
    goto D;
  }
  if(y!=1000 && z!=91)
  {
    fprintf(fp,"%s%c",chr,x);
    for(g=1;g<=d;g++)
    {
      fputs(" ",fp);
    }
  }

  if(y>999 && z>90)
  {
    x++;
    y=0;
    z=65;
    goto C;
  }
  goto B;

//This D-block prompts the user whether to start assigning names to license numbers generated in the file
  D:
  printf("Choose whether to assign names to numbers or not \n");
  printf("1. yes \n");
  printf("2. no and exit \n");
  scanf("%d",&h);
  if(h==1)
  {
    goto assign;
  }
  printf("press any key to exit \n");
  getch();
  exit(0);
/*********************This is the end of the code for CombinationGenerator.c file**************/




/*****************This is the beginning of the code*******************************************
               for the file named CombinationAssignment.c 
                       till the end of the file
**********************************************************************************************/  
<big>
 assign:
  
  fp=fopen("file.txt","r+");

//loop through the file to count the lenght of each line in the file include the one for the newline character 
  while(fgetc(fp)!=EOF)
  {
    if(ch=="F")
    {
      p=n;//p holds the lenght of the start of the word "Free" in each line in the file
    } 
    
    if(ch=="\n")
    {
      n++;//n holds the value for length of each line in the file
      rewind(fp);
      break;
    }
    n++;
  }

  rewind(fp);//go back to the beginning of the file

//counting the total number of lines in the file(number of license numbers stored)
  while(fgetc(fp)!=EOF)
  {
    if(ch=="\n")
    {
      totalcmbs++;//totalcmbs holds the total number of license numbers (lines) in the file
    }
  }

//Prompt the user to enter names of individuals and numbers to be assigned
  Data:

  printf("Type the name of the indivivual to assign a license number \n");
  scanf("%s",&name);
  printf("Type the corresponding valid license number to be assigned e.g UAA 000A with one space between \n");
  scanf("%s",&combn);

//looping through each line in the generated file to check for a match of the number entered
  while(i<=totalcmbs)
  {
    if(q==1)//q counts the lines in the file
    {
      sk=1;//sk holds the value used for seeking 
    }
    else
    {
      sk=(n*q)+1;//value to use for changing the file pointer so that the right line is read at a time
    }
    fseek(fp,sk,SEEK_SET);
    fscanf(fp,"%s%s%s",rd1,rd2,rd3);//read one line in the file at a time
/* the first group of characters e.g "UAA" is stored in rd1, the next e.g "000A" 
   is stored in rd2 and the last e.g "Free" in rd3
*/
    strcat(rd1,space);//adding a space at the end of the first characters read 
    strcat(rd1,rd2);// combining the fisrt characters to the second with a space between them

//checking if there is a match of the users entered number with what is stored in the file  
    if(strcmp(rd1,combn)==0)
    {
       //if a match is found check if that match is free or not 
       if(strcmp(rd3,free)==0)//free holds the string "Free"
       {
	 rewind(fp);
	 wrt=(n*q)-(n-p);//length for seeking
	 fseek(fp,wrt,SEEK_SET);
	 fprintf(fp,"%s",name);//writing the name of individual entered in place of "Free" alongside the match found
	 fflush(stdin);
	 printf("Do you want to enter more names? \n");
	 printf("1. yes \n");
	 printf("2. no \n");
	 scanf("%d",&s);
	 if(s==1)
	 {
	   goto Data;//go back to start entering more data
	 }
	 break;
      }
      //if no match foung prompt the user again
      else
      {
	printf("The license number you entered is not free \n");
	printf("Do you want to enter another license number? \n");
	printf("1. yes\n");
	printf("2. no and exit\n");
	scanf("%d",&s);
	if(s==1)
	{
	  goto Data;
	}
	else
	{
	  exit(0);//terminate program if user does not want to enter more data
	}
      }
    }
    q++;//increment the number of lines in the file read
    //if no match is found the user entered a wrong license number from what is in the file
    if(q>=totalcmbs)
    {
      printf("The license number you entered is invalid \n");
      break;
    }
    i++;
  }// end of while loop

  fclose(fp);
  printf("press any key to exit \n");
  getch();</big>

/**************************code for CombinationAssignment.c ends here***********************/
}

Posted 5-Aug-14 0:47am

Ssekajjugo Edward

Updated 5-Aug-14 22:39pm

nv3

v6

Add a Solution

Comments

Richard MacCutchan 5-Aug-14 6:48am

Please use <pre> tags around your code to make it readable, and indicate what the error is and where it occurs.

Richard MacCutchan 5-Aug-14 6:50am

And with that many goto statements you are bound to have problems.

Ssekajjugo Edward 6-Aug-14 4:03am

Richard thanks bug thought goto would be easy

Richard MacCutchan 6-Aug-14 4:14am

Yes goto is easy, it is also a quick route to lots of bugs in your code. Learn to use proper structured code.

[no name] 5-Aug-14 7:13am

Do you always scream at people that you expect to get help from?

Ssekajjugo Edward 6-Aug-14 4:02am

Wesday am sorry for that.thanks

OriginalGriff 6-Aug-14 2:26am

1) DON'T SHOUT. Using all capitals is considered shouting on the internet, and rude (using all lower case is considered childish). Use proper capitalization if you want to be taken seriously.
2) Don't just dump your code on us: we don't want to wade through it looking for the relevant bits. Post only the relevant fragments so we can see them immediately.
3) As Richard has said, use code block tags to preserve the formatting and make it easier to read and understand.
4) Forget goto ever existed for at least 5 years. By that time you will understand when it is appropriate to use it.

Use the "Improve question" widget to edit your question and provide better information.

Ssekajjugo Edward 6-Aug-14 4:01am

Original Griff am sorry that i dint know but
thanks for that advice.but thought goto would be easy

OriginalGriff 6-Aug-14 4:11am

That's the problem: it is easy. Too easy.
But it produces something called "spaghetti code" which is difficult to understand, and harder to modify: using functions, and "proper" loop constructs means you end up with a more "thought out" end result - which is cleaner and easier to understand and change. The "goto problem" gets worse and worse as code gets bigger and more complex - so it's a very, very good idea to start out as you will go on: you will save yourself a heck of lot of time later!

Try something for me: print out a copy of your "main" function, and tape the pages together so it's all one piece of paper. Now take a red pen and draw lines between each "goto" and the label it "goes to". See what I mean about the spaghetti? :laugh:

Ssekajjugo Edward 6-Aug-14 5:21am

You mean i should drop goto and re-do the code

OriginalGriff 6-Aug-14 6:02am

That would be an excellent idea! :thumbsup:

Ssekajjugo Edward 6-Aug-14 6:16am

But time is up am supposed to hand it in as course work in like aday.it has one problem it is failing to register the generated number plates to auser.Because it generates them when they are free

OriginalGriff 6-Aug-14 6:36am

I'm not going to sit here and work out what your code does from a pile of spaghetti! That's just too much work for me to be interested in doing before I can even get close to starting to work out what your problem might be, let alone fixing it.

And I suspect your tutor may agree when it comes to marking it - he will have the same problem!
You have to consider other coders in this business: in this case the guy who has to understand this is going to mark it and give you a grade based on how difficult he finds it to do that. If you give him code he can look at and immediately think "Yes, I can see that works" wouldn't you give that a higher mark than one you have to work at for an hour before you have any idea what the author was thinking? Remember, he has a whole class full of these to look at, and he doesn't want to spend much time on marking! :laugh:

Ssekajjugo Edward 6-Aug-14 6:21am

the problem is around the assign area

R. Erasmus 6-Aug-14 3:05am

Hi, in you Data section of your code:
Should't


while (i <= totalcmbs)

be


while (i < totalcmbs)

?

Ssekajjugo Edward 6-Aug-14 4:00am

R.ErasmusThanks alot it helped me solve the
problem of closing un expectly but it doesnt
print in the text file to show that it
is registered.

R. Erasmus 6-Aug-14 5:18am

In your main function:
CHANGE:


else if(a==2)
{
  printf("How many Spaces between the first 3 letters and the remaining letter-number 
          combination?- 1 is deafault \n");
  scanf("%d",&d);

  if(c==3)


}

TO:


else if(a==2)
{
  printf("How many Spaces between the first 3 letters and the remaining letter-number 
          combination?- 1 is deafault \n");
  scanf("%d",&c); // <<<---------- NOTE I changed the 'd' to a 'c'

  if(c==3)


}

Ssekajjugo Edward 6-Aug-14 5:32am

Thanks alot but if you check out the text file with those licence plates.it creats then with aword free that means they are available to be assigned to customers when you assign its supposed to replace in the text file the word free with the name of the customer but it cant.any solution with that?

Ssekajjugo Edward 6-Aug-14 6:05am

when u change "d" to "c" it doesnt generate the number plates in the text file so i think that part is correct

R. Erasmus 6-Aug-14 7:48am

Are you sure? Where does c get its value from? It is then uninitialized (probably containing garbage) If I'm not mistaken you're doing a check to see whether c==3 but c is not initialized anywhere not set anywhere to contain a value... If you can show show me where you've initialized or set c I'll agree with you.

Ssekajjugo Edward 6-Aug-14 8:10am

Have tried to work upon the assigning part.where it assigns number plates to customers

R. Erasmus 6-Aug-14 8:21am

In assign: the variable 'ch' in not yet set. You need to first set it before you can do any checks on it.
Try this code in assign:


while((ch[0] = fgetc(fp))!=EOF)
  {
    if(ch=="F")
    {
      p=n;//p holds the lenght of the start of the word "Free" in each line in the file
    } 
    
    if(ch=="\n")
    {
      n++;//n holds the value for length of each line in the file
      rewind(fp);
      break;
    }
    n++;
  }
 
  rewind(fp);//go back to the beginning of the file

//counting the total number of lines in the file(number of license numbers stored)
  while((ch[0] = fgetc(fp))!=EOF)
  {
    if(ch=="\n")
    {
      totalcmbs++;//totalcmbs holds the total number of license numbers (lines) in the file
    }
  }

Ssekajjugo Edward 6-Aug-14 9:58am

while((ch = fgetc(fp))!=EOF){

that line gives an error which is (Lvalue required in function main)

R. Erasmus 6-Aug-14 10:19am

Sorry, didn't see that ch was an array:
To resolve this error:
while((ch[0] = fgetc(fp))!=EOF){

I've updated the code I posted.

Ssekajjugo Edward 6-Aug-14 10:32am

Now it generates another error in the same line that "Expression syntax in function main"

R. Erasmus 6-Aug-14 10:44am

No it cant be... I've pasted your code with the implemented update and I'm not getting any "Expression syntax in function main" error.

Ssekajjugo Edward 6-Aug-14 10:55am

if it worked and it replaces can you post the whole code as asoulution

Ssekajjugo Edward 6-Aug-14 11:06am

it has worked but trust me it doesnot update in the text file to show that the entered number plate has been registered to agiven user.and when you run it wen you register that part which has to print that you have registered doesnt show.thats after entering your name and the number plate you want

R. Erasmus 6-Aug-14 11:14am

yes its because that is but only a few bugs that I've fixed.... there are many more I'm guessing. Anyways I have to go now. hope you come right.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

R. Erasmus · Accepted Answer · 2014-08-05T23:34:00

So to make it official:
In Data section:
CHANGE:

C++

while (i <= totalcmbs)

TO:

C++

while (i < totalcmbs)

ALSO: (with regards to the next issue you posted)
In Main function:
CHANGE:

C++

else if(a==2)
{
  printf("How many Spaces between the first 3 letters and the remaining letter-number combination?- 1 is deafault \n");
  scanf("%d",&d);
  //if value for spaces has been entered as one go to generate-block otherwise prompt for more entry
     
  if(c==3)
  {
    goto generate;
  }
  goto pattern;
}

TO:

C++

else if(a==2)
{
  printf("How many Spaces between the first 3 letters and the remaining letter-number combination?- 1 is deafault \n");
  scanf("%d",&c);  // NOTE I changed the 'd' to a 'c'
  //if value for spaces has been entered as one go to generate-block otherwise prompt for more entry
     
  if(c==3)
  {
    goto generate;
  }
  goto pattern;
}

ALSO:
In Main function:
CHANGE:

C++

if(a==1)
{
  printf("How many numbers after the first 3 letters? - 3 is preferred by default \n");
  scanf("%d",&c);
   //if value for numbers has been entered as 3 goto generate-block otherwise prompt again
  if(d==1)
  {
    goto generate;
  }
  goto pattern;
}

TO:

C++

if(a==1)
{
  printf("How many numbers after the first 3 letters? - 3 is preferred by default \n");
  scanf("%d",&d); // NOTE: Changed from 'c' to 'd'
  //if value for numbers has been entered as 3 goto generate-block otherwise prompt again
  if(d==1)
  {
    goto generate;
  }

  goto pattern;
}

How Do I Replace In Afile

1 solution

Solution 3

Add your solution here

Preview 0

Existing Members

...or Join us