i am dealing with array of structures .this pgm is to input values into a arry of structures and to print the values. no compile error but it is printing garbage output.plz help me to find th error

Question

0.00/5 (No votes)

See more:

C++

//pgm using array of structures just input and print the array of structs
#include<stdio.h>
	struct emp
	{
	int eid;
	int sid;
	char* ename;
	};

main()
{
struct emp e[2];
int i,j;
		for(i=0;i<=2;i++)

		{
		e[i].eid=i+1;

		printf("enter name of employee %d\t",i+1);
		scanf("%s",&e[i].ename);
		printf("enter supervisor id of employee %d \n",i+1);
		scanf("%d",&e[i].sid);
		}

			for(j=0;j<=2;j++)
			{
			printf("%d,%s,%d \n",e[i].eid,e[i].ename,e[i].sid);
			}
}

output

enter name of employee 1	jith
enter supervisor id of employee 1 
101
enter name of employee 2	jeev
enter supervisor id of employee 2 
102
enter name of employee 3	jay
enter supervisor id of employee 3 
103
0,����w,0 
0,����w,0 
0,����w,0

Posted 10-Sep-14 1:32am

jithu ajith

Updated 10-Sep-14 3:10am

CPallini

v2

Add a Solution

Comments

[no name] 10-Sep-14 7:34am

Why are you using 'j' in your for loop but printing your array using 'i'?

jithu ajith 10-Sep-14 7:43am

sry that was a mistake during debugging;
i rectified it now core dump occured

new
output

enter name of employee 1 jith
enter supervisor id of employee 1
8
enter name of employee 2 jeev
enter supervisor id of employee 2
9
enter name of employee 3 jay
enter supervisor id of employee 3
11
Segmentation fault (core dumped)
[bats@localhost c]$

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2014-09-10T01:41:00

Quote:
struct emp e[2];

Here you are declaring an array having two items, namely e[0] and e[1].

While here

Quote:
for(i=0;i<=2;i++){/*...*/}

and here

Quote:
for(j=0;j<=2;j++){/*..*/}

You are assuming the array has three items, namely e[0], e[1] and the not existing e[2].
I see a problem...

[update]

Quote:
scanf("%s",&e[i].ename);

This is another mistake: you never allocated memory for the ename string.
You either define it as an array of characters, e.g

C

struct emp
    {
    int eid;
    int sid;
    char ename[64];
    };

(assuming 64 is a resonable maximum size for your strings)
or use the malloc function to allocate dynamic memory (that you have to release at the end), e.g.

C#

printf("enter name of employee %d\t",i+1);
        e[i].ename = (char *) malloc(64 * sizoef(char)); // assuming again 64 is a 'good enough' max length
        if (! e[i].ename)
        {
          // to do: handle malloc failure
        }
        scanf("%s",&e[i].ename);

[/update]

jithu ajith · Answer 2 · 2014-09-10T01:41:00

sry that was a mistake during debugging;
i rectified it now core dump occured

new
output

enter name of employee 1 jith
enter supervisor id of employee 1
8
enter name of employee 2 jeev
enter supervisor id of employee 2
9
enter name of employee 3 jay
enter supervisor id of employee 3
11
Segmentation fault (core dumped)
[bats@localhost c]$

i am dealing with array of structures .this pgm is to input values into a arry of structures and to print the values. no compile error but it is printing garbage output.plz help me to find th error

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0