Why this javascript code doesn't work?

Question

1.00/5 (3 votes)

See more:

Hello everybody,I'was developing Reversi(Othello) Game,I faced a scenario which i was going to detect empty places on the board,i wrote it(finally) but it's not exact.

please visit http://jsfiddle.net/huL3qoa3/[^] to see it.

when you click anywhere on the board,an alert will be shown that,if the position is empty or not,it is not working well,what's the problem?

please help me.

thanks for your valuable time.

TIA.

Posted 11-Sep-14 5:29am

AmiR1999

Updated 11-Sep-14 5:37am

v2

Add a Solution

2 solutions

Solution 1

probably because you have your boolean returns reversed?? I changed it to the following and was able to get it "working". I am using the term "working" very loose because I believe you have some other problems in the code.

JavaScript

function IsEmpty(x, y) {
    var Temp1 = document.getElementsByTagName("img");
    var i;

    var xx, yy;
    xx = (x * 50) - 50 + ("px");
    yy = (y * 50) - 50 + ("px");

    for (i = 0; i < Temp1.length; i++) {
        if (Temp1[i].style.left != xx && Temp1[i].style.top != yy) {
            Empty = false;
        } else {
            Empty = true;
            break;
        }
    }

    return Empty;
}

Posted 11-Sep-14 6:30am

Dennis E White

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

AmiR1999 · Accepted Answer · 2014-09-12T17:32:00

I solved it myself simply by changing && to || in following function:

JavaScript

function IsEmpty(x,y)
{
var Temp1=document.getElementsByTagName("img");
var i;

var xx,yy;
xx=(x*50)-50+("px");
yy=(y*50)-50+("px");

for(i=0;i<Temp1.length;i++)
{

if(Temp1[i].style.left!=xx || Temp1[i].style.top!=yy )
{
Empty=true;
}
else
{
Empty=false;
break;
}


}