Queue count is too big because of keeping adding

Question

2.00/5 (1 vote)

See more:

I have a string queue to be added in a thread.

C#

private Queue<string> m_Queue = new Queue<string>();
Thread threadRead = new Thread(() => Read(Collection, threadCount));
threadRead.Start();
private void Read(string[] Collection, int port)
       {
           while (true)
           {
               lock (m_SyncVar)
               {
                   for (int j = 0; j < Collection.Length; j++)
                   {
                       for (int i = 0; i < port; i++)
                       {
                           m_Queue.Enqueue(Collection[j]);
                       }
                   }
               }
           }
       }

It keep add the items so eventually the queue outflow, memory blown up.
I want to set a boundry for the queue, say when the count = 100 then break the while loop. Should I put the condition in the lock?

Thanks for code.

Posted 19-Sep-14 11:01am

zhshqzyc

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2014-09-19T11:50:00

Lock is the unconditional statement. Instead, if you need a limit, you can add this condition by wrapping Queue.Enqueue in your own method which checks up Queue.Count before adding. It would be the best to wrap System.Collections.Queue in your own wrapper class totally hiding all direct access to implementing queue instance and its members. This is especially useful, because you also have the lock functionality, which you also need to wrap.

Please see:
http://msdn.microsoft.com/en-us/library/System.Collections.Queue%28v=vs.110%29.aspx[^],
http://msdn.microsoft.com/en-us/library/system.collections.queue.enqueue(v=vs.110).aspx[^],
http://msdn.microsoft.com/en-us/library/system.collections.queue.count(v=vs.110).aspx[^].

—SA

Matt T Heffron · Accepted Answer · 2014-09-19T12:44:00

Look into the System.Collections.Concurrent.BlockingCollection<T> class:
http://msdn.microsoft.com/en-us/library/dd267312(v=vs.100).aspx[^]
It allows for thread-safe access Adding and Taking.
It also allows for setting a limit on the number of items in the collection, blocking the Adding thread if the collection is full.

Queue count is too big because of keeping adding

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0