Code not recognizing incorrect input

Question

0.00/5 (No votes)

See more:

I wrote a program that prompts user input for a math question. It says "Correct" if the input is correct, but it also says "correct" if the input is not correct. Can't find the error. Any suggestions? Thank you!

XML

<script language="JavaScript"></script>
<style type="text/css">
.style1 {
    font-family: Arial;
    font-size: x-small;
}
</style>
</head>

<body><p><script><!-- hide from old browser

var inputText, feedback;   // variables for holding user input and feedback

var inputValue, loopCounter, correctCount, temp;  // integer variables



loopCounter = 0;  // set the starting value of variables

correctCount = 0;



var num1, num2;



num1 = Math.round(Math.random()*100);

num2 = Math.round(Math.random()*100);



inputText = window.prompt("What's " + num1 + " plus " + num2 + "? Enter -1 to stop.", "0");



inputValue = parseInt(inputText);



while (inputValue != -1){

          temp = num1 + num2;

          if (inputValue == temp){

            correctCount++;

            feedback = "Correct! ";

          } else if (inputValue != temp) {

            feedback = "Sorry. Not correct";

          }

          loopCounter++;

          num1 = Math.round(Math.random()*100);

          num2 = Math.round(Math.random()*100);

          inputText = "";

          inputText = window.prompt("" + feedback + "Now, what's " + num1 + " plus " + num2 + "? (Enter -1 to stop:)", "0");

          inputValue = 0;

          inputValue = parseInt(inputText);

}



document.write("<font size='5' color='#0000FF'><b>You have got " + correctCount + " correct out of " + loopCounter + " tries.</b></font>")

Posted 29-Sep-14 14:41pm

Codster7

Updated 29-Sep-14 15:27pm

v4

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ChauhanAjay · Answer 1 · 2014-09-29T15:21:00

Solution 1

Change the following line from

JavaScript

if (inputValue = temp)

To

JavaScript

if (inputValue == temp)

Posted 29-Sep-14 15:21pm

ChauhanAjay

Member 10289840 · Answer 2 · 2014-09-29T20:27:00

Solution 3

Dude Your Code Just Works Fine.

Use FireBug in mozilla to debug your code

Posted 29-Sep-14 20:27pm

Member 10289840

Updated 29-Sep-14 20:29pm

v2