C# Encrypt passwords on Sql Server 2008 using SHA1

Question

0.00/5 (No votes)

See more:

SQL-Server-2008R2

I have designed a Log In System using c# where the username and password is checked in SQL server 2008 before loading the main page.I wish to encrypt the stored password on the database.Is it possible to do it using c# and SHA1 algorithm?

Following is my stored procedure

SQL

ALTER procedure [dbo].[proc_UserLogin]
 @userid varchar(20),
  @password nvarchar(50)
  As 

  declare
  @ReturnVal              varchar(500)


SET NOCOUNT ON      

  if exists(select userid,password from LoginManager where userid=@userid and password=@password)
  set @ReturnVal='0|Logged in Successfully'
  else
  set @ReturnVal='1|Login Failed/Username does not exist'

  select @ReturnVal

C# Code

C#

public void button1_Click(object sender, EventArgs e)
        {
            mainform = new Form1();
            string[] v;

            OleDbConnection conn = new OleDbConnection("File Name=E:\\Vivek\\License Manager\\License Manager\\login.udl");

            try
            {

                conn.Open();
                string query = "EXEC dbo.proc_UserLogin'" + username.Text+ "', '" + password.Text+"'";
                OleDbCommand cmd = new OleDbCommand(query, conn);
                string s = Convert.ToString(cmd.ExecuteScalar());
                v= s.Split('|');
                if (v[0]=="0")
                {
                    mainform.Show();
                    this.Hide();
                }
                else
                {
                    MessageBox.Show("Please enter correct user credentials and try again");
                }


             }

             catch (Exception ex)
             {
                 MessageBox.Show(ex.Message);
             }


              conn.Close();

         }

Can anyone suggest changes to the code ,so that password encryption can be accomplished.?

Thanks

Posted 8-Oct-14 2:19am

vivek murli

Add a Solution

Comments

ZurdoDev 8-Oct-14 8:45am

Just search google or this site for c# encryption. There are tons of examples.

Richard Deeming 8-Oct-14 8:45am

Your code is susceptible to SQL Injection[^]. You should fix that gaping security vulnerability before worrying about encrypting your stored procedure!

Richard Deeming 8-Oct-14 8:47am

Once you've fixed the code, take a look at this article[^] to see how to store passwords properly.

Hint: Encrypting passwords is a very bad idea - almost as bad as storing them in plain text.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

mahesh591 · Answer 1 · 2014-10-08T07:20:00

You can Encrypt a user password using Scalar function in SQL Server.
lets see

Execute the below code in SSMS( Below function return type is varchar )

USE [DB_NAME]
GO
/****** Object:  UserDefinedFunction [dbo].[PSWD_ENCRYPT]    Script Date: 10/8/2014 10:36:47 PM ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
-- =============================================
-- Author:		<MAHESH>
-- Create date: <04-11-2013>
-- Description:	<Password Encryption using SHA Algorithm>
-- =============================================
Create FUNCTION [dbo].[PSWD_ENCRYPT] 
(
	-- Add the parameters for the function here
	@pwd varchar(50)

)
returns varchar(50)
AS
BEGIN
	-- Declare the return variable here
	declare @Result varchar(50);
		declare @hexbin varbinary(max)
	set @hexbin = HASHBYTES('SHA1',HashBytes('SHA1', @pwd));
	set @Result = (select  cast('' as xml).value('xs:hexBinary(sql:variable("@hexbin") )', 'varchar(max)'));
	-- Return the result of the function
	RETURN  @Result

END

Usage

Insertion

SQL

declare @pswd varchar(50)
set @pswd='mahesh';
insert into dbo.users(uid,pswd) values ('mahesh',dbo.PSWD_ENCRYPT(@pswd))

Select:

SQL

declare @pswd varchar(50)
set @pswd='mahesh';
select uid from dbo.users where uid=@uid and pswd=dbo.PSWD_ENCRYPT(@pswd)

Update :

SQL

update dbo.users set pswd=dbo.PSWD_ENCRYPT(@pswd) where .....