How to reduce stackOverFlow C#

Question

0.00/5 (No votes)

See more:

I have the following method to generate a random array that might be 2x2 up to 7x7, but in order to be valid it should meet a certain condition.
That's why I relied on recursion inside the method which causes StackOverFlow because sometimes it take more than 6700 tried with no results and the program crashes.
Is there anyway to reduce that chance?

C#

public double [,] GenerateKey(int dimension)
       {
           recCounter++;
           bool valid;
           Random rand = new Random();
           double[,] key = new double[dimension, dimension];
           for (int i = 0; i < key.GetLength(0); i++)
           {
               for (int j = 0; j < key.GetLength(1); j++)
               {
                   key[i, j] = rand.Next(-26, 27);
               }
           }
           valid = checkKey(key);
           if (!valid)
           {
              key= GenerateKey(dimension);
           }
           else
           {
               MessageBox.Show("Valid Key! :)");
               return key;
           }
           return key;
       }

Posted 11-Oct-14 22:46pm

Wael Tayara

Add a Solution

Comments

[no name] 12-Oct-14 6:17am

And why you Need to solve that with recursion?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

User 11060979 · Accepted Answer · 2014-10-12T00:25:00

Why recursion? A Loop is enough.

C#

public double [,] GenerateKey(int dimension)
       {
           bool valid;
           Random rand = new Random();
           double[,] key = new double[dimension, dimension];

           while(true)
           {
              recCounter++;
              for (int i = 0; i < key.GetLength(0); i++)
              {
                  for (int j = 0; j < key.GetLength(1); j++)
                  {
                      key[i, j] = rand.Next(-26, 27);
                  }
              }
              valid = checkKey(key);
              if (valid)
              {
                  MessageBox.Show("Valid Key! :)");
                  break;
              }
           }
           return key;
       }