shadowing or generic properties?

Question

0.00/5 (No votes)

See more:

Hi friends,
I have two classes PaymentMethod and EditPaymentMethod with following properties:

public class PaymentMethod
    {
        public int TenantID { get; set; }
        public string Market { get; set; }
        public virtual List<string> CreditCard { get; set; }
        public virtual List<string> DebitCard { get; set; }
        public virtual List<string> BPay { get; set; }
    }

    public class EditPaymentMethod 
    {
        public int TenantID { get; set; }
        public string Market { get; set; }
        public List<Multicheckbox> CreditCard { get; set; }
        public List<Multicheckbox> DebitCard { get; set; }
        public List<Multicheckbox> BPay { get; set; }
    }

    public class Multicheckbox
    {
        public string CheckboxName { get; set; }
        public bool IsChecked { get; set; }
    }

As you can see both the classes differ only in CreditCard, DebitCard and BPay

I want to avoid this code duplication, how can I achieve this using shadowing properties or making it generics?

Any suggestion on the same?

Thanks in advance

Posted 6-Nov-14 17:10pm

dhage.prashant01

Updated 6-Nov-14 17:25pm

v2

Add a Solution

Comments

Maciej Los 7-Nov-14 3:30am

Sounds like derived class...

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

dhage.prashant01 · Accepted Answer · 2014-11-09T23:36:00

I made use of generic class as below

XML

public class GenericPaymentMethod<T>
{
    public int TenantID { get; set; }
    public string Market { get; set; }
    public List<T> CreditCard { get; set; }
    public List<T> DebitCard { get; set; }
    public List<T> BPay { get; set; }
}

public class PaymentMethod
{
    public GenericPaymentMethod<string> MyProperty { get; set; }
}

public class EditPaymentMethod
{
    public GenericPaymentMethod<Multicheckbox> MyProperty { get; set; }
}

And in model I accessed in following way

XML

public static EditPaymentMethod GetPaymentMethodDetails(int tenantID) {

    EditPaymentMethod obj = new EditPaymentMethod();
    obj.MyProperty = new GenericPaymentMethod<Multicheckbox>();

    obj.MyProperty.TenantID = 1000;

    obj.MyProperty.Market = "AU";

    obj.MyProperty.CreditCard = new List<Multicheckbox>(){
        new Multicheckbox { CheckboxName = "Amex", IsChecked = true },
        new Multicheckbox { CheckboxName = "Master Card", IsChecked = false },
        new Multicheckbox { CheckboxName = "Visa", IsChecked = true }
    };

    obj.MyProperty.DebitCard = new List<Multicheckbox>(){
        new Multicheckbox { CheckboxName = "Amex", IsChecked = false },
        new Multicheckbox { CheckboxName = "Master Card", IsChecked = true },
        new Multicheckbox { CheckboxName = "Visa", IsChecked = false }
    };

    obj.MyProperty.BPay = new List<Multicheckbox>(){
        new Multicheckbox { CheckboxName = "Savings Cheque", IsChecked = true },
        new Multicheckbox { CheckboxName = "Credit Card", IsChecked = false },
    };

    return obj;
}

And in View

<div>
        <div>
            @Html.Label("Debit Card :")
        </div>
        @for (int i = 0; i < Model.MyProperty.DebitCard.Count; i++)
        {
            <div>
                <div>
                    @Html.CheckBoxFor(x => x.MyProperty.DebitCard[i].IsChecked)
                </div>
                <div>
                    @Model.MyProperty.DebitCard[i].CheckboxName
                    @Html.HiddenFor(x => Model.MyProperty.DebitCard[i].CheckboxName)
                </div>
            </div>
        }
        @Html.HiddenFor(model => Model.AtleastOneDebitCardSelected)
        @Html.ValidationMessageFor(model => Model.AtleastOneDebitCardSelected)
    </div>