Ul element toggle problem

Question

0.00/5 (No votes)

See more:

HTML

@if (ViewBag.categories != null)
   {        <ul id="category">
      @foreach (var Categories in @ViewBag.categories)
       {   if(@Categories.ParentID==null)
            {    <li id="categoryli"> @Categories.Name 
                      <ul id="subcategory" class="submenu"> 
                         @foreach(var ParentId in @ViewBag.categories)
                         {
                               if( @Categories.CategoryID==@ParentId.ParentID)
                                 {
                                  <li>
                                   @ParentId.Name
                                   </li>
                                  }}
                </ul>          </li> 
             }        }
            </ul>
    }

I have written my jquery like this

JavaScript

$(document).ready(function () {
        
        $('#category >li').click(function () {
            debugger;
            if ($('#category >li > #subcategory').hasClass('submenu')) {
                //$(this).removeClass("submenu");
                $('ul#category >li > #subcategory').slideToggle('slow');
            }
                   });
    });

css

CSS

.submenu {
    display:none;
}

while clicking on particular li all nested ul elements are toggling.

Posted 13-Nov-14 22:59pm

Member 10212775

Updated 13-Nov-14 23:01pm

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Nathan Minier · Answer 1 · 2014-11-14T01:32:00

First things first, if your already in a code block, you do not want @ toggles except when directly rendering to the browser.

Secondly, you're calling a foreach loop on precisely the same collection in your submenu. That's likely not what you meant to do.

You also want to apply an id as a unique element in HTML, you're using it as if it were a class, multiple instances of the same id in the same document: this will break jQuery. Better to apply classes to your tags instead.

If you have a collection of parent and children nodes just thrown together as well, that's not the best data access scheme. Anyway, here's a corrected version of your Razor, which should do what it looks like you're trying to do:

C#

@if (ViewBag.categories != null)
{        <ul id="category">
        @foreach (var category in ViewBag.categories)
        {
            if (category.ParentID == null)
            {
            <li class="categoryli">
                @category.Name
                <ul class="submenu">
                    @foreach (var subcategory in category.categories)
                    {
                        if (category.CategoryID == subcategory.ParentID)
                        {
                            <li>
                                @subcategory.Name
                            </li>
                        }
                    }
                </ul>
            </li>
            }
        }
    </ul>
}

If ParentID is an it you'll need to do if(category.ParentID == 0)

Now you'll need to modify your jQuery:

JavaScript

$(function () { 
    $('.submenu').hide();       
    $('.category >li').click(function () {
        $(this).children('.submenu').slideToggle('slow');
    });
});

And finally, I would remove the submenu css, or at least remove the display:none; from it.