Problem with Do Until... Loop

Question

2.00/5 (1 vote)

See more:

Message box is shown and when I click OK it appears again with the same response "Player guess is smaller than Computer" or "Player guess is bigger than computer". I must use Do While or Do until loops as this is for a school assignment.

VB

Public Class Form1
    Dim RandomNumber As New Random
    Dim ComputerNumber As Integer
    Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        ComputerNumber = RandomNumber.Next(1, 100)
    End Sub
    Private Sub btnNew_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnNew.Click
        ComputerNumber = RandomNumber.Next(1, 100)
    End Sub

    Private Sub btnCheck_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnCheck.Click
        Dim PlayerGuess As Integer
        Dim Attempt As Integer
        PlayerGuess = txtPlayerGuess.Text
        Do Until (PlayerGuess = ComputerNumber)
            If PlayerGuess < ComputerNumber Then
                MsgBox("Player number Smaller than computer")
                Attempt = Attempt + 1
            ElseIf PlayerGuess > ComputerNumber Then
                MsgBox("Player number Bigger than computer")
                Attempt = Attempt + 1
            Else
                MsgBox("Congratulations")
            End If
        Loop
    End Sub

    Private Sub btnExit_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnExit.Click
        Me.Close()
    End Sub


End Class

Posted 16-Nov-14 10:15am

Member 11238467

Add a Solution

Comments

Wombaticus 16-Nov-14 16:29pm

Well of course it will - there is no player input in your Do...Loop

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Nelek · Answer 1 · 2014-11-16T11:23:00

The problem is that you are entering the do...while when clicking object, but you are not leaving it at all, because you are not giving the possibility to change the number and click another time. In other words, what you have is evaluating only the very first number you input and then remains in the loop forever.

I am not sure if it is a must, that you are using a form and clicks but...

As example I am going to give you the pseudocode of a console application

main
   do
      print "give me a number, to end the game type [exit]"
      get the input

      if (bigger)
         print "number is bigger"
      else if (smaller)
         print "number is smaller"
      else
         print "that is the number"
    
    while ((input not equal to number) or (input not equal to "exit")
end

do you see the difference? once you get into the loop you have to give a chance to correct that number or get out of the loop.

In your example, a possibility (not elegant but feasible) would be to use non-modal messagebox, so the user can type another number and then click ok.