How Do I Remove Rows From A Datatable If Few Of The Columns Are Blank ?

Question

0.00/5 (No votes)

See more:

Dear Developers,

I want to remove some rows from my datatable if some of the columns are blank.
i tried below code,

C#

int rowcount = datatabletest.Rows.Count;

             for (int i = 0; i < rowcount; i++)
             {
                 if (datatabletest.Rows[i]["Mcolumn1"].ToString().Trim() == "" || dtExport.Rows[i]["column2"].ToString().Trim() == "")
                 {
                    datatabletest.Rows.Remove(datatabletest.Rows[i]);

                 }
             }

but the problem here is if the first row meets the condition the that row will be deleted from the table.this will reduce one row count table.but the code will check for the last row since we have written it inside the loop.But code can not find in that position since one row is already deleted.Its throwing No row on that place exception.

For example:
my table contains 3 rows.
First row has null values so it will be deleted by code.But the code will check for the row at position 3 since for loop will loop 3 times as row count is 3.
but the first row is deleted so now table has only 2 rows.So when code check for row 3 position it couldn't find and throwing error.

I tried with for each loop also but doesn't work.Got below error
System.InvalidOperationException: Collection was modified; enumeration operation might not execute.

so please share your logic. please let me know if question is not clear.

Posted 17-Nov-14 6:03am

Am Gayathri

Updated 17-Nov-14 17:39pm

george4986

v2

Add a Solution

3 solutions

Solution 3

Hi,
Review below code, where you can get result using LINQ query on a DataTable[^].

C#

DataTable datatabletest = new DataTable();
DataTable dtNewTableTest = new DataTable();

var vDataTable = from vRow in datatabletest.AsEnumerable()
             where vRow.Field<string>("Column1") != "" || vRow.Field<string>("Column2") != ""
             select vRow;

dtNewTableTest = vDataTable.CopyToDataTable();

AsEnumerable() returns IEnumerable<DataRow>. If you need to convert IEnumerable<DataRow> to a DataTable, use the CopyToDataTable() extension.

Posted 17-Nov-14 17:35pm

Dusara Maulik

Updated 17-Nov-14 17:36pm

v2

Comments

Am Gayathri 18-Nov-14 1:30am

IF i use linq here, if there is no items which meets condition ("Column1") != "" || vRow.Field<string>("Column2") != "" then i will get an error in below code
dtNewTableTest = vDataTable.CopyToDataTable();
since the table is empty.

Am Gayathri 18-Nov-14 2:46am

Thanks

Solution 2

Hi,
You can remove the columns from the selection query itself. That will be better I think. Please try it.

Posted 17-Nov-14 16:29pm

Jineesh TR

Comments

Am Gayathri 18-Nov-14 2:46am

Thanks

Jineesh TR 18-Nov-14 6:36am

You are welcome friend..

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ccrngd1 · Accepted Answer · 2014-11-17T06:07:00

An easy solution may be to just adjust your row count and index on any removal.

Try this:

C#

int rowcount = datatabletest.Rows.Count;

             for (int i = 0; i < rowcount; i++)
             {
                 if (datatabletest.Rows[i]["Mcolumn1"].ToString().Trim() == "" || dtExport.Rows[i]["column2"].ToString().Trim() == "")
                 {
                    datatabletest.Rows.Remove(datatabletest.Rows[i]);
                    rowcount--;
                    i--;
                 }
             }