Creating a countdown timer in c++

Question

0.00/5 (No votes)

See more:

I wanted to create a minute and seconds countdown timer in c++. So, i tried something and it worked. But i dont know if my approach is correct and i want to be sure if i was doing it the right way. So, please can anyone comment on my code and suggest me if anything is required to be changed.
Thanks .

C++

#include <iostream>
#include <conio.h>
#include <Windows.h>

using namespace std;

int main()
{
	int m,s;
	int total;


	
	cout<<"Enter m and s"<<endl;
	cin>>m>>s;


	
		for(int sec = s; s>=0; s--)
		{
			
			cout<<"You have "<<"minutes"<<m<<"seconds"<<s<<endl;
			Sleep(200);
			
			if(s ==0)
			{
             total = m*60;

			 for(int min = total; total>=0; total--)
			 {
		 cout<<"You have the remaining seconds"<<total<<endl;
				 Sleep(200);
			 }



			}
		}

	



	 system("pause");


}

Posted 22-Nov-14 23:38pm

Surajit Das

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2014-11-22T23:48:00

It's kinda odd - and probably very annoying for users, but that's neither here nor there.

Look at it: what is the point of assinging s to sec? You never use sec again...
And what happens when m is 10, and s is 30?
It starts off telling the user he has 10 mins and 30, 10 and 29, ...10 and 1.
Then it launches into 600 seconds, 599 seconds,...
Well - almost, it doesn't count in seconds at all - 200 is not a second, it's 2/10ths of a second.

I would do it differently:
Read in the minutes and seconds.
Generate a "total" in seconds.
Loop until the total is zero.
In the loop, convert the current total into minutes and seconds and print it.

In fact what I'd do is take the current date and time, add the offset and set that as the target time. I'd then read the current time in the loop and compare that to the target - this allows for system events outside the application which slow the progress by suspending the app. But that's probably a little advanced for a beginner!