How do I return this string array values

Question

0.00/5 (No votes)

See more:

C#

Method 1:

public void UnReserveSelectedDevices(List<int> deviceIds, string userName)
        {                 
            string[] reservebyNames = new string[0];
            reservebyNames = GerReserveby(deviceIds, userName, false);              
        }


Method 2:

public string[] GerReserveby(List<int> ids, string userName, bool reserveOn)
        {
            using (NamesTestDbContext db = new NamesTestDbContext())
            {
                foreach (int id in ids)
                {
                    FleetNames device = db.FleetNames.Find(id);
                    if (!device.ReservedBy.Equals(userName) &amp;&amp; !reserveOn)
                    {
                        string[] reserveby = new[] {device.ReservedBy};   //return new[] { myString };
                    }
                }
            }

           <b> return ;</b>   ??????

        }

Could any one please let me know, How do I return the 'reservby' (Method:2) array values? and stores it to 'reservebyNames' from (Method:1)

Posted 6-Dec-14 0:26am

vasanthkumarmk

Updated 6-Dec-14 0:36am

/\jmot

v4

Add a Solution

Comments

OriginalGriff 6-Dec-14 6:49am

We can;t answer that - because we have no idea what your FleetNames class is all about, or what it contains. So we have no idea where the strings you want to return are coming from.
Use the "Improve question" widget to edit your question and provide better information.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

/\jmot · Accepted Answer · 2014-12-06T01:01:00

C#

instead of string[], use List<string> in method2;..</string>

C#

public List<string> GerReserveby(List<int> ids, string userName, bool reserveOn)
        {
          List<string> liRes=new List<string>();

            using (NamesTestDbContext db = new NamesTestDbContext())
            {
                foreach (int id in ids)
                {
                    FleetNames device = db.FleetNames.Find(id);
                    if (!device.ReservedBy.Equals(userName))
                    {
                      liRes.Add(device.ReservedBy.ToString());
                    }
                }
            }

          return liRes;

        }

For Duplicate check..
use this..

C#

if(!liRes.Contains(device.ReservedBy.ToString()))
  {
     liRes.Add(device.ReservedBy.ToString());
  }

Marcin Kozub · Accepted Answer · 2014-12-06T00:51:00

Solution 1

Hello,

Try like this:

C#

public string[] GerReserveby(List<int> ids, string userName, bool reserveOn)
{
    string[] reservedBy = null;
    using (var db = new NamesTestDbContext())
    {
        reservedBy = db.FleetNames.Where(x => ids.Contains(x.Id) && (!x.ReservedBy.Equals(userName) && !reserveOn)).Select(x => x.ReservedBy).Distinct().ToArray();
    }

    return reservedBy;
}

In your method you're iteraing all ids and making query in every loop pass. It will take much longer time to get all data especially when you can get all data with one query.

I don't know your DB structure but I think that will get you the point :)

You can find many tutorial on CRUD operations here on CodeProject.

[Update - For comment]
To retrieve reservedBy names without duplicates use Distinct method. Code updated.

Good luck!

Posted 6-Dec-14 0:51am

Marcin Kozub

Updated 6-Dec-14 2:25am

v4

Comments

vasanthkumarmk 6-Dec-14 6:59am

Ya... I missed that. Thank you so much Marcin Kozub......

Marcin Kozub 6-Dec-14 7:01am

You're welcome :)

/\jmot 6-Dec-14 7:03am

+5, easy and simple one.

Marcin Kozub 6-Dec-14 7:51am

Thx! :)

Maciej Los 6-Dec-14 7:06am

Good job!

Marcin Kozub 6-Dec-14 7:51am

Thx! :)

vasanthkumarmk 6-Dec-14 8:22am

Good one..... How to remove duplicate 'reservedBy' values, before return.

Marcin Kozub 6-Dec-14 8:26am

I've updated my answer.

vasanthkumarmk 6-Dec-14 8:32am

Thanks...

BillWoodruff 6-Dec-14 23:08pm

+5

Marcin Kozub 7-Dec-14 4:12am

Thx! :)

How do I return this string array values

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0

Existing Members

...or Join us