c# moving files automatically with filesystemwatcher

Question

1.00/5 (2 votes)

See more:

Greetings,

is it possible to move file automatically when a new jpg files created in a defined folder to a different folder? i think i can use filesystemwatcher but i couldn't do it.

C#

fileSystemWatcher1.EnableRaisingEvents = true;
         string dst = @"c:\deneme1";
         string src = @"c:\deneme2";

         if (Directory.GetFiles(src).Length == 0)
         {
             string[] move = Directory.GetFiles(src, "*.jpg");
             foreach (string file in move)
             {
                 string file = Path.GetFileName(file);
                 string dstfile = Path.Combine(dst, file);
                 File.Move(file, dstfile);


             }
         }
         else
         {
             string[] move2 = Directory.GetFiles(src, "*.jpg");
             foreach (string file in move2)
             {
                 string file2 = Path.GetFileName(file);
                 string dstfile = Path.Combine(dst, file2);
                 File.Move(file, dstfile);
             }

         }

this is not working perfectly. when i start this code. it will move every jpg files to "deneme1" folder but when a new jpg file will appear in "deneme2" folder when code is working, it won't move this new file. how can i move these new files too?

Posted 2-Jan-15 13:53pm

Member 10587827

Add a Solution

Comments

BillWoodruff 2-Jan-15 20:15pm

When you say "it won't move this new file," what exactly do you observe ? Do you get an error message ? Does your code execute but "nothing happens" ? Have you verified you are getting the 'Changed or 'Created FileSystemWatcher Event fired ?

Member 10587827 2-Jan-15 20:19pm

just nothing happens. there is no error message. i think code doesn't check new files for move them

BillWoodruff 2-Jan-15 20:49pm

Have you put break-points in your 'Changed and 'Created FileSystemWatcher Event Handlers and observed whether your code is getting called ?

Sergey Alexandrovich Kryukov 2-Jan-15 20:16pm

We can discuss is, but the main question is: why?
—SA

Member 10587827 2-Jan-15 20:19pm

i just need it for my project

Sergey Alexandrovich Kryukov 2-Jan-15 20:34pm

It doesn't explain anything. It really sounds pretty much as a technology abuse...
If you explain your ultimate goals, maybe you could get alternative suggestions, but if you don't want it, you are welcome to stay stuck.
—SA

Member 10587827 2-Jan-15 20:39pm

all i need is a code that watches a folder for new jpg files and when a new jpg will be created in source folder, move it to destination folder...

Sergey Alexandrovich Kryukov 2-Jan-15 20:55pm

I know. No problem. If you don't want to answer, don't.
—SA

Philippe Mori 2-Jan-15 20:19pm

This code does not make much sense. You do same thing in if part that you do in else part.

Sergey Alexandrovich Kryukov 2-Jan-15 20:35pm

Agree. Hard to sat what OP is trying to do; the first paragraphs of the question tells us more. Anyway, the use of FileSystemWatcher is not shown and could be a problem.
—SA

Philippe Mori 2-Jan-15 21:04pm

- Since Directory.GetFiles is a slow operation, you don't want to call it twice. Why would you check once for any file and then for JPG only?
- Also to what event are you responding?
- And why don't you use arguments of the watcher? If you are using a watcher, then you really should use information it gives on the change instead of enumerating files again...

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

George Jonsson · Answer 1 · 2015-01-02T17:44:00

Looks like you are not using the FileSystemWatcher functionality at all, or you don't show all your code. I can't see that you are using the events in your code.

This example should do the job for you. MSDN has more extensive examples: FileSystemWatcher Class[^]

C#

FileSystemWatcher fileSystemWatcher1 = new FileSystemWatcher();
fileSystemWatcher1.NotifyFilter = NotifyFilters.FileName;
fileSystemWatcher1.Filter = "*.jpg";
fileSystemWatcher1.Path = @"c:\temp\deneme2";
fileSystemWatcher1.Created += fileSystemWatcher1_Created;
fileSystemWatcher1.EnableRaisingEvents = true;

void fileSystemWatcher1_Created(object sender, FileSystemEventArgs e)
{
    if (e.ChangeType == WatcherChangeTypes.Created)
    {
        string dest = Path.Combine(@"C:\temp\deneme1", e.Name);
        if (File.Exists(dest))
        {
            File.Delete(e.FullPath);    // For example
        }
        else
        {
            File.Move(e.FullPath, dest);
        }
    }
}

Member 10587827 · Answer 2 · 2015-01-02T15:18:00

Solution 1

this looks work great for me

C#

bool xxx;
            fileSystemWatcher1.EnableRaisingEvents = true;
            string dst = @"c:\deneme1";
            string src = @"c:\deneme2";
            Find:
            string[] move = Directory.GetFiles(src, "*.jpg",SearchOption.TopDirectoryOnly);
            if (move.Length != 0)
            {
                xxx = true;
                foreach (string file in move)
                {
                    string a = Path.GetFullPath(file);
                    string files = Path.GetFileName(file);
                    string dstfile = Path.Combine(dst, files);
                    File.Move(a, dstfile);

                }

            }

            else
            {
                xxx = false;
                Console.WriteLine("Empty");
                System.Threading.Thread.Sleep(5000);

            }
            goto Find;

Posted 2-Jan-15 15:18pm

Member 10587827

Comments

Sergey Alexandrovich Kryukov 2-Jan-15 21:57pm

Makes no sense at all. You sleep for 5 seconds. It means it does not really work. If you think it's great, I'm really sorry for you.
—SA

George Jonsson 3-Jan-15 0:04am

What he did was to create a loop with a goto statement and checks the directory for files every 5 sec. Not the solution I would have chosen.

Sergey Alexandrovich Kryukov 3-Jan-15 1:01am

Of course not :-)
—SA

George Jonsson 2-Jan-15 23:59pm

Every time a sleep is added to "solve" a problem in the code, the actual problem is not actually solved. We have all done this one time or another, but it usually comes back and bites you in the ass later.
Basically what you have done here is to create an infinite loop using a goto statement.
I have only used goto when I did some simple basic programs in the 80's.
Since then I have avoided using it.

Sergey Alexandrovich Kryukov 3-Jan-15 1:01am

Exactly.
—SA

Philippe Mori 3-Jan-15 9:45am

In addition to other comments:
1) It make no sense to use goto when a simple while(true) loop would do exactly the same thing (and without redudant checks).
2) Variables are poorly named.
3) What is the purpose of the FileSystemWatcher if you don't use it.
4) It is not clear from the question that you want code for a console application.