giving infinite loop please help

Question

0.00/5 (No votes)

See more:

C++

#include <stdio.h>
#include <stdlib.h>

struct node{
int data;
struct node* next;
};
struct node* head; //GLOBAL DECLARATION//
void insert(int x);
void print();
int main()
{    int i,n,x;
    head=NULL; //EMPTY LIST//
    printf("how many number?");
     scanf("%d",&n);
    for(i=0;i<n;i++){>
    printf("ENTER THE NUMBER:\n");
    scanf("%d",&x);
    insert(x);
    print();
    } getch();
}
void insert(int x)
{
   struct node* temp=(struct node*)malloc(sizeof(struct node));
    temp->data=x;
    temp->next=head ;
    head=temp;
   }
void print()
{
    struct node* temp=head; //TEMP IS LOCAL VARIABLE//
    printf("LIST IS:");
    if (temp->next!=NULL)
    {
	printf("%d",temp->data);
	if(temp->next->next==NULL)
	printf("%d",temp->next->data);
	print(temp->next);
    }
    print("\n");

}

[edit]Code block added - OriginalGriff[/edit]

Posted 11-Jan-15 1:30am

Member 11366679

Updated 11-Jan-15 1:35am

OriginalGriff

v2

Add a Solution

3 solutions

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-01-11T01:53:00

Um.
Are you sure you want to call print from within itself?

C#

void print()
{
    struct node* temp=head; //TEMP IS LOCAL VARIABLE//
    printf("LIST IS:");
    if (temp->next!=NULL)
    {
    printf("%d",temp->data);
    if(temp->next->next==NULL)
    printf("%d",temp->next->data);
    print(temp->next);   <<<<<--- What does this call?
    }
    print("\n");  <<<<<--- What does this call?

}

Try this:

C#

void print()
{
    struct node* temp=head; //TEMP IS LOCAL VARIABLE//
    printf("LIST IS:");
    if (temp->next!=NULL)
    {
    printf("%d",temp->data);
    if(temp->next->next==NULL)
    printf("%d",temp->next->data);
    printf(temp->next);   
    }
    printf("\n");
}

Try this:
Your print function still doesn't work (it needs a loop) but at least it wonlt give you stack overflow... :laugh:

Kornfeld Eliyahu Peter · Accepted Answer · 2015-01-11T02:06:00

There are two problems I can see here:
1. Your last print call inside the print() function should have been printf
2. You are running print() in a recursive loop but temp always initialized to head so in ever recursion you start from the beginning and not from the last already printed...
Try this:

C++

int main()
{
    int i,n,x;
    head=NULL; //EMPTY LIST//
    printf("how many number?");
    scanf("%d",&n);
    for(i=0;i<n;i++){>
    printf("ENTER THE NUMBER:\n");
    scanf("%d",&x);
    insert(x);
    print(head); // !!! change here !!!
    } getch();
}

C++

void print(node* root)
{
    struct node* temp = root; //TEMP IS LOCAL VARIABLE// // !!! change here !!!
    printf("LIST IS:");
    if (temp->next!=NULL)
    {
    printf("%d",temp->data);
    if(temp->next->next==NULL)
    printf("%d",temp->next->data);
    print(temp->next);
    }
    printf("\n"); // !!! change here !!!
}

Member 11366679 · Accepted Answer · 2015-01-11T02:05:00

#include
#include

struct node{
int data;
struct node* next;
};
struct node* head; //GLOBAL DECLARATION//
void insert(int x);
void print();
int main()
{ int i,n,x;
head=NULL; //EMPTY LIST//
printf("how many number?");
scanf("%d",&n);
for(i=0;i
printf("ENTER THE NUMBER:\n");
scanf("%d",&x);
insert(x);
print();
} getch();
}
void insert(int x)
{
struct node* temp=(struct node*)malloc(sizeof(struct node));
temp->data=x;
temp->next=head ;
head=temp;
}
void print()
{
struct node* temp=head; //TEMP IS LOCAL VARIABLE//
printf("LIST IS:");
while(temp!=NULL)
{ printf("%d",temp->data);
temp=temp->next;
}
printf("\n");
}

giving infinite loop please help

3 solutions

Solution 1

Solution 3

Solution 2

Add your solution here

Preview 0

giving infinite loop please help

3 solutions

Solution 1

Solution 3

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us