how to solve index out of range Exception?

Question

0.00/5 (No votes)

See more:

SQL-Server-2008R2

C#

namespace BusinessLayer
{
   public class BusinessLogic
    {
       public IEnumerable<employee> Employees
       {
           get
           {
               string cs = ConfigurationManager.ConnectionStrings["DBCS"].ConnectionString;
               List<employee> employees = new List<employee>();
               using (SqlConnection con = new SqlConnection(cs))
               {
                   SqlCommand cmd = new SqlCommand("SPGETEMPLOYEE", con);
                   cmd.CommandType = CommandType.StoredProcedure;
                   con.Open();
                   SqlDataReader dr = cmd.ExecuteReader();
                   while (dr.Read())
                   {
                       Employee emp = new Employee();
                       emp.Id = Convert.ToInt32(dr["Id"]);
                       emp.name = dr["Name"].ToString();
                       emp.gender = dr["Gender"].ToString();
                       emp.mobile = dr["Mobile"].ToString();
                       emp.doj = Convert.ToDateTime(dr["doj"]);
                       employees.Add(emp);
                   }


               }


               return Employees;
           }

       }
    }
}

getting the exception while reading the data from database. why can any one help me
Here

C#

emp.Id = Convert.ToInt32(dr["Id"]);

thanks in advance

Posted 8-Feb-15 22:30pm

raxhemanth

Updated 8-Feb-15 22:33pm

TheRealSteveJudge

v3

Add a Solution

Comments

nagendrathecoder 9-Feb-15 4:44am

Check executing SPGETEMPLOYEE stored procedure in SQL server mgmt studio and verify the result. Check is the result showing all columns you are trying to fetch properly or not.

raxhemanth 9-Feb-15 4:47am

okey let me see
CREATE PROCEDURE [dbo].[SPGETEMPLOYEE]
AS
BEGIN
select EmpId,Name,Gender,MobileNumber,Dateofjoining,[Address] from tblEmployee
End
GO
this is the procedure i have written

nagendrathecoder 9-Feb-15 4:53am

There you go.
You have EmpId field in SP and you are fetching Id field.

nagendrathecoder 9-Feb-15 5:05am

Match all column names and use same column names as defined in stored procedure.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

nagendrathecoder · Accepted Answer · 2015-02-08T22:54:00

Solution 1

Use this:

C#

emp.Id = Convert.ToInt32(dr["EmpId"]);

Posted 8-Feb-15 22:54pm

nagendrathecoder

Comments

raxhemanth 9-Feb-15 5:03am

notworking same error tharowning

nagendrathecoder 9-Feb-15 5:05am

Match all column names and use same column names as defined in stored procedure.

OriginalGriff · Accepted Answer · 2015-02-08T23:02:00

You need to match the names of your columns with the names you access they with from the DataReader:

SQL

select EmpId,Name,Gender,MobileNumber,Dateofjoining,[Address] from tblEmployee

Does not match the column names with the code:

C#

emp.Id = Convert.ToInt32(dr["Id"]);
emp.name = dr["Name"].ToString();
emp.gender = dr["Gender"].ToString();
emp.mobile = dr["Mobile"].ToString();
emp.doj = Convert.ToDateTime(dr["doj"]);

So try:

C#

emp.Id = Convert.ToInt32(dr["EmpId"]);
emp.name = dr["Name"].ToString();
emp.gender = dr["Gender"].ToString();
emp.mobile = dr["MobileNumber"].ToString();
emp.doj = Convert.ToDateTime(dr["DateofJoining"]);

And by preference, don't use Convert or ToString: cast it instead:

C#

emp.Id = (int) dr["EmpId"];
emp.name = (string) dr["Name"];
emp.gender = (string) dr["Gender"];
emp.mobile = (string) dr["MobileNumber"];
emp.doj = (DateTime) dr["DateofJoining"];

Using Convert and ToString implies that you have stored the values in your DB as strings instead of the "proper" datatypes - which would give you enormous problems later on.