error reporting set to null reference .i want to send multiple values selected by user to enter into single column

Question

1.00/5 (2 votes)

See more:

VS2012

C#

string strCheckValue = "";
          if (checkBox1.Checked)
          {
              strCheckValue = strCheckValue + "," + checkBox1.Text;
          }
          if (checkBox2.Checked)
          {
              strCheckValue = strCheckValue + "," + checkBox2.Text;
          }
          if (checkBox3.Checked)
          {
              strCheckValue = strCheckValue + "," + checkBox3.Text;
          }
          if (checkBox4.Checked)
          {
              strCheckValue = strCheckValue + "," + checkBox4.Text;
          }
          if (checkBox5.Checked)
          {
              strCheckValue = strCheckValue + "," + checkBox5.Text;
          }
          if (checkBox6.Checked)
          {
              strCheckValue = strCheckValue + "," + checkBox6.Text;
          }
          if (checkBox7.Checked)
          {
              strCheckValue = strCheckValue + "," + checkBox7.Text;
          }
          if (checkBox8.Checked)
          {
              strCheckValue = strCheckValue + "," + checkBox8.Text;
          }
          strCheckValue = strCheckValue.TrimStart(',');
          con.Open();
          cmd.CommandText =("insert into Table1 values('"+strCheckValue+"')");
          cmd.ExecuteNonQuery();
          da.Update(ds, "Table1");
          MessageBox.Show("Data Inserted ");
          con.Close();

Posted 12-Mar-15 18:52pm

MayankSemwal

Add a Solution

Comments

Sergey Alexandrovich Kryukov 13-Mar-15 2:01am

Every line of this code screams: this is something opposite to programming. Write code accurately, don't repeat anything, don't use immediate constants, don't hard-code, and so on...
You repeat the same thing 8 times...
—SA

MayankSemwal 13-Mar-15 2:09am

i understand... i did with checkbox.items.selected . but was not working. so i tried to go with this. even this messy code throwing an error. help me find out

Sergey Alexandrovich Kryukov 13-Mar-15 8:43am

Throw it all out, write everything accurately. Only then we can address things.
—SA

Santosh K. Tripathi 13-Mar-15 5:56am

-SA is correct i want to give a a suggestion you can do like this also

string strCheckValue = string.Empty;

strCheckValue += GetCheckBoxText(checkBox1);
strCheckValue += GetCheckBoxText(checkBox2);
strCheckValue += GetCheckBoxText(checkBox3);
strCheckValue += GetCheckBoxText(checkBox4);
strCheckValue += GetCheckBoxText(checkBox5);
strCheckValue += GetCheckBoxText(checkBox6);
strCheckValue += GetCheckBoxText(checkBox7);

strCheckValue = strCheckValue.TrimStart(',');

private string GetCheckBoxText(CheckBox chkBox)
{
string result = string.Empty;
if (chkBox.Checked)
{
result = chkBox.Text + ",";
}
return result;
}

Sergey Alexandrovich Kryukov 13-Mar-15 8:42am

This code is dreaded. No single line should be repeated. Instead of 7 controls, should be arrays, loops instead of repeated lines.
—SA

Santosh K. Tripathi 14-Mar-15 21:29pm

could you modify and post, above code. it will helpful.
thanks

MayankSemwal 27-Mar-15 6:08am

private void button3_Click(object sender, EventArgs e)
{
string str = "";
if (checkBox1.Checked)
{
str += checkBox1.Text+",";
}
if (checkBox2.Checked)
{
str += checkBox2.Text + ",";
}
if (checkBox3.Checked)
{
str += checkBox3.Text + ",";
}
if (checkBox4.Checked)
{
str += checkBox4.Text + ",";
}
if (checkBox5.Checked)
{
str += checkBox5.Text + ",";
}
if (checkBox6.Checked)
{
str += checkBox6.Text + ",";
}
if (checkBox7.Checked)
{
str += checkBox7.Text + ",";
}
if (checkBox8.Checked)
{
str += checkBox8.Text + ",";
}
DataRow drNewRow = dtMedicineParticular.NewRow();

drNewRow["medName"] = str;
drNewRow["medQty"] = txtPackets.Text;

dtMedicineParticular.Rows.Add(drNewRow);

gvMedicineParticulars.DataSource = dtMedicineParticular;
foreach (DataGridViewRow drvMedicine in gvMedicineParticulars.Rows)
{
MedNo = drvMedicine.Cells[0].Value.ToString();
MedPacket = drvMedicine.Cells[1].Value.ToString();

string insertQriTreat = "Insert into Treatment_Details(Treat_Med_No,Treat_Issue_Date,Treat_Qty,Treat_Due_Date,Treat_P_ID,Treat_P_Pkg) values ('" + MedNo + "',#" + IssueDateMed + "#," + MedQty + ",#" + dueDate + "#," + PatientID + "," + MedPacket + ")";

DBT.exeQuery(insertQriTreat);
}

Santosh K. Tripathi 27-Mar-15 7:02am

Hi,
Good one.

By the way, i thinks it can be more optimize, as -SA said.

MayankSemwal 28-Mar-15 1:20am

thanks ,and how could it be done..

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)