Database not updating

Question

0.00/5 (No votes)

See more:

Hi, I am using below code in VB 2008 to update a table in MS Access 2010. Its not updating, no error as well. Whats is wrong with below code.

VB

Dim cons, ins As String
        cons = "Provider=Microsoft.ACE.OLEDB.12.0;Data Source=C:\Queue Manager - Offline\Queue Manager - Offine.accdb"
        Dim con As New OleDbConnection(cons)
        con.Open()
        Dim cmd As New OleDbCommand
        ins = "UPDATE OrderInfo SET InitialBatchID ='" & 5000 & "' WHERE 'GLID Number' = '" & TextBox9.Text & "'"
        cmd.CommandText = ins
        cmd.Connection = con
        cmd.ExecuteNonQuery()
        cmd.Dispose()
        MsgBox("success")
        con.Close()

Posted 18-Mar-15 0:21am

Shafiul Alam

Add a Solution

Comments

Maciej Los 18-Mar-15 7:59am

Have you tried to execute above query in MS Access database?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-03-18T00:36:00

Could be anything: we can't tell from that (and we can't test your code, because we don't have access to your database.)

So start with the debugger: put a breakpoint on the first line of that code, and run your app in the debugger. When it reaches the breakpoint, execution will stop, and let you step through your code and see exactly what is happening.

But please, don't do it like that. Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

Maciej Los · Accepted Answer · 2015-03-18T02:06:00

Please, read my comment to the question.

I see at least 2 reasons of above behaviour:
1) Connection string is incomplete!
Should be:

VB

cons = "Provider=Microsoft.ACE.OLEDB.12.0;Data Source=C:\myFolder\myAccessFile.accdb; Persist Security Info=False;"

2) Update statement could be wrong!
a) If InitialBatchID and GLID number are numeric fields, you should remove ' arounding values.
b) If field name contains space between words, you should add [] bracket around it: [GLID number] instead of 'GLID number'

Finally:
If executable is in the same folder, you need to move it into another folder.
OriginalGriff is right. You should use parametrized queries.

Database not updating

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0