Cant get foreach to work. Undefined index's!

Question

0.00/5 (No votes)

See more:

Hi,

Recently ive been trying to use PDO for better security and I've come across an error that I cant fix. I think it may be related to the FetchAll() and/or foreach.

This is my code:

PHP

$type = general;

$db = Database::getConnection();
		$query = 'SELECT * FROM threads WHERE threadTopic=:threadTopic';
		$output = $db->prepare($query);
		$results = $output->execute(array(':threadTopic' => $type));
			if (count($results) > 0) {
				echo "<table class=\"discussion\">\n";
				echo "<tr><th colspan=2>Thread Name</th><th>Replies</th><th>Author</th></tr>\n";
					$rows = $output -> fetchAll();
					$name = $rows['threadName'];
					$body = $rows['threadBody'];
					$by = $rows['threadBy'];
					$date = $rows['dateCreated'];
					$sticky = $rows['threadSticky'];
					$image = '<img src="images/userIcon.gif"></img>';
					foreach ($rows as $row){
						echo "<tr>";
						echo"<td>".$image."</td>";
						echo"<td>".$name."<br>".$body."</td>";						
					}
					echo "</tr>\n";
					echo "</table>";
				}

The table and table headings are being displayed but the foreach is not working and is saying that my variables from the count are all undefined.

Help, please?

Posted 22-Mar-15 7:57am

jba1991

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thomas Daniels · Accepted Answer · 2015-03-22T08:08:00

After fetching the rows, you attempt to set variables directly from $rows, for example $name = $rows['threadName'];. But that won't work because 'threadName' is only a valid index when you use it on one row, not on the collection of rows. So, you have to fetch these variables inside your foreach (from $row), not outside the foreach:

PHP

echo "<table class=\"discussion\">\n";
echo "<tr><th colspan=2>Thread Name<<th>Replies</th><table><thead><th>Author</th></thead></table></tr>\n";
$rows = $output -> fetchAll();
foreach ($rows as $row){
    $name = $row['threadName'];
    $body = $row['threadBody'];
    $by = $row['threadBy'];
    $date = $row['dateCreated'];
    $sticky = $row['threadSticky'];
    $image = '<img src="images/userIcon.gif">';
    echo "<tr>";
    echo"<td>".$image."</td>";
    echo"<td>".$name."<br>".$body."</td>";				
}
echo "</tr>\n";
echo "</table>";