Solution please?There was an error parsing the query. [ Token line number = 1,Token line offset = 77,Token in error = S ]

Question

0.00/5 (No votes)

See more:

There was an error parsing the query. [ Token line number = 1,Token line offset = 77,Token in error = S ]

My Code

C#

SqlCeConnection conn = new SqlCeConnection("Data Source=E:\\Project Final_Year\\Project Final\\MyProject\\ERU Implementation\\VirtualPetedit\\VirtualPet\\MyDB.sdf");
           string query = "INSERT INTO Events (event_name,event_descrption,event_type,date) VALUES('" + textBox1.Text + "', '" + textBox2.Text + "','" + comboBox1.SelectedItem.ToString() + "','" + dateTimePicker2.Value + "');";

           //SqlCommand cmd = new SqlCommand();
           try
           {
               conn.Open();
              // SqlDataAdapter adapter = new SqlDataAdapter();
               SqlCeCommand command = new SqlCeCommand(query, conn);

               command.ExecuteNonQuery();
               conn.Close();

               MessageBox.Show("Event added Successfully..!!");
           }
           catch (Exception err)
           {
               MessageBox.Show(err.Message);
           }

Posted 29-Mar-15 23:46pm

Abdul Rahman BCS

Updated 30-Mar-15 0:15am

Herman<T>.Instance

v2

Add a Solution

Comments

Andy Lanng 30-Mar-15 6:00am

This query is VERY open to SQL injection. That could be your issue here too.

Please post the query as it appears after being constructed so we can see the whole query as it is when run.

Herman<T>.Instance 30-Mar-15 6:15am

What are the values you add to the query text?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-03-30T00:14:00

Please, don't do it like that!
Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

The chances are that that will also cure your problem.

C#

string query = "INSERT INTO Events (event_name,event_descrption,event_type,date) VALUES(@NM, @ED, @ET, @DT);";
try
   {
   conn.Open();
   SqlCeCommand command = new SqlCeCommand(query, conn);
   command.Parameters.AddWithValue("@NM", textBox1.Text);
   command.Parameters.AddWithValue("@ED", textBox2.Text);
   command.Parameters.AddWithValue("@ET", comboBox1.SelectedItem);
   command.Parameters.AddWithValue("@DT", dateTimePicker2.Value);
   command.ExecuteNonQuery();