ExecuteNonQuery: Connection property has not been initialized.

Question

0.00/5 (No votes)

See more:

C#

SqlConnection con;
SqlCommand cmd;
con = new SqlConnection(ConfigurationManager.ConnectionStrings["sqlCon"].ToString());

try
{
   if (con.State == ConnectionState.Closed)
      con.Open();
}
catch { }

cmd= new SqlCommand("INSERT INTO [seismic_database_creation].[dbo].[tblFile] ([File_Name],[CreationDate]) VALUES('" + name + "'' " + temp + "')),con");

cmd.ExecuteNonQuery();

Posted 15-Apr-15 2:06am

Member 11527624

Updated 15-Apr-15 2:16am

phil.o

v2

Add a Solution

3 solutions

Solution 2

You have a typo there:

C#

cmd= new SqlCommand("INSERT INTO [seismic_database_creation].[dbo].[tblFile] ([File_Name],[CreationDate]) VALUES('" + name + "'' " + temp + "')", con);

Please read up on Sql-Parameters, you should use these instead of concatenating the values into your sql-strings. Sample here[^].

Posted 15-Apr-15 2:20am

Sascha Lefèvre

Comments

Member 11527624 15-Apr-15 9:41am

Thanks all now its working :)

Member 11527624 15-Apr-15 9:42am

I have dont this one with sql normal queries but how to do it in stored procedure?

Sascha Lefèvre 15-Apr-15 9:49am

Here's a good sample:
http://www.aspsnippets.com/Articles/Calling-Insert-SQL-Server-Stored-Procedures-using-ADO.Net.aspx

Member 11527624 16-Apr-15 3:12am

Thanks...Its useful link

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Accepted Answer · 2015-04-15T02:23:00

Try:

C#

SqlConnection con;
SqlCommand cmd;
con = new SqlConnection(ConfigurationManager.ConnectionStrings["sqlCon"].ToString());
 
try
{
   if (con.State == ConnectionState.Closed)
      con.Open();
}
catch { }

cmd = new SqlCommand("INSERT INTO [seismic_database_creation].[dbo].[tblFile] ([File_Name], [CreationDate]) VALUES(@name, @temp)", con);
cmd.Parameters.AddWithValue("@name", name);
cmd.Parameters.AddWithValue("@temp", temp);
cmd.ExecuteNonQuery();

The values were not correctly specified (there was a comma missing) ; moreover, the best practice is to use parameterized queries to prevent any SQL injection attack. Plus, the ending double-quotes were not correctly positioned.

OriginalGriff · Accepted Answer · 2015-04-15T02:18:00

Um...

C#

cmd= new SqlCommand("INSERT INTO [seismic_database_creation].[dbo].[tblFile] ([File_Name],[CreationDate]) VALUES('" + name + "'' " + temp + "')),con");

Lets just rip some stuff out to make it more obvious:

C#

cmd= new SqlCommand("...'" + name + "'' " + temp + "')),con");

Your double quote is in the wrong place...
Try:

C#

cmd= new SqlCommand("INSERT INTO [seismic_database_creation].[dbo].[tblFile] ([File_Name],[CreationDate]) VALUES('" + name + "'' " + temp + "'))",con);

But please, don't swallow exceptions - at the very least log them, otherwise you don't know why subsequent code fails...

ExecuteNonQuery: Connection property has not been initialized.

3 solutions

Solution 3

Solution 1

Solution 2

Add your solution here

Preview 0