conditional values in filter statement

Question

0.00/5 (No votes)

See more:

SQL-Server-2014

hello

i have a query than i want have conditional value in filter
i am nube in sql
please help me
this is my script:

SQL

DECLARE @InvCode NVARCHAR(20)
SET @InvCode = NULL

SELECT SD.* FROM [Accountting].[SaleInvoiceDetails] SD
	INNER JOIN [Accountting].[SaleInvoice] SI ON SD.[InvCode] = SI.[InvCode]
	WHERE SD.[InvCode] = (CASE WHEN @InvCode IS NULL THEN SD.[InvCode] ELSE @InvCode END)
	AND   CASE WHEN @InvCode IS NULL THEN SI.[Status] IN (1,2) ELSE SI.[Status] = SI.[Status] END

i want if invcode is null then filter status of SI table in 1,2 value and if InvCode is not null then does not filter anything so SI.[Status] = SI.[Status]

how can i implement?
help please

Posted 1-May-15 4:41am

daghune

Updated 1-May-15 5:14am

Tomas Takac

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tomas Takac · Accepted Answer · 2015-05-01T05:28:00

You cannot use CASE like it was a control flow statement. It's a complex function that returns a value. You can then compare the value to something else. In your case it would be better to drop the CASE entirely and use simple AND/OR to specify the condition:

SQL

WHERE (@InvCode IS NULL OR SD.[InvCode] = @InvCode)
  AND (@InvCode IS NOT NULL OR SI.[Status] IN (1,2))

I believe this is much more readable than the CASE.