How Can I make my if statement to be for each individual ?

Question

0.00/5 (No votes)

See more:

PHP

if(isset($_POST['submit']))
{
  if(!empty($_POST['value1'] && $_POST['value2'] && $_POST['value3']))
  {
     //do something
  }
  elseif(!empty($_POST['value1'] && $_POST['value2']))
  {
     //do something (value 3 must not be posted***!)
  }
  elseif(!empty($_POST['value1']))
  {
     // do something (value 2 and 3 must not be posted***!)  
  }
}

Hi , my code above ... its probably wrong and the fact that it can pick the 3 if statements while I need it to pick only one of the 3 and can I write it any simpler ? Im posting a checkboxes value Using POST metod ... thanks!

Posted 17-May-15 7:54am

TekMe

Updated 17-May-15 8:07am

Frankie-C

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sascha Lefèvre · Answer 1 · 2015-05-17T08:15:00

Yes, it can be written in a bit more elegant way - provided that there's no use for the case that value1 and value3 are set but not value2:

PHP

if(isset($_POST['submit']))
{
  if(!empty($_POST['value1']))
  {
    if($_POST['value2'])
    {
      if($_POST['value3'])
      {
        // do something that requires all values
      }
      else
      {
        // do something that requires only value1 and value2
      }
    }
    else
    {
      // do something that requires only value1
    }
  }
}

If you (here or somewhere else) need to check some $_POST[..]-value in multiple if-statements I would recommend that you assign it to some variable to use that from that point on, which will make it a bit more easy to read. Example here for the case that it would actually make sense to check what I excluded above (value1 and value3 but not value2):

PHP

if(isset($_POST['submit']))
{
  $value1empty = empty($_POST['value1']);
  $value2empty = empty($_POST['value2']);
  $value3empty = empty($_POST['value3']);

  $value1only = !$value1empty &&  $value2empty &&  $value3empty;
  $value1and2 = !$value1empty && !$value2empty &&  $value3empty;
  $value1and3 = !$value1empty &&  $value2empty && !$value3empty;
  $allValues  = !$value1empty && !$value2empty && !$value3empty;

  if($value1only)
  {
  }
  elseif($value1and2)
  {
  }
  // ...
}