overriding window.open stops href to work

Question

1.00/5 (1 vote)

See more:

JavaScript

function targetWindow(name) {
    if(isMobile()){
        return '_self';
    }
    return name;
}

function isMobile() {
    var fnIsIpadNative = window['isMobileNative'];
    return fnIsIpadNative !== undefined && fnIsIpadNative();
}

window.open = function (open) {
    return function (url, name, features) {
        name = targetWindow(name);
        return open.call(window, url, name, features);
    };
}(window.open);

I dont know why this code stops href to work.

Posted 26-May-15 1:39am

markand911

Add a Solution

Comments

Sergey Alexandrovich Kryukov 26-May-15 9:41am

How do you think it's supposed to work? What did you want to achieve?
—SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2015-05-26T03:48:00

In JavaScript, there is no such concept as "overriding". This is not an object-oriented language. No wonder, if you don't understand what you are doing, something may not work the way you illusions suggest you. :-)

But yes, assignment to the function object window.open resembles "overriding" in some aspects. But the code after "window.open =" is full of nonsense. You create It's enough to look at the first problem. Essentially, this function does nothing. You create some other function object inside the handler and, by some weird reason, return this object from the outer function. You don't show any code calling window.open. You don't show any code calling the returned inner function. This is not how original window.open function works. It is supposed to actually create a new instance of a browser window and show it, not to return a function object which is never called. It is supposed to return the reference to a new window object, not to the function object: https://developer.mozilla.org/en-US/docs/Web/API/Window/open[^].

Please don't ask "what to do?" You may get some more help only if you explain what did you want to achieve.

—SA