Click here to Skip to main content
Click here to Skip to main content

"if" with no code block parenthesis

, 12 Feb 2011
Rate this:
Please Sign up or sign in to vote.
Avoid using "if" with no code block parenthesis
Though it is supported, You should not use "if" without parenthesis for code block.
 
You should use:
if(condition)
{
// Your code 
}
 
and you should not use:
 
if(condition)
// Your code
 
One of my colleagues encountered the problem due to the unparenthesized "if".
 
The story goes like this:
 
His code was like this:
if(condition)
   System.out.println("This is log message to be printed on Console");
 
for( int i = 0; i < 10; i ++ )
{
    //Some important Code 
}
For final release, he globally replaced the System.out.println with //System.out.println so that all SOP statements would be commented.
But due the use of unparenthesized "if", the for loop went inside the if which was not desirable.
 
and the product started crashing.....
 
So the situation was ....Product was running properly if we keep all SOP.
 
After scanning the code throughly, we found out the culprit .....if with no code block parenthesis OMG | :OMG:

License

This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

About the Author

PrafullaVedante
Software Developer Symantec Corporation
India India
No Biography provided

Comments and Discussions

 
GeneralReason for my vote of 5 You learn something new every day. ... PinmemberZamirF15-Feb-11 9:17 
GeneralIndivara is completely correct - the issue is not so much th... PinmemberPete Goodsall14-Feb-11 2:37 
Indivara is completely correct - the issue is not so much the use or otherwise of brackets in the context described but that of insufficient / incorrect testing: your colleague was sloppy!
GeneralReason for my vote of 5 AGREED!! I don't even like the if's... PinmemberJoe119386911-Feb-11 5:41 
GeneralHave to agree with Indivara on this. PinmemberAlbert Holguin10-Feb-11 12:43 
GeneralGood. Pinmembershakil030400310-Feb-11 3:34 
GeneralI see the danger here, but the bigger issue seems to be glob... PinsubeditorIndivara9-Feb-11 22:40 
QuestionIS THERE ANY RULE ? Pinmembersudheer muhammed10-Feb-11 0:40 
AnswerRe: IS THERE ANY RULE ? PinmemberAbdur Rehman Raza Khan - dontumindit13-Feb-11 11:44 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.

| Advertise | Privacy | Mobile
Web04 | 2.8.140721.1 | Last Updated 13 Feb 2011
Article Copyright 2011 by PrafullaVedante
Everything else Copyright © CodeProject, 1999-2014
Terms of Service
Layout: fixed | fluid