Click here to Skip to main content
Click here to Skip to main content
Alternative Tip

An Easy Way To Query a Database

, 14 Feb 2011
Rate this:
Please Sign up or sign in to vote.
The following samples should take advantage of using statements and furthermore built in features of the ADO.NET framework. Furthermore, if you open a connection, make sure you open it at the latest time possible and close it as soon as possible.Edit: While I was originally not trying to...
The following samples should take advantage of using statements and furthermore built in features of the ADO.NET framework. Furthermore, if you open a connection, make sure you open it at the latest time possible and close it as soon as possible.
 
Edit: While I was originally not trying to change too much of the original content, I might as well to incorporate all of the suggestions posted below. As woric and I noticed, the exception handling is generally not a good idea, so it can be removed and handled at a higher level. Though, the using statement should be used to close the connection, so the try/finally isn't necessary. Then, as Fzelle pointed out, the SqlDataAdapter can be passed the connection string and query to simplify that method.
 
public DataSet select_query(string query, string con_str)
{
  using (SqlDataAdapter da = new SqlDataAdapter(query, con_str))
  {
    DataSet ds = new DataSet();
    da.Fill(ds);  // Automatically opens/closes connection.
    return ds;
  }
}
public int modify_query(string query, global_data data)
{
  using (SqlConnection con = new SqlConnection(data.Con_Str))
  {
    using (SqlCommand comd = new SqlCommand(query, con))
    {
      con.Open();
      int x = comd.ExecuteNonQuery();
      con.Close();
      return x;
    }
  }
}

License

This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Share

About the Author

Andrew Rissing
Software Developer (Senior)
United States United States
Since I've begun my profession as a software developer, I've learned one important fact - change is inevitable. Requirements change, code changes, and life changes.
 
So..If you're not moving forward, you're moving backwards.

Comments and Discussions

 
GeneralReason for my vote of 5 Clear and Short. Pinmembergopalomar30-Mar-11 23:21 
GeneralReason for my vote of 5 Fine code Pinmvpthatraja5-Mar-11 3:52 
GeneralReason for my vote of 5 Nice code, very clear and readable. PinmemberFrancisco Tirado22-Feb-11 3:18 
GeneralHi Andrew, I would probably agree. The general idea I put in... PinmemberDrABELL16-Feb-11 9:03 
GeneralI already voted 5 for this solution and would like just to p... PinmemberDrABELL15-Feb-11 16:26 
GeneralRe: Checking the state is unnecessary. The calling "Close" twic... PinmemberAndrew Rissing16-Feb-11 3:14 
GeneralReason for my vote of 5 Very elegant and practical solution;... PinmemberDrABELL15-Feb-11 16:20 
Generalsorry dear, i had a confusion, but its clear now, thnx for s... PinmemberAbdur Rehman Raza Khan - dontumindit15-Feb-11 7:55 
Generalwith the DataAdapter. Why do you think there is an overload ... PinmemberAbdur Rehman Raza Khan - dontumindit14-Feb-11 18:36 
with the DataAdapter.
Why do you think there is an overload with the querystring and the connectionstring?
GeneralRe: I don't follow what you're trying to say. Can you complete ... PinmemberAndrew Rissing15-Feb-11 4:30 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.

| Advertise | Privacy | Mobile
Web02 | 2.8.140827.1 | Last Updated 14 Feb 2011
Article Copyright 2011 by Andrew Rissing
Everything else Copyright © CodeProject, 1999-2014
Terms of Service
Layout: fixed | fluid