Click here to Skip to main content
Click here to Skip to main content

Refactoring Tips - Tip 11

, 10 Mar 2010
Rate this:
Please Sign up or sign in to vote.
Refactoring Tips - Tip 11Tip 11Refactoring 'OR' type of conditions - In a method,if we have multiple conditional statements,with the same result. apply this rule.Bad practiceprivate int Method(){ int result = 1; if( condition1) result = 0; if( condition2) ...
Refactoring Tips - Tip 11
 
Tip 11
 
Refactoring 'OR' type of conditions - In a method,if we have multiple conditional statements,with the same result. apply this rule.
 
Bad practice
 
 
private int Method()
{
  int result = 1;
  if( condition1)
    result = 0;
  if( condition2)
    result = 0;
  if( condtion3)
    result = 0;
 
 return result;
}
 

Good practice

 
 
private int OrCondition()
{
 if( condition1 || condition2 || condition3)
  return 0;
 else
  return 1;
}
private int Method()
{
 return OrCOndition();  
}
 
I hope this helps!.
 
Regards,
-Vinayak

License

This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

About the Author

Vinayaka Krishna Shenoy
Architect MindTree Ltd
India India
Motivated achiever who guides organizations in applying technology to business settings, provides added value, and creates project deliverables in a timely manner. An experienced Technical Consultant, have successfully led large project teams of more than 20 people from requirements gathering to implementation and support using C#, .NET ,ADO.NET, ADO.NET Entity Framework,ASP.NET,ASP.NET MVC, WCF and SQL Server.

Comments and Discussions

 
GeneralReason for my vote of 1 very very simple PinmemberMember 27222256-Sep-10 0:53 
Generalmultiple returns ... PinmemberStefan6311-Mar-10 6:21 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.

| Advertise | Privacy | Mobile
Web01 | 2.8.140721.1 | Last Updated 11 Mar 2010
Article Copyright 2010 by Vinayaka Krishna Shenoy
Everything else Copyright © CodeProject, 1999-2014
Terms of Service
Layout: fixed | fluid