Hall of Shame

string foobar(string xml)
{
   XmlDocument doc = new XmlDocument();
   doc.LoadXml(xml);
 
   // ... do something to doc

   // pick out some part of the doc that another function processes...
   string sXmlSelection = xml.SelectSingleNode("//xmlSelection").OuterXml;
   sXmlSelection = foo(sXmlSelection);
   string sXmlRestriction = xml.SelectSingleNode("//xmlRestriction").OuterXml;
   sXmlRestriction = foo(sXmlRestriction);
 
   ...
 
   return doc.OuterXml;
}
 
string foo(string xml)
{
   XmlDocument doc = new XmlDocument();
   doc.LoadXml(xml);
   // ... do something to doc
   // pick out some part of the doc that another function processes...
   string s = xml.SelectSingleNode(...).OuterXml;
   s = bar(s);
 
   ...
 
   return doc.OuterXml;
}
 
string bar(string xml)
{
   XmlDocument doc = new XmlDocument();
   doc.LoadXml(xml);
 
   // ... do something to doc

   return doc.OuterXml;
}
 
void main()
{
   string xmlSelection = "<data><record opt='new'>";
   xmlSelection += "<elem1>" + getElem() + </elem1>";
   xmlSelection += "<elem2>" + getElem() + </elem2>";
   xmlSelection += "<elem3>" + getElem() + </elem3>";
   xmlSelection += "<elem4>" + getElem() + </elem4>";
   xmlSelection += "</record></data>");
 
   string xmlRestriction = "<data/>";
   
   string xmlData = <data><xmlSelection>" + xmlSelection + "</xmlSelection>";
   xmlData += "<xmlRestriction>" + xmlRestriction + "</xmlRestriction></data>";
 
   foobar(xmlData);
}

dojohansen wrote:

string is the perfect data structure

supercat9 wrote:

Strings are a reasonable data structure for information storage in many contexts.

public List<Order> GetOrders(Customer c, DateTime start, DateTime end)
public List<Order> GetOrders(int customerID, DateTime start, DateTime end) 

public string GetOrders(string xmlData)

public string FormatBarContent(string foo1,
    string foo2, string f003,
    // ...
    string foo14,
    )
{
    StringBuilder sb=new StringBuilder();
    sb.Append(foo1);
    sb.Append("\n");
    sb.Append(foo2);
    sb.Append("\n");
    // ...
    sb.Append(foo14);
//    sb.Append("\n");
    return sb.ToString();
}

Private Sub aLabel_AfterLabelEdit(Cancel As Integer, NewString As String)
'+++ VB/Rig Begin Push +++
Const VBRIG_PROC_ID_STRING = "+aLabel_AfterLabelEdit"
Dim VBRigErr As Long, VBRigErrMsg As String
If VBRig.Trap_TrapsEnabled Then
    On Error GoTo aLabel_AfterLabelEdit_VBRigErr
End If
Call VBRig_Error(VBRIG_PUSH_PROC_STACK, 0, "", VBRIG_MODULE_ID_STRING, VBRIG_PROC_ID_STRING)
'+++ VB/Rig End +++
  Cancel = True
'+++ VB/Rig Begin Pop +++
Call VBRig_Error(VBRIG_POP_PROC_STACK, 0, "", VBRIG_MODULE_ID_STRING, VBRIG_PROC_ID_STRING)
Exit Sub

Wes Jones wrote:

On Error GoTo aLabel_AfterLabelEdit_VBRigErr