Oledb Exception Error

Question

0.00/5 (No votes)

See more:

hi
i am facing oledb exception error the source code is below

C#

 string query = "Insert into RealData(WantTo,PropertyType,Names,Owner,Area,
CateType,Address,Price,Desc)values('" + cmbWantTO.SelectedItem.ToString() + "',
'" + protery + "','" + txtName.Text + "','" + cmbType.SelectedItem.ToString() + "',
'" + cmbArea.SelectedItem.ToString() + "','" + cmbCategoeryType.SelectedItem.ToString() + "','" + address + "',
'" + txtPrice.Text + "','" + txtPDesc.Text + "')";
 cmd = new OleDbCommand(query, cnn);
int xy = cmd.ExecuteNonQuery();

this code is giving exception insert into statement syntax error plz help me.

Posted 12-Jan-13 20:38pm

Dharmendra-18

Add a Solution

Comments

David_Wimbley 13-Jan-13 3:00am

What specifically is the error in your sql? Im going to submit a solution but for all i know every last column in your insert is not in your table

2 solutions

Solution 2

For the love of your sanity and your coworkers who have to look at this, your killing maintainability by doing inline sql...at the bare minimum do string.format

I re-arranged your sql using string.format. Give it a shot i dont see why this wouldnt work unless your column names in the sql are not match what is in your table. In which case you didnt specify that in your question so who knows what the problem is at that point...it could be the aliens took your table.

C#

string query = string.Format(@"INSERT INTO RealData (WantTo,PropertyType,Names,Owner,Area,CateType,Address,Price,Desc) VALUES ('{0}','{1}','{2}','{3}','{4}','{5}','{6}','{7}','{8}')", cmbWantTO.SelectedItem.ToString(),
                                                                                                                                                                                         protery,
                                                                                                                                                                                         txtName.Text,
                                                                                                                                                                                         cmbType.SelectedItem.ToString(),
                                                                                                                                                                                         cmbArea.SelectedItem.ToString(),
                                                                                                                                                                                         cmbCategoeryType.SelectedItem.ToString(),
                                                                                                                                                                                         address,
                                                                                                                                                                                         txtPrice.Text,
                                                                                                                                                                                         txtPDesc.Text);

Posted 12-Jan-13 21:01pm

David_Wimbley

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sandeep Mewara · Accepted Answer · 2013-01-12T20:50:00

You have not given spaces appropriately to make correct query.
Issues:

RealData(WantTo,
Desc)values('

Try:

C#

string query = "INSERT INTO RealData (WantTo, PropertyType, Names, Owner, Area, CateType, Address, Price, Desc) VALUES ('" + cmbWantTO.SelectedItem.ToString() + "',
'" + protery + "','" + txtName.Text + "','" + cmbType.SelectedItem.ToString() + "',
'" + cmbArea.SelectedItem.ToString() + "','" + cmbCategoeryType.SelectedItem.ToString() + "','" + address + "',
'" + txtPrice.Text + "','" + txtPDesc.Text + "')";
 cmd = new OleDbCommand(query, cnn);
int xy = cmd.ExecuteNonQuery();

BTW, your implementation is open for SQL Injection, Not suggestible at all. You should use parametrized query.
Read about protecting from SQL Injection here: SQL Injection Mitigation: Using Parameterized Queries[^]