Parameterize my queries

Question

0.00/5 (No votes)

See more:

I was advised to Parameterize all my queries. I am having trouble changing my queries. when I click save nothing happens. I refeshed my database and it is inserting metroName1 into Name in the database not what I am typing into the metroName1 textbox

C#

UniConnection connection = new UniConnection("Provider=MySQL;host=127.0.0.1;user=###;password=###;database=dscomputers");
            try
            {
                UniCommand cmd = connection.CreateCommand();
                cmd.CommandText = "INSERT INTO customer (Name, Mobile, Landline, Othernumber, Address) VALUES (@Name, @Mobile, @Landline, @Othernumber, @Address)";
                UniParameter parameter = cmd.Parameters.Add("@Name", UniDbType.VarChar);
                parameter.Value = "metroName1";
                
                cmd.Parameters.Add(parameter);
                parameter = cmd.Parameters.Add("@Mobile, UniDbType.VarChar);
                parameter.Value = "metroMobile2";
                cmd.Parameters.Add(parameter);
                parameter = cmd.Parameters.Add("@Landline", UniDbType.VarChar);
                parameter.Value = "metroLand3";
                cmd.Parameters.Add(parameter);
                parameter = cmd.Parameters.Add("@Othernumber", UniDbType.VarChar);
                parameter.Value = "metroOther5";
                cmd.Parameters.Add(parameter);
                parameter = cmd.Parameters.Add("@Address", UniDbType.VarChar);
                parameter.Value = "metroOther4";
                cmd.Parameters.Add(parameter);
                connection.Open();
                cmd.ExecuteNonQuery();
            }
            finally
            {
                connection.Close();
            }

        }
    }
}

What I have tried:

I've tried different options but cant seem to get it at all. I know I have something wrong but never used Parameterized queries before

Posted 5-Oct-16 10:47am

Member 10627757

Updated 5-Oct-16 20:21pm

Wendelius

v3

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Member 10627757 · Answer 1 · 2016-10-05T11:15:00

Solution 1

Got it working by using

parameter.Value = metroMobile2.Text;

Posted 5-Oct-16 11:15am

Member 10627757

Midi_Mick · Answer 2 · 2016-10-05T17:29:00

You are adding each parameter to the collection twice. Your code is using a pattern:

C#

parameter = cmd.Parameters.Add(name, type);
parameter.Value = value;
cmd.Parameters.Add(parameter);

either remove the last Add(parameter) statement, or use a pattern like:

C#

parameter = cmd.CreateParameter(name, type);
parameter.Value = value;
cmd.Parameters.Add(parameter);

or even change the cmd.CreateParameter to simply new SQLParameter (or whichever Db prefix you're using)

Wendelius · Answer 3 · 2016-10-05T20:21:00

As pointed out, you add the parameters twice to the parameter collection. This causes some confusion. Also you provide static values for the parameters instead of getting them from UI objects. Is that really the point since all the rows get the same values. Instead for example for all text boxes use the Text property[^] or if Windows Forms then Text[^]

Also you should properly dispose the connection and the command for releasing the resources. You might find reading the following useful: Properly executing database operations[^]

Oh, and one more thing. Never post username or password to public forums. I edited them away.

Parameterize my queries

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0