Formatexception: string was not recognized as a valid boolean.

Question

1.00/5 (1 vote)

See more:

C#

string offerID = Request.QueryString["selectedoffers"];
                DataTable dtOffer = OfferDB.GetDisplayOffer(offerID);

C#

if (dtOffer.Rows.Count > 0)
                {
                    DataRow dr = dtOffer.Rows[0];
                    if (Convert.ToBoolean(dr["TrustedForm"]))
                    {

What I have tried:

Hi,

The column TrustedForm is varchar type stores 0 and 1. And I'am getting above error in 'if' block. I checked through google converting 0 and 1 throws format exception. So I need you guys to share what can be put in 'if' block to go control inside?

Posted 23-Nov-16 3:11am

Amith 12807185

Updated 23-Nov-16 3:32am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Kornfeld Eliyahu Peter · Accepted Answer · 2016-11-23T03:18:00

Solution 1

When converting from string the only literals recognized by ToBoolean are 'true' and 'false' (and null that yields false) - case insensitive...
'0' and '1' are not recognized...
If you are sure that 0 and 1 are the only values you have two options:
1. Change the database type to bit
2. Convert the value first to integer and then to boolean

Posted 23-Nov-16 3:18am

Kornfeld Eliyahu Peter

Updated 23-Nov-16 19:40pm

v2

Comments

Amith 12807185 28-Nov-16 0:08am

Hi, thanks for the deep insight on this error. Actually I tried to change database type to bit but there is dependencies on more store procs. But this answer also works.

F-ES Sitecore · Accepted Answer · 2016-11-23T03:32:00

Solution 2

Change

C#

if (Convert.ToBoolean(dr["TrustedForm"]))

to

C#

if ((string)dr["TrustedForm"] == "1")

However you should use the appropriate field types in your database so if this is intended as a true\false field then change it to "bit".

Posted 23-Nov-16 3:32am

F-ES Sitecore

Comments

Karthik_Mahalingam 24-Nov-16 0:49am

5

Amith 12807185 28-Nov-16 0:04am

Hi, it worked. I checked the code once more and confirmed database column values are '0','1' and null due to not null constraint.And in code I only want to check if value is '1'. So converting to string does the job for me.