Click here to Skip to main content
13,798,492 members
Rate this:
 
Please Sign up or sign in to vote.
See more:
class Program
    {
        static int Sred(int k)
        {
            Random rand = new Random();
            int n;
            int sum =0, avrg = 0, count = 0;
            for (int i = 0; i < k; k++)
            {
                n = rand.Next(-200, 200);
                if (n >= 10 && n <= 100)
                    sum += n;
                    count++;
            }
             avrg = sum / count;
             return avrg;
        }
        public static void Main(string[] args)
        {
            Console.Write("a= ");
            int a = int.Parse(Console.ReadLine());
            Console.Write("b= ");
            int b = int.Parse(Console.ReadLine());
            Console.Write("c= ");
            int c = int.Parse(Console.ReadLine());
            Sred(a+b+c);
        }
    }
}


What I have tried:

I've tried to use static void instead of static int.
Posted 5-Nov-17 3:20am
Updated 5-Nov-17 4:31am
v2
Comments
Mehdi Gholam 5-Nov-17 8:31am
   
Doesn't work is not helpful when we don't know and you haven't explained what it is supposed to do.
Dave Kreskowiak 5-Nov-17 8:41am
   
You're going to have to describe what you mean by "doesn't work". What does happen? What is expected to happen? What are the differences?

I can see somethings that may be wrong, but it depends on what the code is supposed to do.
Rate this: bad
 
good
Please Sign up or sign in to vote.

Solution 1

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
private int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using teh debugger to find out why. Put a breakpoint on your line:
Random rand = new Random();

and run your app. Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?

This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

Yes, I could probably tell you what "the problem" is - but it's not difficult to do this yourself, and you will learn something really worthwhile at the same time!
  Permalink  
Comments
Member 13504137 5-Nov-17 9:02am
   
I'm glad to see so detailed answer. I found where the problem was and now it works ^^. Thank you for the tips. I'll take them in mind for advance.
OriginalGriff 5-Nov-17 10:05am
   
You're welcome!
Rate this: bad
 
good
Please Sign up or sign in to vote.

Solution 2

Zoom into this line of code:
for (int i = 0; i < k; k++)
Have you noticed something amiss?
  Permalink  
Comments
CPallini 5-Nov-17 8:53am
   
5.
Peter Leow 5-Nov-17 10:22am
   
Thank you, CPallini.
Member 13504137 5-Nov-17 9:05am
   
Thank you too man, probably I've missed it bcuz I'm little bit tired after all day of writng codes. :)
Karthik Bangalore 5-Nov-17 9:10am
   
5 Good catch
Peter Leow 5-Nov-17 10:23am
   
Thank you, Karthik.
Rate this: bad
 
good
Please Sign up or sign in to vote.

Solution 3

Quote:
Why does my program(method) doesn't work?

When you know something go wrong, but you don't know what, the answer is debugger, it is a tool made to help you find problems by showing you what is going on.

There is a tool that allow you to see what your code is doing, its name is debugger. It is also a great learning tool because it show you reality and you can see which expectation match reality.
When you don't understand what your code is doing or why it does what it does, the answer is debugger.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]
Debugging C# Code in Visual Studio - YouTube[^]
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.
  Permalink  
v2

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

  Print Answers RSS
Top Experts
Last 24hrsThis month


Advertise | Privacy | Cookies | Terms of Service
Web03 | 2.8.181207.3 | Last Updated 5 Nov 2017
Copyright © CodeProject, 1999-2018
All Rights Reserved.
Layout: fixed | fluid

CodeProject, 503-250 Ferrand Drive Toronto Ontario, M3C 3G8 Canada +1 416-849-8900 x 100