Give me the error system.data.sqlclient.sqlexception: 'incorrect syntax near '01/12/2017'.' I search for a date and give me the error

Question

0.00/5 (No votes)

See more:

private void btn_search_Click(object sender, EventArgs e)
{
conn.Open();

SqlDataAdapter SDA = new SqlDataAdapter("select dbo.Alteracoes.Data, dbo.Funcionarios.numero as no, dbo.Funcionarios.nome, dbo.Alteracoes.Falta as faltas, dbo.Alteracoes.Coluna2 as horasextras from dbo.Alteracoes inner join dbo.Funcionarios on dbo.Alteracoes.IDFuncionario = dbo.Funcionarios.IDFuncionario inner join dbo.Departamentos on dbo.Funcionarios.IDDepartamento = dbo.Departamentos.IDDepartamento WHERE dbo.Alteracoes.Data '" +dateTimePicker1.Value.ToString("dd/MM/yyyy") + "'", conn);

DataSet dt = new DataSet();
SDA.Fill(dt, "dbo.Alteracoes.Data");
dataGridView1.DataSource = dt.Tables["dbo.Alteracoes.Data"];
conn.Close();
}

What I have tried:

private void btn_search_Click(object sender, EventArgs e)
        {
            conn.Open();

            SqlDataAdapter SDA = new SqlDataAdapter("select dbo.Alteracoes.Data, dbo.Funcionarios.numero as no, dbo.Funcionarios.nome, dbo.Alteracoes.Falta as faltas, dbo.Alteracoes.Coluna2 as horasextras from dbo.Alteracoes inner join dbo.Funcionarios on dbo.Alteracoes.IDFuncionario = dbo.Funcionarios.IDFuncionario inner join dbo.Departamentos on dbo.Funcionarios.IDDepartamento = dbo.Departamentos.IDDepartamento WHERE dbo.Alteracoes.Data '" +dateTimePicker1.Value.ToString("dd/MM/yyyy") + "'", conn);

            DataSet dt = new DataSet();
            SDA.Fill(dt, "dbo.Alteracoes.Data");
            dataGridView1.DataSource = dt.Tables["dbo.Alteracoes.Data"];
            conn.Close();
        }

Posted 3-Jan-18 0:12am

Member 13604810

Updated 3-Jan-18 1:05am

Karthik_Mahalingam

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2018-01-03T00:19:00

Simple: don't do it like that.
Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'

The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'

Which SQL sees as three separate commands:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';

A perfectly valid SELECT

SQL

DROP TABLE MyTable;

A perfectly valid "delete the table" command

SQL

--'

And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

The query you show isn't vulnerable to SQL Injection, but the rest of your code probably is, and the concatenation is not helping the problem here - fix your whole code, add an equals sign to your WHERE clause, and the problem will go away at the same time.

Pradeep Arthanari · Answer 2 · 2018-01-03T00:59:00

Seems like you have missed the equal(=) in where clause:

Concatenating the sql Query string is vulnerable to SQL Injection[^] attacks
always use Parameterized queries to prevent SQL Injection Attacks in SQL Server[^]

string query = "select dbo.Alteracoes.Data, dbo.Funcionarios.numero as no, dbo.Funcionarios.nome, dbo.Alteracoes.Falta as faltas, dbo.Alteracoes.Coluna2 as horasextras from dbo.Alteracoes inner join dbo.Funcionarios on dbo.Alteracoes.IDFuncionario = dbo.Funcionarios.IDFuncionario inner join dbo.Departamentos on dbo.Funcionarios.IDDepartamento = dbo.Departamentos.IDDepartamento WHERE dbo.Alteracoes.Data = @date";
                SqlCommand cmd = new SqlCommand(query, conn);
                cmd.CommandType= CommandType.Text;
                cmd.Parameters.Add("@date", dateTimePicker1.Value.ToString("dd/MM/yyyy"));
                SqlDataAdapter SDA = new SqlDataAdapter(query, conn);

Give me the error system.data.sqlclient.sqlexception: 'incorrect syntax near '01/12/2017'.' I search for a date and give me the error

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0