VBScript performance issue

Question

1.00/5 (1 vote)

See more:

Hi,

I've inherited a VBScript that runs every 1 minute and causes 100% CPU usage. I can't modify the code as it's a production server and there is no testing environment. So I'd like to have your opinion before I propose the change.

Basically the script loops through all files in the source folder (around 7000 files)checking file names and if it starts with "D__" it will copy the file to destination folder. I notice the script runs: mid(ucase()) which is better, I think, as ucase(mid)) or even left()="D__" or left()="d__" to avoid string manipulation.

It also checks if the file exists in the destination which is no use since the overwrite flag is set to false in copyfile().

If I make these changes, will there be any performance? and if I write a small app in C# for example, will it run faster or it isn't VBScript limitation?

Thanks

Posted 17-May-11 6:32am

m.selim

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

#realJSOP · Answer 1 · 2011-05-17T06:36:00

Solution 1

0) We don't know because we aren't familiar with your hardware configuiration or abilities as a coder.

1) Try it and see.

By the way, if it's on a production server, I doubt if they'll let you deploy an unproven application ton it to handle what appears to be a critical task.

Posted 17-May-11 6:36am

#realJSOP

v2

Comments

Sergey Alexandrovich Kryukov 17-May-11 19:40pm

OP commented:

Hi John,

Actually I'm worried if I raise a change and get the required approvals, the performance hit will be the same or even worse. This is why I asked here if these minor modifications would make any difference. This issue has to disappear some way or another as the server admins make much noise about the CPU usage.

Sergey Alexandrovich Kryukov 17-May-11 19:41pm

This is correct, but I would insist of getting rid of such dirt.
Please see my answer.
--SA

Sergey Alexandrovich Kryukov · Answer 2 · 2011-05-17T13:40:00

Solution 3

It sounds like a most dirty solution. Get rid of it until it's not too late. Look at what script is doing and decide what to do. Whole thing does not look reasonable. Any periodic task not driven by real events should not be used.

—SA

Posted 17-May-11 13:40pm

Sergey Alexandrovich Kryukov

Comments

fjdiewornncalwe 19-May-11 10:56am

Excellent Advice.

Sergey Alexandrovich Kryukov 20-May-11 15:26pm

Thank you very much, Marcus.
--SA

JustWorking · Answer 3 · 2011-05-17T21:00:00

Solution 4

By searching google or any search engine site.

Posted 17-May-11 21:00pm

JustWorking