problem with the vector in the c++ under the windows platform

Question

0.00/5 (No votes)

See more:

sir i create the coding for accessing the element of the structure

coding:

#include "stdafx.h"
#include <vector>
#include <string>
using namespace std;
struct myStruct
{
	int iTemp1;
	int iTemp2;
};
int main(int argc, char* argv[])
{
	int iTemp = 0;
	int iLoop = 0;
	int iMark;
	vector <mystruct> *myvec;
	vector <mystruct>::iterator *it;
	cout<<"How many times wants to insert \n";
	cin>>iTemp;
	for(;iLoop<itemp;iloop++)>
	{
		myvec = new vector<mystruct>
		myStruct *mystr=new myStruct();
		cout<<"Enter the data for m1 \n";
		cin>>iMark;
		mystr->iTemp1 = iMark;
		iMark = 0;
		cout<<"Enter the data for m1 \n";
		cin>>iMark;
		mystr->iTemp2 = iMark;
		myvec->push_back(*mystr);
	}


	return 0;
}

This coding working without no error..

if i try to print the value the last entered element only coming..

please help me.

Reformatted with proper tags.
-E-

Posted 21-Jul-11 20:24pm

Dhanasundhari

Updated 21-Jul-11 22:16pm

Emilio Garavaglia

v4

Add a Solution

Comments

వేంకటనారాయణ(venkatmakam) 22-Jul-11 2:48am

code is missing i think.repost the full code.

Dhanasundhari 22-Jul-11 3:14am

now i repost my code sir

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Stefan_Lang · Accepted Answer · 2011-07-21T23:34:00

Apart from what PrafullaVedante said, you are also needlessly creating a struct on the heap, and then forgot to delete it. Just create it on the stack like this:

myvec = new vector<mystruct>; // <-- see Solution 1
    for(;iLoop<itemp;iloop++)>
{
    myStruct mystr; // <-- do not create this with new!
    cout<<"Enter the data for m1 \n";
    cin>>iMark;
    mystr.iTemp1 = iMark; // <-- changed '->' to '.'
    iMark = 0;
    cout<<"Enter the data for m1 \n";
    cin>>iMark;
    mystr.iTemp2 = iMark; // <-- changed '->' to '.'
    myvec->push_back(mystr); // <-- removed '*'
}

Note that std::vector::push_back() will create a copy of the passed value anyway, so there is no need to create new instances of myStruct yourself.

PrafullaVedante · Accepted Answer · 2011-07-21T21:26:00

Solution 1

Brought following statement out of the for loop

myvec = new vector;

You are creating a new vector for each interation.

Your code should look like

myvec = new vector;

for(;iLoop<itemp;iloop++)>
{

myStruct *mystr=new myStruct();
cout<<"Enter the data for m1 \n";
cin>>iMark;
mystr->iTemp1 = iMark;
iMark = 0;
cout<<"Enter the data for m1 \n";
cin>>iMark;
mystr->iTemp2 = iMark;
myvec->push_back(*mystr);
}

Posted 21-Jul-11 21:26pm

PrafullaVedante

Updated 21-Jul-11 21:28pm

v2

Comments

Dhanasundhari 22-Jul-11 5:28am

i got it.. thanks

Stefan_Lang 22-Jul-11 5:34am

Good catch. my 5

PrafullaVedante 22-Jul-11 7:06am

Thanks Stefan :)

John R. Shaw 23-Jul-11 12:25pm

Sorry 3 - it was a 4 for unneeded 'new' in the loop, but dropped to 3 because it will leak - no 'delete'.