Incorrect syntax near ','.

Question

0.00/5 (No votes)

See more:

C#

SqlConnection con = new SqlConnection("Server=(local);initial catalog=ServiceTax;Trusted_Connection=True");


private void button1_Click(object sender, EventArgs e)
{
      con.Open();
      SqlCommand cmd = new SqlCommand("insert into RSBIlls Values(" + cb_sno.Text + ",'" + cb_billno.Text + "','" + dateTimePicker1.Text + "','" + cb_name.Text + "','" + txt_Area.Text + "','" + txt_street.Text + "','" + txt_location.Text + "'," + textBox1.Text + "," + txt_dieselservice.Text + "," + txt_subtotal.Text + "," + txt_servicetax.Text + "," + txt_educess.Text + "," + txt_addcess.Text + "," + txt_grandtot.Text + ")", con);
 cmd.ExecuteNonQuery();
      con.Close();
}

When i run and click the insert button error shows as Incorrect syntax near ','.

Posted 5-Nov-12 23:10pm

Member 8054539

Updated 5-Nov-12 23:15pm

Ankur^\m/

v2

Add a Solution

Comments

Nandakishore G N 6-Nov-12 8:41am

one suggestion is dont use inline insert...better use stored procedure...there u can find problem easily..

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Pablo Aliskevicius · Answer 1 · 2012-11-05T23:19:00

My suggestion:

C#

// ...
String s = "insert into RSBIlls Values(" + cb_sno.Text + ",'" + cb_billno.Text + "','" + dateTimePicker1.Text + "','" + cb_name.Text + "','" + txt_Area.Text + "','" + txt_street.Text + "','" + txt_location.Text + "'," + textBox1.Text + "," + txt_dieselservice.Text + "," + txt_subtotal.Text + "," + txt_servicetax.Text + "," + txt_educess.Text + "," + txt_addcess.Text + "," + txt_grandtot.Text + ")";
Debug.WriteLine(s); // this is the line that will help you.
SqlCommand cmd = new SqlCommand(s, con);
// ...

Take the contents of the debug screen, run in Management Studio, and see the errors there.
My guess: either txtLocation.Text is something like 'Manchester, England' or one of the others is empty.
Also, don't forget to add single quotes around literal strings ('this is a string', this_is_a_database_object_name).
Tell me if the spirits were right...
:)
Hope this helps,
Pablo.

Mr. Mahesh Patel · Answer 2 · 2012-11-06T00:27:00

hi dear
try below query

SQL

SqlCommand cmd = new SqlCommand("insert into RSBIlls
([ListYourFieldNameHere]) 
Values('" + cb_sno.Text + "'
,'" + cb_billno.Text + "'
,'" + dateTimePicker1.Text + "'
,'" + cb_name.Text + "'
,'" + txt_Area.Text + "'
,'" + txt_street.Text + "'
,'" + txt_location.Text + "'
,'" + textBox1.Text + "'
,'" + txt_dieselservice.Text + "'
,'" + txt_subtotal.Text + "'
,'" + txt_servicetax.Text + "'
,'" + txt_educess.Text + "'
,'" + txt_addcess.Text + "'
,'" + txt_grandtot.Text + "')", con);

pryashrma · Answer 3 · 2012-11-05T23:15:00

Try this

C#

private void button1_Click(object sender, EventArgs e)
{
string strSqlQuery="insert into RSBIlls Values(" + cb_sno.Text + ",'" + cb_billno.Text + "','" + dateTimePicker1.Text + "','" + cb_name.Text + "','" + txt_Area.Text + "','" + txt_street.Text + "','" + txt_location.Text + "'," + textBox1.Text + "," + txt_dieselservice.Text + "," + txt_subtotal.Text + "," + txt_servicetax.Text + "," + txt_educess.Text + "," + txt_addcess.Text + "," + txt_grandtot.Text + ")";
Response.Write("Your Query:"+ strQuery);
//con.Open();
//SqlCommand cmd = new SqlCommand(", con);
//cmd.ExecuteNonQuery();
//con.Close();
}

Through you can view your SqlQuery than check the error.
Hope this helps.

Ankur^\m/ · Answer 4 · 2012-11-05T23:17:00

Solution 2

Get the query part and run it in a query analyzer against your database. You will get the issue.
Most probably some of your parameter is not correct and causing a syntactical error.

Posted 5-Nov-12 23:17pm

Ankur^\m/

Incorrect syntax near ','.

4 solutions

Solution 3

Solution 4

Solution 1

Solution 2

Add your solution here

Preview 0