Problem with File Handling in C++

Question

2.00/5 (1 vote)

See more:

I am working on a project. I want to find how can find the total number of characters in file? (student.txt supposed).

I implemented the logic below:

C++

while(!student.eof())
	{
		student.get(keystroke);
			iFile_size++;
	}
char* File_storage[iFile_size+1];               //dynamic array declaration
while(!myfile.eof())
    {
        myfile.get(keystroke);
            File_storage[file_count]=keystroke;
            file_count++;
    }

It should store all the data from the file to char* pointer. But the size is not correct. after fetching all data(character by character) the pointer still have garbage values at the end e.g

after compiling, char* File_storage has value $Saad$14$Novemeber$!****** (* shows garbage value.
I want to finish till '!' character.

Posted 26-Nov-12 10:07am

saad_lah

Updated 26-Nov-12 10:10am

André Kraak

v2

Add a Solution

Comments

Snk Tay 26-Nov-12 16:13pm

Do you want to count white characters(white characters are SPACE, TAB, \n, ...)??

saad_lah 26-Nov-12 16:15pm

i want to count all characters like (alphabets, numbers and '$', '!')

Sergey Alexandrovich Kryukov 26-Nov-12 16:33pm

Where is the definition of keystroke. It it was of a one-byte type, you could do it...
--SA

saad_lah 26-Nov-12 16:42pm

char keystroke;

2 solutions

Solution 2

;)

C++

#include <stdio.h>
#include <ctype.h>
//......

char c;
long long int counter;

//........

while(!myfile.eof())
    {
        myfile >> c;
        if(!isspace(c))
        {
            counter++;
        }

    }

</ctype.h></stdio.h>

I tested it!! it works

Posted 26-Nov-12 10:47am

Snk Tay

Comments

saad_lah 26-Nov-12 17:04pm

This will definitely run,
What i want was something different than this. I am editing data in file "student.txt" which so that i have to copy all data in a char* pointer and then edit the data in pointer and then by ofstream myfile(*****) again puts edited data in file again, the problem i was facing was , how can i find the size of dynamic char* array so that i can put it in char* file_storage; file_storage=new char[count+1];
by (!myfile.eof()) its was not working correctly, but by myfile.good() its accurately giving the length of all characters in file.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2012-11-26T10:26:00

Solution 1

Here[^] you find a complete example of doing that in the correct way.

Posted 26-Nov-12 10:26am

CPallini

Comments

saad_lah 26-Nov-12 16:31pm

Thnx so much, i tested your given code and problem solved

CPallini 26-Nov-12 16:46pm

You are welcome.