Converting a number to binary

Question

1.50/5 (2 votes)

See more:

This is very annoying, a long time ago I needed to convert an integer to a binary value for uploading to a device. Worked it out good and gone. The sad thing is I now need to convert an integer to a binary value for something else. I really need to get this going

C#

String s = "05";
  int b = 0;

   StringBuilder binary = new StringBuilder();
   for (int j = 0; j <= binary.Length; j++ )
   {
       int val = b;
       for (int i = 0; i < 8; i++)
       {
           binary.Append((val & 128) == 0 ? 0 : 1);
           val <<= 1;
       }
       binary.Append(' ');
   }
 MessageBox.Show("'" + s + "' to binary: " + binary);

from that I want 5 to end up as 101, to get it to 00000101 I can append the zeros to the string.
If I run the code it locks up

Quote:
Serial_Number.Form1.button3_Click
(object sender = {Text = Cannot evaluate expression because the code of the current method is optimized.},
System.EventArgs e = {X = 46 Y = 6 Button = Left}) Line 77 + 0x40 bytes C#

and the debugger returns what am I doing wrong, I am starting to think I need a much deeper route through my system for the code.
Glenn

Posted 14-Jan-13 5:02am

glennPattonWork3

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Alan N · Answer 1 · 2013-01-14T05:50:00

I'm not sure what you intended the outer loop should do, but it appears to be infinite.

I've commented the code to explain why:

C#

StringBuilder binary = new StringBuilder();
// Initial length of the StringBuilder is 0
// The loop will be entered as the condition is less than or equal to 0
for (int j = 0; j <= binary.Length; j++ )
  {
     int val = b;
     for (int i = 0; i < 8; i++)
       {
          binary.Append((val & 128) == 0 ? 0 : 1);
          val <<= 1;
       }
       binary.Append(' ');
       // StringBuilder Length has been increased by 9 characters
       // so the loop continuation condition is still true
  }

I've always used System.Convert.ToString(Int32 value, Int32 base) to get 'binary' strings. It's very straightforward:

C#

// Assuming input is 8 bit
String s = Convert.ToString(5, 2);
// s = "101";
String result = s.PadLeft(8, '0');
// result = "00000101"

Sergey Alexandrovich Kryukov · Answer 2 · 2013-01-14T08:43:00

Please stop it. A number is already binary, unless it's really a number, not a string representation of a number.
This is the very basic understanding, you need to learn basics first.

Yes, I understand what did you want, some string data as "001010101…". This is a string! Don't mix is with binary, which is… everything, in fact.

—SA

Andreas Gieriet · Answer 3 · 2013-01-14T13:55:00

How about (.NET 3.5, using System.Linq;):

C#

static string Bits(int v)
{
    return BitConverter
             .GetBytes(v)
             .Reverse()
             .Aggregate("", (s, b) => s + Convert.ToString(b, 2).PadLeft(8, '0'));
}
static string Bits(float v)
{
    return BitConverter
             .GetBytes(v)
             .Reverse()
             .Aggregate("", (s, b) => s + Convert.ToString(b, 2).PadLeft(8, '0'));
}
etc.

You may play with the Reverse() to get the byte order you want.
Cheers
Andi

Converting a number to binary

3 solutions

Solution 3

Solution 4

Solution 5

Add your solution here

Preview 0