error in transaction in ado.net

Question

0.00/5 (No votes)

See more:

getting an error in transaction ...i have created table Tbl_Invoice (Invoice_Id ,Product_Name,Amount,Product_Quantity,Product_Price) and table Tbl_Product(Product_Id,Product_Name,Product_Quantity,Product_Amount)

now i have one button through which i need to add the data of textboxes(Product Name,Amount,Product Quantity,Product Price) which is filled by user runtime into the grid and i made filled 3 rows of grid and when i click on save button

C#

protected void save_Click(object sender, EventArgs e)
    { SqlConnection con = new SqlConnection(System.Configuration.ConfigurationManager.ConnectionStrings["test"].ConnectionString);

            con.Open();
            SqlTransaction Trans = con.BeginTransaction();

            SqlCommand com = new SqlCommand();
            com.Connection = con;
            com.Transaction = Trans;

        foreach (GridViewRow g1 in grd.Rows)
        {


           
            try
            {
                if (Convert.ToInt32(g1.Cells[4].Text) > 10)
                {//created exception on qty>10 if filled by user so that it should roll back the whole transaction
                    throw (new Exception("not greater than 10"));
                }
                com.CommandText = "insert into Tbl_Invoice(Product_Name,Amount,Product_Quantity,Product_Price) values ('" + g1.Cells[2].Text + "'," + Convert.ToDouble(g1.Cells[3].Text) + "," + Convert.ToInt32(g1.Cells[4].Text) + "," + Convert.ToDouble(g1.Cells[5].Text) + ")";
                com.CommandText = "update Tbl_Product  set Product_Quantity=Product_Quantity+" + Convert.ToInt32(g1.Cells[4].Text) + ", Product_Amount=Product_Amount+" + Convert.ToDouble(g1.Cells[3].Text) + " where Product_Name='" + g1.Cells[2].Text + "'";
                
                com.ExecuteNonQuery();
               
                Response.Write("both are written to tables");
            }
            catch (Exception ep)
            {
                Trans.Rollback();
                Response.Write(ep.ToString());
                Response.Write("neither are written to tables");
            }
            finally
            {
                Trans.Commit();
                con.Close();
            }   }    }

runtime 3 rows were added in grid repective (Product Name,Amount,Product Quantity,Product Price)

first row Shirt,125,1,125
second row tie,50,2,25
third row pant,1500,12,50

these are dummy values i put here which is in grid
now as per exception i created qty>10 should roll back whole transaction but it only roll back last row not the whole transaction as per acid properties either should execute all queries or no query .It has affected Tbl_Invoice and Tbl_Product
with first 2 rows which is not desired ..what i missed or written wrong
pls tell,regards

Posted 7-Feb-13 22:33pm

shivani 2013

Updated 8-Feb-13 0:02am

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

**Orcun Iyigun** · Answer 1 · 2013-02-07T23:01:00

Solution 1

You can set a savepoint during the transaction and if it fails you can rollback to that save point. FOr more info you should look into SAVE TRANSACTION[^]

Good luck,
OI

Posted 7-Feb-13 23:01pm

Orcun Iyigun

Comments

shivani 2013 8-Feb-13 5:24am

it is not serving my purpose........can you tell what mistake i did in this??????????

Orcun Iyigun 8-Feb-13 5:44am

How come it is not serving the purpose? Have you read the documentation?? Once you set your savepoint you are basically done but seems like you did not understand it. In your code it just rollbacks the last query because the first two are successfully committed and the transactions for them are re-instantiated. Try defining your Transaction before the loop and commit in your finally statement..

shivani 2013 8-Feb-13 6:06am

I defined Transaction before the loop and commit in finally statement..i updated my question but again it is doing same and with error
"This SqlTransaction has completed; it is no longer usable.".

pls tell wat to modify here
regards

Costica U · Answer 2 · 2013-02-08T02:07:00

Only the update statement is executed.
You need

C#

com.CommandText = "insert into..." com.ExecuteNonQuery(); com.CommandText = "update..." com.ExecuteNonQuery();

Also, you have Trans.Commit() in finally block, which may be called after Trans.Rollback().

I havent noticed there is a loop. Try something like this..

C#

try
{

  foreach...
  {
  ...
  com.CommandText = "insert into..."
  com.ExecuteNonQuery();
  com.CommandText = "update..."
  com.ExecuteNonQuery();
  }

  Trans.Commit()
}
catch ...
{
  Trans.Rolback()
}