i can see what i am doing wrong with my coding, can someone help me out?

Question

1.00/5 (1 vote)

See more:

C++

void flip ( int i )

{
  assert( i==1 && i==0);
  if(i = 1)
    i=0;
  else
    i=0;
}

int main()
{
  int i = 1;
  assert(i==1);
  flip(i);
  assert(i==0);
  flip(i);
  assert(i==1);
  cout << "Success!\n";
  return 0;
}

[HB: add pre tags]

Posted 12-Feb-13 18:21pm

Member 9643632

Updated 12-Feb-13 18:44pm

H.Brydon

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

H.Brydon · Answer 1 · 2013-02-12T18:48:00

Solution 1

The assertion in flip() will always fail because you are trying to assert that i is equal to both 0 and 1. You also change the value of i (locally) to zero regardless of input value.

The call to flip() does not change the value of i in main(). You need to make flip refer to the variable i instead of a copy of its value: ie. "void flip(int* i)".

Posted 12-Feb-13 18:48pm

H.Brydon

Comments

Albert Holguin 13-Feb-13 18:16pm

Good input... but there are oh so many errors in that code. :)

Rahul Rajat Singh · Answer 2 · 2013-02-12T18:50:00

Solution 2

Couple of things, i think are wrong

C++

assert( i==1 && i==0); // Why &&. I think this should be ||
  if(i = 1)
    i=0;
  else
    i=0;   // Here you will have to set i = 1 (assuming this is what flip function is supposed to do

EDIT: the "=" in your if conditions should be changed to "=="

Posted 12-Feb-13 18:50pm

Rahul Rajat Singh

Updated 13-Feb-13 17:16pm

v2

Comments

Albert Holguin 13-Feb-13 18:13pm

You missed the if(i=1) error, that's setting the value to 1 all the time.

Rahul Rajat Singh 13-Feb-13 23:15pm

OOPs, My bad. I will correct the mistake. Apparently I am spending too much time with sql nowadays and this "=" started seeming ok with if :)

Mas11 13-Feb-13 23:39pm

Nice Answer ! My 5*