email sending error with cc and bcc

Question

3.00/5 (1 vote)

See more:

Here my code.when i enter email address in from,to,cc and bcc field my web app send the email.but when i only enter email address in from,to and make cc and bcc field empty it give me error

Exception Details: System.ArgumentException: The parameter 'address' cannot be an empty string.
Parameter name: address

Source Error:

Line 89:             foreach (string emailCC in txtCc.Text.ToString().Split(splitter))
Line 90:             {
Line 91:                 mail.CC.Add(new MailAddress(emailCC));
Line 92:             }
Line 93:

here my code please help me a google alot but i can not find the

C#

private void SendEmail()
    {
        MailMessage mail = new MailMessage();

        if (txtTo.Text != null)
        {
            char[] splitterrr = { ';' };
            foreach (string emailTo in txtTo.Text.ToString().Split(splitterrr))
            {
                mail.To.Add(new MailAddress(emailTo));
            }
        }
        //mail.To.Add(EmailAddress);
        mail.From = new MailAddress(txtFrom.Text.ToString());
        mail.Subject = txtSubject.Text;
        mail.Body = edtrMessage.Content.ToString();
        if (txtCc.Text != null)
        {

            char[] splitter = { ';' };
            foreach (string emailCC in txtCc.Text.ToString().Split(splitter))
            {
                mail.CC.Add(new MailAddress(emailCC));
            }

        }
        else if (null == txtCc.Text || txtCc.Text.Length == 0 || txtCc.Text == String.Empty)
        {
            mail.CC.Add(new MailAddress(txtCc.Text.ToString()));
        }
        if (txtBcc.Text != null)
        {

            char[] splitterr = { ';' };
            foreach (string emailBB in txtBcc.Text.ToString().Split(splitterr))
            {
                mail.Bcc.Add(new MailAddress(emailBB));
            }
        }
        else if (null == txtBcc.Text || txtBcc.Text.Length == 0 || txtBcc.Text == String.Empty)
        {
            mail.Bcc.Add(new MailAddress(txtBcc.Text.ToString()));
        }
        HttpFileCollection files = Request.Files;
        for (int i = 0; i < files.Count; i++)
        {
            HttpPostedFile file = files[i];
            mail.Attachments.Add(new Attachment(file.InputStream, Path.GetFileName(file.FileName), file.ContentType));

        }

        mail.IsBodyHtml = true;
        SmtpClient smtp = new SmtpClient();
        smtp.Port = 587;
        smtp.Host = "smtp.gmail.com";
        smtp.Credentials = new System.Net.NetworkCredential(txtFrom.Text.ToString(), txtPass.Text.ToString());
        smtp.EnableSsl = true;
        smtp.Send(mail);
        
    }

Posted 30-Jun-13 15:22pm

Member 9987026

Updated 30-Jun-13 16:48pm

NotPolitcallyCorrect

v2

Add a Solution

Comments

[no name] 30-Jun-13 22:51pm

"please help me a google alot", google what? The error message is telling you exactly what the problem is and you are even told which line of code it is happening on. So, what is the problem? Make sure the address is not an empty string before you try and add it.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Ron Beyer · Answer 1 · 2013-06-30T17:38:00

Expanding on Amits solution:

C#

foreach (string emailCC in txtCc.Text.ToString().Split(splitter))
{
    if(!string.IsNullOrWhitespace(emailCC)){
        mail.CC.Add(new MailAddress(emailCC.Trim()));
    }
}

or, you can catch it earlier by using one of the .Split overloads:

C#

foreach (string emailCC in txtCc.Text.ToString().Split(splitter.ToCharArray(), StringSplitOptions.RemoveEmptyEntries))

_Amy · Answer 2 · 2013-06-30T17:28:00

Solution 1

Before adding address Check for its existance. Try this:

C#

foreach (string emailCC in txtCc.Text.ToString().Split(splitter))
{
    if(emailCC.Trim() != ""){
        mail.CC.Add(new MailAddress(emailCC.Trim()));
    }
}

--Amit

Posted 30-Jun-13 17:28pm

_Amy