combine date and time in sql

Question

0.00/5 (No votes)

See more:

Hi 'Teachers'

I have a simple question, in my table(MSSQL DB) have fours columns 'working_date' as DateTime type ,'TIME_IN' as char, 'ACTUAL_END_DATE ' as datetime and 'TIME_OUT' as char.

Here is the question: I want to combine them( working_date +TIME_INand ACTUAL_END_DATE +TIME_OUT) and use 'DATEDIFF(minute,A,B)' to calculate working hours, I tried many times ,but every time error come out, my script like below:

SQL

SELECT	
	ISNULL(DATEDIFF(minute,working_date + TIME_IN,ACTUAL_END_DATE + TIME_OUT)*1.0/60,0.0) as 'HOURS'
 FROM ATTENDANCE

error message like this:

Conversion failed when converting date and/or time from character string.

I want the correct way, please help ,'Teachers'.

Posted 13-Jul-13 19:22pm

chenghuichao

Add a Solution

4 solutions

Solution 4

Hi
In clear way, You can use from bellow query instead of first solution:

SQL

Declare	@StartDate	As	Date,
	@StartTimeChar	As	nVarChar(10),
	@StartTimeTime	As	Time(0),
	@ResultDateTime	As	SmallDateTime
 

Set	@StartDate	= '2012-01-01'
Set	@StartTimeChar	= '20:30:00'
Set	@StartTimeTime	= Cast(@StartTimeChar as Time)
Set	@ResultDateTime = DATETIMEFROMPARTS(Year(@StartDate), Month(@StartDate), Day(@StartDate), DATEPART(HOUR,@StartTimeTime), DATEPART(MINUTE,@StartTimeTime) , DATEPART(SECOND,@StartTimeTime) , 0)
Set	@ResultDateTime = DATEADD(SECOND,  DATEPART(SECOND,@StartTimeTime) , DATEADD(MINUTE, DATEPART(MINUTE,@StartTimeTime) , DATEADD(HOUR, DATEPART(HOUR,@StartTimeTime) , DATEADD(MONTH, (Year(@StartDate) - 1900) * 12 + Month(@StartDate) - 1 , Day(@StartDate) - 1))))
 
Select	@StartDate, @StartTimeTime, @ResultDateTime

I hope it's helpful for you.

Posted 13-Jul-13 22:40pm

Reza Alipour Fard

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Reza Alipour Fard · Accepted Answer · 2013-07-13T22:29:00

Hi
If you use from SQL 2008 you must use from bellow code:

SQL

DECLARE	@Day	As	Int, 
	@Month	As	Int, 
	@Year	As	Int, 
	@Hour	As	Int,
	@Minute	As	Int,
	@Second	As	Int,
	@Result	As	DateTime

Select	@Day	= Your Day, 
	@Month	= Your Month,
	@Year	= Your Year,
	@Hour	= Your Hour,
	@Minute	= Your Minute,
	@Second	= Your Second,

Select	@Result = DATEADD(SECOND, @Second , DATEADD(MINUTE, @Minute , DATEADD(HOUR, @Hour , DATEADD(MONTH, (@Year - 1900) * 12 + @Month - 1 , @Day - 1))))

On the other hand you must use:

DATEADD(SECOND, @Second , DATEADD(MINUTE, @Minute , DATEADD(HOUR, @Hour , DATEADD(MONTH, (@Year - 1900) * 12 + @Month - 1 , @Day - 1))))

Instead of:

DATETIMEFROMPARTS(Year(@StartDate), Month(@StartDate), Day(@StartDate), DATEPART(HOUR,@StartTimeTime), DATEPART(MINUTE,@StartTimeTime) , DATEPART(SECOND,@StartTimeTime) , 0)

I Hope it's helpful for you.
If you have question, Please tell me.

OriginalGriff · Accepted Answer · 2013-07-13T20:35:00

The"correct" way to do it is: don't store the time in or time out as char.
Store them as DateTime instead, and you can do math on them directly

Alternatively, store them as an integer number of minutes, and use the SQL DATEADD function to offset the working_date by that number of minutes.

Never store numeric info as string - it always makes life harder later on.

Reza Alipour Fard · Accepted Answer · 2013-07-13T20:39:00

Solution 2

Hi
You can use from bellow query:

SQL

Declare	@StartDate	As	Date,
	@StartTimeChar	As	nVarChar(10),
	@StartTimeTime	As	Time(0),
	@ResultDateTime	As	SmallDateTime


Set	@StartDate	= '2012-01-01'
Set	@StartTimeChar	= '20:30:00'
Set	@StartTimeTime	= Cast(@StartTimeChar as Time)
Set	@ResultDateTime = DATETIMEFROMPARTS(Year(@StartDate), Month(@StartDate), Day(@StartDate), DATEPART(HOUR,@StartTimeTime), DATEPART(MINUTE,@StartTimeTime) , DATEPART(SECOND,@StartTimeTime) , 0)

Select	@StartDate, @StartTimeTime, @ResultDateTime

You must use from DATETIMEFROMPARTS() to create datetime and use Year(), Month(), Day() to get date elements and use DATEPART(HOURS/MINUTE/SECOND,@YourTime) to get hours, minute, second

I think it's helpful for you.

Posted 13-Jul-13 20:39pm

Reza Alipour Fard

Comments

chenghuichao 14-Jul-13 3:39am

hi sir, I got the message:'DATEFROMPARTS' is not a recognized built-in function name.

Reza Alipour Fard 14-Jul-13 3:53am

Please wait a minute....
What is your SQL server version??? tell me your version until I give solution compatible with your version.
DATEFROMPARTS is a function in SQL server 2012.
Rate 1 out of 5!!! :-(

chenghuichao 14-Jul-13 4:02am

SQL server 2008 R2

chenghuichao 14-Jul-13 4:08am

I wrote as below also cant:
SELECT
convert(date,
convert(varchar(4),YEAR(WORKING_DATE))+
convert(varchar(2),MONTH(WORKING_DATE))+
convert(varchar(2),DAY(WORKING_DATE))+
convert(varchar(5),isnull(TIME_IN,'00:00'))
),
convert(date,
convert(varchar(4),YEAR(ACTUAL_END_DATE))+
convert(varchar(2),MONTH(ACTUAL_END_DATE))+
convert(varchar(2),DAY(ACTUAL_END_DATE))+
convert(varchar(5),isnull(TIME_OUT,'00:00'))
)
FROM ATTENDANCE

I might break!!

Reza Alipour Fard 14-Jul-13 4:26am

Use Solution 1