retrieve image data into picture box

Question

1.00/5 (3 votes)

See more:

in my c# application have store image into database and retrieve images from database to picture box.
image insertion is successful in to the data base but image read not possible.one error occurs "parameter is not valid"
// my c# code is here
// the code for insert image in to the database is below

C#

FileStream fs = new FileStream(textBox1.Text, FileMode.Open, FileAccess.Read);
byte[] imgbnry = new byte[fs.Length];

fs.Read(imgbnry, 0,imgbnry.Length);
fs.Close();
string str = "insert into tbl_img (id,photo)values('" + textBox3.Text + "','@img')";
SqlConnection con = new SqlConnection(@"DataSource=.\SQLEXPRESS;AttachDbFilename=C:\Users\Keltron_Project\Documents\sampl_pi.mdf;Integrated Security=True;Connect Timeout=30;User Instance=True;");
con.Open();
SqlCommand cmd = new SqlCommand(str, con);

cmd.Parameters.AddWithValue("@img", imgbnry);
int n = cmd.ExecuteNonQuery();
if (n > 0)
{
    MessageBox.Show("Successfully inserted");
}
else
{
    MessageBox.Show("Not inserted");
}

// the code for read image from database is below

C#

string str = "select photo from tbl_img where id='"+textBox2.Text+"'";
SqlConnection con = new SqlConnection(@"DataSource=.\SQLEXPRESS;AttachDbFilename=C:\Users\Keltron_Project\Documents\sampl_pi.mdf;Integrated Security=True;Connect Timeout=30;User Instance=True;");
 con.Open();
 SqlDataAdapter da = new SqlDataAdapter(str,con);
 DataTable dt = new DataTable();
        
 da.Fill(dt);
 if (dt.Rows.Count > 0)
 {
 byte[] imgdata = new byte[0];
 imgdata = (byte[])dt.Rows[0][0];
  MemoryStream ms = new MemoryStream(imgdata);
 pictureBox1.Image = Image.FromStream(ms);      //error occurs here   "prameter is not valid"
 }
 else
{
 MessageBox.Show("No images in a table");
 }

please help...
thanks in advance

Posted 18-Sep-14 20:43pm

Member 10984793

Updated 8-Apr-18 19:50pm

george4986

v4

Add a Solution

Comments

george4986 19-Sep-14 3:19am

specify the buffer length
"byte[] imgdata = new byte[0];" doesn't work

George Jonsson 19-Sep-14 3:29am

Don't use all capital letters in your text.
it is considered to be SHOUTING, and it is not very polite.

Member 10984793 19-Sep-14 4:12am

sory sir,,,

George Jonsson 19-Sep-14 4:34am

Don't be sorry, change it.

5 solutions

Solution 2

what happens if you replace this

C#

byte[] imgdata = new byte[0];
imgdata = (byte[])dt.Rows[0][0];
MemoryStream ms = new MemoryStream(imgdata);

with this

C#

MemoryStream ms = new MemoryStream(byte[])dt.Rows[0][0]);

Other things you could try are to write

C#

(byte[])dt.Rows[0][0]

to a file on disk and see if its actually valid image, AND ONLY ONE image in the stream.

Do you keep the size of the original in a column in the database when its stored ? If so I'd compare that to the MemoryStream ms # of bytes

This construct :-

C#

Image.FromStream()

can also be an 'issue' if the Image class cannot determine the type of the image - png or bmp for example

Posted 18-Sep-14 21:25pm

Garth J Lancaster

Comments

Member 10984793 19-Sep-14 4:37am

how to write to file

Member 10984793 19-Sep-14 5:50am

pls help....

Solution 3

C#

private void button1_Click(object sender, EventArgs e)
{
    Image tempImage;
    using (var conn = new SqlConnection("myconnectionstring"))
    {
        conn.Open();
        using (
            var cmd = new SqlCommand("SprocToGetImageBytes", conn) {CommandType = CommandType.StoredProcedure})
        {
            using (var rdr = cmd.ExecuteReader())
            {
                var buffer = (byte[])rdr[0];
                using (var ms = new MemoryStream(buffer))
                {
                    tempImage = Image.FromStream(ms); //theres your image.
                    pictureBox1.Image = tempImage;
                    pictureBox1.Refresh();
                }
            }
        }
    }
}

Posted 18-Sep-14 22:16pm

Member 10911231

Comments

Member 10984793 19-Sep-14 4:38am

again same problem is occur

Member 10984793 19-Sep-14 5:58am

anyone helpe me.......

Member 10911231 20-Sep-14 1:51am

You should use sqltype with the parameter at inserting and retrive time....

Member 10911231 20-Sep-14 1:55am

typeof(SqlBinary)

Member 10984793 20-Sep-14 2:00am

got it....

Solution 6

SqlDataAdapter da = new SqlDataAdapter(str,con);


 byte[] picbyte = da["Your image column name"] as byte[] ?? null;
                        if (picbyte != null)
                        {
                            MemoryStream mstream = new MemoryStream(picbyte);
                            pictureBox1.Image = System.Drawing.Image.FromStream(mstream);
                            {
                                System.Drawing.Bitmap bmp = new System.Drawing.Bitmap(mstream);
                            }

                        }

Posted 8-Apr-18 19:52pm

Nithi999

Comments

Maciej Los 9-Apr-18 1:55am

4 years too late ;(

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Member 3398321 · Accepted Answer · 2014-09-19T01:36:00

FileStream fs = new FileStream(textBox1.Text, FileMode.Open, FileAccess.Read);
byte[] imgbnry = new byte[fs.Length];

fs.Read(imgbnry, 0, imgbnry.Length);
fs.Close();
string str = "insert into tbl_img (id,photo)values('" + textBox3.Text + "',@img)";

string ConStr = @"Server=COMP3\SQLEXPRESS;Database=TestDb;User Id=sa;Password=cos123;";

SqlConnection con = new SqlConnection(ConStr); //@"DataSource=.\SQLEXPRESS;AttachDbFilename=C:\Users\Keltron_Project\Documents\sampl_pi.mdf;Integrated Security=True;Connect Timeout=30;User Instance=True;");
con.Open();
SqlCommand cmd = new SqlCommand(str, con);

cmd.Parameters.AddWithValue("@img", imgbnry);
int n = cmd.ExecuteNonQuery();
if (n > 0)
{
MessageBox.Show("Successfully inserted");
}
else
{
MessageBox.Show("Not inserted");
}

george4986 · Accepted Answer · 2014-09-18T21:24:00

Solution 1

replace code

C#

FileStream fs = new FileStream(textBox1.Text, FileMode.Open, FileAccess.Read);
byte[] imgbnry = new byte[fs.Length];
fs.Read(imgbnry, 0,imgbnry.Length);
 fs.Close();

on insert section with below code

C#

Image image = 
////Image.FromFile(textBox1.Text);
Image.FromFile(@"C:\Users\ku102\Pictures\bitmap\usertile36.bmp");
MemoryStream ms = new MemoryStream();
image.Save(ms, ImageFormat.Bmp);
byte[] imgbnry = new byte[ms.Length];
ms.Position = 0;
ms.Read(imgbnry, 0, imgbnry.Length);

good luck ;-)

Posted 18-Sep-14 21:24pm

george4986

Updated 19-Sep-14 1:00am

v3

Comments

Member 10984793 19-Sep-14 4:14am

i tried above code but not work...
again same error is occur

george4986 19-Sep-14 4:21am

can u post value of dt.Rows[0][0] here

Member 10984793 19-Sep-14 5:08am

how to post

george4986 19-Sep-14 5:17am

copy pic data from database table field and post here as reply.
keltron ? student there?

Member 10984793 19-Sep-14 5:24am

the database photo column contain data is binary data

Member 10984793 19-Sep-14 5:16am

only show this system.byte[]

Member 10984793 19-Sep-14 5:49am

any solution sir...

george4986 19-Sep-14 7:01am

check updated solution .assuming ur sql data type is varbinary(MAX)

Member 10984793 20-Sep-14 1:04am

thanks.....finally got it...

Member 10984793 20-Sep-14 1:05am

thank you very much...

george4986 20-Sep-14 1:27am

u r always welcome ;-)

retrieve image data into picture box

5 solutions

Solution 4

Solution 1

Solution 2

Solution 3

Solution 6

Add your solution here

Preview 0

Existing Members

...or Join us