Add your own alternative version
Stats
275K views 1.8K downloads 66 bookmarked
Posted
3 Dec 1999

Comments and Discussions



I reviewed your source code, but do not found where RoundValue() and FloatToInt() in assembly are referenced.
diligent hands rule....





The functions looks ok, but what behavior do you expect with special numbers (NaN, Infty)? This is usually beyond the scope of most programmers, I think.
Best regards, and congratulation for your very clean programming style.
Miguel





Nice work, but I'd like to ask you about conversion operations with floating point numbers in C++. My problem is below:
int main() { float a; a=1.35f; double b; b=0.0; b=b+a; printf("\n%.15f\n",b); getch(); }
in theory we'll have in result: 1.35, but in practice we'll have something like 1.3500000238418579
Could you give me some advise? I use Visual Studio 2008 Team System SP1





Because of the inaccuracies of storing numbers in floats, you should use SigFig() function above so it removes the 238... bit at the end. If your after better accuracy, use double's everywhere. However, for speed I'd always use float, but be knowlegable in the fact that numbers can't be stored exactly.
Some numbers (e.g., 1/3 and 0.1) cannot be represented exactly in binary floatingpoint no matter what the precision. Software packages that perform rational arithmetic represent numbers as fractions with integral numerator and denominator, and can therefore represent any rational number exactly. Such packages generally need to use "bignum" arithmetic for the individual integers.
Regards, Simon Hughes





BTW what was the criterion that make yoou to choose 1.0e20 (beacuse of it is exponentially halfway on float capacity? )?
The standard float equality test == is difficult to grasp fotr the newbie, but introducing an arbitrary constant, IMHO may be misleading for him(I think the constant should be problem, i.e. application, dependent).
BTW Happy new year.
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.  Alfonso the Wise, 13th Century King of Castile.
[my articles]





Will this simple Round function be faster?
double Round(double val, int dp) { int modifier = 1; for (int i=0; i<dp; ++i) modifier *= 10; return (floor(val*modifier+0.5)/modifier); }





Congratulations. It's accurate (for positive numbers only) and it's 20 times faster in both debug and release modes.
However, you need to fix it to do negative numbers correctly. RoundNew(2.15, 1) // gives 2.2 (correct) RoundNew(2.149, 1) // gives 2.1 (correct) RoundNew(1.475, 2) // gives 1.47 (incorrect, should be 1.48)
However with a little fix:
double RoundNew(double val, int dp)
{
int modifier = 1;
for (int i = 0; i < dp; ++i)
modifier *= 10;
if(val < 0.0)
return (floor(val * modifier  0.5) / modifier);
return (floor(val * modifier + 0.5) / modifier);
}
It all works now as it should.
20x faster, Excellent.
Regards, Simon Hughes





Thanks for the fix. But I think need another small modification. Otherwise some negative numbers may not work. Just need to use ceil instead of floor when the numbers are negative.
double RoundNew(double val, int dp) { int modifier = 1; for (int i = 0; i < dp; ++i) modifier *= 10;
if(val < 0.0) return (ceil(val * modifier  0.5) / modifier); return (floor(val * modifier + 0.5) / modifier); }





Yes your right. Thanks for the update.
Regards, Simon Hughes





According to my benchmarking, this is still 3x slower than this:
double Round(double dIn, int iPlaces)
{
if (dIn < 0)
return ((long)(((dIn*pow(10.0,iPlaces))+0.5))/pow(10.0,iPlaces));
else
return ((long)(((dIn*pow(10.0,iPlaces))+0.5))/pow(10.0,iPlaces));
}






I just love this!!!! Tnx!
93/93





i need a function which does like this: quant(X,Q) takes two inputs, X  Matrix, vector or scalar. Q  Minimum value. and returns values in X rounded to nearest multiple of Q. plz help me how to do. thanks in advance.
Ravi M.R





Hi,
I am trying to convert a double precision number to a float and I am having this problem, please help me to resolve the same.
double fdblValue = 11574.24; float fFloatValue = ( float ) fdblValue;
I am getting 11574.2 instead of 11574.24. What is the issue? Please let me know.
Regards,
Sarma






Hello,
I am just beginning with Visual C++ building a simple dialog program to run some calculations and I ran into a little bit of a wall. I will be inputting a couple floating point values and then hit calculate and the program will perform some calculations and output the data to another control box. My problem is:
1) I get theinput no problem 2) I convert it into a floating point 3) I do the calculation
//the problem is here!! 4) once the data is calculated I want to output it. However the problem lies in converting the new calculated float back to a string in borland you have FloatToStrF and it does it no problem However here in visual C++ I have not found a routine or function that does this to my requirements. My question is how do I take the float value and return it to the edit control box as a string. I might just not be doing it correctly to begin with thus the problem or confusion but here is a simple break down. I rewrote this a little using distance speed and time I figured this would be better then giving you my program with all the variables (its for a robots arm movement) //on hitting calculate inputs distance and speed // outputs the time it will take void CExoSpinDlg::OnCalc() { // these two just to store the value of edit control boxes CString someText; CString someText2; //edit control box 1 is distance m_distance.GetWindowText(someText); // edit control box 2 is speed, i am using a bunch of spin controls for my data // as well so i will put one in here but it should not make a differance right? m_SPINVALUE.GetWindowText(someText2);
// now we have the two values stored as CStrings //from string to float (i am aware of the possible loss of exactness here // but until i figure out Vc++ a little more i am stuck float distance = atof(LPCSTR(someText)); float speed = atof(LPCSTR(someText2)); float time = distance/speed;
//MY PROBLEM IS HERE TAKING THIS FLOAT AND PUTTING BACK INTO // THE DIALOG BOXES //back to string is where i am struggling with // i know the ftoa is NOT correct but I can not seem to find any other // way of doing it char buffer[256]; ftoa(time,buffer,10); MessageBox(buffer); }
any thoughts or suggestions on how i might do this would be appreciated
Thank You Ed Storey





Well, there's always good ol' sprintf(buffer,"%.2f", time);...
 Carlos





Thanks Carlos! It's the little things that matter.





Suppose you have some code that calculates a bunch of rational functions: a rational function is function constructed using +, , * and /. Then you can replace the code with something that uses only one /. It's only useful in certain situations depending on the relative speed of / and other operators. For example the following triangle rasteriser setup type code 'na = 1.0/a; nb = 1.0/b; nc = 1.0/c' can be replaced by 't = 1/(a*b*c); ct = c*t; na = b*ct; nb = a*ct; nc = a*b*t;". 7 multiplies and one divide should be faster than 3 divides. Damn  I've given away my secret.  SIGFPE





The significant figures specified in the original SIgFig routine get 'lost' when the value is converted to floating point. For example, if the result is 1.2 and we have specified 4 significant figures, we need to go to extra work to correctly display this as 1.200. The FloatToText routine converts it to 1.2; %f in the format will display something like 1.2000000. Yes, we can specify the precision modifier in the printf format code, but this requires that we compute the order of magnitude of the number so that we can determine how many decimal places we need to achieve the right number of significant figures. The following modified version of SigFig correctly produces the string version of the number. It is not pretty code, but it works!
CString SigFigStr(float X, int SigFigs) { CString str;
if(SigFigs < 1) { ASSERT(FALSE); return str; }
int Sign; if(X < 0.0f) Sign = 1; else Sign = 1;
X = fabsf(X); float Powers = powf(10.0f, floorf(log10f(X)) + 1.0f);
float val = Sign * Round(X / Powers, SigFigs) * Powers;
str.Format("%f", val); str.TrimLeft(); str.TrimRight();
int end = SigFigs; if(Sign < 0) end++; if(str.Find('.') != 1) end++;
str = str.Left(end);
// Remove decimal point if nothing after it. "1234." becomes "1234" if(str.Right(1) == ".") str = str.Left(str.GetLength()  1);
return str; }





// I may post all this code as an update to the main topic.
// This is 3.4 times faster than using sqrtf(...) #define FP_BITS(fp) (*(DWORD *)&(fp)) #define FP_ABS_BITS(fp) (FP_BITS(fp)&0x7FFFFFFF) #define FP_SIGN_BIT(fp) (FP_BITS(fp)&0x80000000) #define FP_ONE_BITS 0x3F800000
static unsigned int fast_sqrt_table[0x10000]; // declare table of square roots
typedef union FastSqrtUnion { float f; unsigned int i; } FastSqrtUnion;
void build_sqrt_table() { unsigned int i; FastSqrtUnion s; for (i = 0; i <= 0x7FFF; i++) { // Build a float with the bit pattern i as mantissa // and an exponent of 0, stored as 127 s.i = (i << 8)  (0x7F << 23); s.f = sqrtf(s.f); // Take the square root then strip the first 7 bits of // the mantissa into the table fast_sqrt_table[i + 0x8000] = (s.i & 0x7FFFFF); // Repeat the process, this time with an exponent of 1, // stored as 128 s.i = (i << 8)  (0x80 << 23); s.f = sqrtf(s.f); fast_sqrt_table[i] = (s.i & 0x7FFFFF); } }
inline float fastsqrt(float n) { if(FP_BITS(n) == 0) return 0.0f; // check for square root of 0 FP_BITS(n) = fast_sqrt_table[(FP_BITS(n) >> 8) & 0xFFFF]  ((((FP_BITS(n)  FP_ONE_BITS) >> 1) + FP_ONE_BITS) & 0x7F800000); return n; }
void main(void) { build_sqrt_table(); float a = fastsqrt(1.234f); }





Another Square Root Algorithm:
/******************************************************* ** square_root  single precision square root ******************************************************** ** input: value to take the square root of ** output: nothing ** calls: frexp(), ldexp() ** returns: 0.0 if input value <= 0.0, ** otherwise square root of input value ******************************************************** */ float square_root(float xx) { float f, x, y; int e;
f = xx; if (f <= 0.0) { return 0.0; }
/* split mantissa and exponent */ x = frexp(f, &e); /* f = x * 2**e, 0.5 <= x < 1.0 */
/* Q  is power of 2 odd ? */ if (e & 1) { /* yes  double mantissa and decrement the power of 2 (exponent) */ x = x + x; e = 1; }
/* compute exponent power of 2 of the square root */ e >>= 1;
/* Q  is the mantissa between sqrt(2) and 2 ? */ if (x > 1.41421356237) { /* yes  offset mantissa, compute series */ x = x  2.0; y = ((((( 9.8843065718E4 * x + 7.9479950957E4) * x  3.5890535377E3) * x + 1.1028809744E2) * x  4.4195203560E2) * x + 3.5355338194E1) * x + 1.41421356237E0; }
/* no  Q  is the mantissa between sqrt(2)/2 and sqrt(2) ? */ else if (x > 0.707106781187) { /* yes  offset mantissa, compute series */ x = x  1.0; y = ((((( 1.35199291026E2 * x  2.26657767832E2) * x + 2.78720776889E2) * x  3.89582788321E2) * x + 6.24811144548E2) * x  1.25001503933E1) * x * x + 0.5 * x + 1.0; } else { /* no  mantissa is between 0.5 and sqrt(2)/2 */ x = x  0.5; y = ((((( 3.9495006054E1 * x + 5.1743034569E1) * x  4.3214437330E1) * x + 3.5310730460E1) * x  3.5354581892E1) * x + 7.0710676017E1) * x + 7.07106781187E1; }
/* calculate y = y * 2**e */ y = ldexp(y, e);
return y; }





Your square_root() function is accurate, but is slower than sqrtf() iteself (about 3.5 times slower) :





Thanks for your response.
I'm using the square_root() function in an embedded x86 system written with the MSVC v1.52c compiler. The runtime didn't have a single precision sqrt() so this algorithm was faster for me than the runtime double precision version.
I like the table driven approach, and will investigate placing the table into ROM.
Steven J. Ackerman, Consultant ACS, Sarasota, FL http://www.acscontrol.com sja@gte.net





How accurate is this? About howmany bits off is it from the real answer?
I also wonder in real applications how much performance penalty one pays for having to load a 32k integer table (128k bytes?) into cache before this function can be called. Perhaps in very tight loops it's worth it.
Thanks for the bithacks. I'm always interested.





// This is about 2.12 times faster than using 1.0f / n // r = 1/p #define FP_INV(r,p) \ { \ int _i = 2 * 0x3F800000  *(int *)&(p); \ r = *(float *)&_i; \ r = r * (2.0f  (p) * r); \ }





Simon Hughes wrote: int _i = 2 * 0x3F800000  *(int *)&(p); \
uhhh ?? what kind of magic is this ?





It's called speed voodoo It's not as accurate, but it's damn fast.
Here are the results from a simple test:
float d = 22.0f, a = 1.0f / d, b;
FP_INV(b, d);
d = 5000.0f;
a = 1.0f / d, b;
FP_INV(b, d);
Regards, Simon Hughes Email: simon@hicrest.net Web: www.hicrest.net





Simon, great job. You may wish to add a note to the source code comments that states it is an approximation function, and not necessarily a replacement for all uses of 1.0 / x.
Cheers,
Jason Doucette http://www.jasondoucette.com/





// This is 15.5 times faster than RoundValue __forceinline void FloatToInt(int *int_pointer, float f) { __asm fld f __asm mov edx,int_pointer __asm FRNDINT __asm fistp dword ptr [edx]; }





Simon Hughes wrote: // This is 15.5 times faster than RoundValue
Hmm, I didn't really get how to use it for round value, could you give an example?
Ilia





inline int RoundValue(float param)
{
int a;
int *int_pointer = &a;
__asm fld param
__asm mov edx,int_pointer
__asm FRNDINT
__asm fistp dword ptr [edx];
return a;
}
int nVal = RoundValue(123.456f);
float fVal = 123.456f;
int nVal = RoundValue(fVal);
inline void FloatToInt(int *int_pointer, const float &f)
{
__asm fld f
__asm mov edx,int_pointer
__asm FRNDINT
__asm fistp dword ptr [edx];
}
int nVal;
float fVal = 123.456f;
FloatToInt(&nVal, fVal);
Regards, Simon Hughes Email: simon@hicrest.net Web: www.hicrest.net





Simon Hughes wrote: __forceinline void FloatToInt(int *int_pointer, float f) { __asm fld f __asm mov edx,int_pointer __asm FRNDINT __asm fistp dword ptr [edx]; }
Would it be safer to explicitly set the control word before the round and restoring the previous control word once we're done? Or is this redundant?
It seems that if I wanted to "Round to nearest" (or "Round to even" since that is apparently the intel implementation based on the results for halfintegers) I should not assume the control word had not been modified by other code run previously.
It would seem the code is still vulnerable to rounding errors if some prior code had set the control word to something other than the default 037F  Same as FINIT (round to nearest, all exceptions masked, 64bit precision). This statement is based on the content in MSDN KnowledgeBase article Q126455  specifically the line that says "Application programmers can avoid rounding errors in the second bug by not overriding the default rounding modes."
Since we are not sure if some prior code overrode the default, we need to explicitly set it to be sure.
By the way, thanks for the article. It has been a big help.





Does anyone know how to round to an arbitrary number? For example, rounding to the nearest 2.5, 0.5 or 1.33 Nearest 2.5 case: 2.2 rounds down to 2, 2.3 rounds up to 2.5, 2.7 rounds down to 2.5, 2.8 rounds up to 3 Thanks.





Did anybody experienced problem with modf function? In most cases it works fine. But in some instances it would not work properly. Ex: 4570.0000 it would return 0.9999999 in fraction and 4569.0000 in integer part. Any ideas?
Thanks Gene





The following function is a sample of how to round to the nearest .33 or .66
double GetNearest33( const double dRawNumber )
{
double dBaseVal = floor(dRawNumber);
double dBaseDiff = dRawNumber  dBaseVal;
double dToNearest33 = (double)((int)((dBaseDiff + 0.165)*100.0)/33*33)/100.0;
(dToNearest33 == 0.99)?dToNearest33 = 1.0:dToNearest33;
(dToNearest33 == 0.66)?dToNearest33 = 0.67:dToNearest33;
return dBaseVal + dToNearest33;
}





this rounds to the nearest x the idea is to convert the number to fixed point, using the base that you want to round to, then convert back to floating point.
float GetNearest( float number, float fixedBase ) {
if (fixedBase != 0 && number != 0) {
float sign = number>0?1:1;
number*=sign;
number/=fixedBase;
int fixedPoint = (int)floor(number+.5f);
number = fixedPoint*fixedBase;
number*=sign;
}
return number;
}





Lately, I've been trying to come up with a good rounding function that will even handle double SNAFUs. If you want a good example of one, simply set a double var to 105, multiply it by 1.15, and then by 20. Like below: //dddDDDdddDDDdddDDD double dTmp = 105.0;
dTmp *= 1.15; // equals 120.75....or does it?!!! dTmp *= 2; // equals 241.5....or does it?!!!
//dddDDDdddDDDdddDDD
Now, when you try to round dTmp with a rounding routine, it will roung down to 241, instead of correctly to 242. I'm sure a lot of you know that this is caused by a limitation of representing fractions in a binary format *1.15 is the cause, I'm pretty sure that 0.15 cannot be represented correctly*.
My question is this: Has anyone seen a rounding alg that can handle one of these "off by .000000000000000001" doubles? I'm currently working on one right now, but my head is starting to get sore from banging it against the wall. I'm experimenting with binary arithmatic on this, but I'm not really sure if that is the way to go. Also, I think that IEEE 7541984 may hold the answers, but I don't really want to spend $54 on it...
Dere





In windows I don't know of anyway with the current compilers, used to be under unix you had quad precision as an option. The only thing bad about that was that all you numbers were quad, but none of the intrinsic functions (sin, cos, sqrt) were quad so you had to write your own





Actually when it comes to rounding it is common practice as well as maybe an IEEE specifiaction that for 0.5 all odd numbers round down and all even number round up. This is so that there is not a statistical anomaly when rounding.
eg. 1.5 rounds to 1, 2.5 rounds to 3.
eg. (1.5 + 2.5) / 2 = 2 rounded properly (1 + 3) / 2 = 2 always .5 round up (2 + 3) / 2 = 2.5
Of course depending on the number of odd and even numbers you get closer to the real average, but you definately don't get further away!





RoundValue and FloatToInt will not work properly, because frndint instruction will not round to nearest, but to even for equidistant cases (ex. 0.5, 2.5, etc.).





We all know that floating point numbers aren't necessarily equal. Given the following code:
double x = 1.0; double y = 1.0;
we cannot assume that this line will return TRUE:
if (x == y)...
I use this function for comparing raw doubles:
/// BOOL AlmostEqual(double n1, double n2, int decplaces) { if (decplaces == 0) { return (floor(n1) == floor(n2)); } double divider = 10.0; for (int i = 1; i <= decplaces; i++); { divider *= 10; } return (n1 >= n2 && n1 < n2 + (1 / divider)); }
Simply pass in the two values you're comparing, and how many decimal places to compare, and you're all set.





I do something similar, but only take the difference between x and y and compare that to some minimal value (below which I consider to be zero).
eg:
double nThreshold = 0.000001; // Where nThreshold is smallest number I consider valid
bool IsEqual(double x, double y, double nThreshold) { double nDifference = abs(x  y); return ( nDifference < nThreshold ) ? true : false;





I agree, FloatsEqual will definitely not work appropriate.
I have this solution, exactly based on the definition of DBL_EPSILON. As I understand this definition DBL_EPSILON is valid only for a window around 1.0.
/*static*/ bool Double::IsEqual(double a, double b, double epsilon /* = DBL_EPSILON */) { const double& e = epsilon; if (b == 0.0) { // b has all bits zero if (a > 0.0  a < 0.0) // a has significant bits, thus a and b are not equal return false; // a has no bit set, thus a and b are equal return true; } const double q = a/b; if (q<0) { //q negative, thus a and b have different signs, thus a and b are not equal return false; }
//q is positive, thus a and b must have the same sign //q must be 1.0 if a and b are equal
//check, whether q is in epsilon window around 1.0 if (q > 1.+e) return false; if (q < 1.e) return false;
return true; }
Thomas Haase





/// double TruncAt(double X, int Offset, double Prec) { return (floor(X * pow(10,Offset) + Prec) * pow(10, Offset)); }
/// double rounder(double n, int places) { if (places > 0) { double midpoint = 0.0, placeval = 1.0; for (int i = 1; i <= places; i++) placeval *= 0.10; midpoint = placeval * 5.0; // the value to check for rounding direction return TruncAt(n, places, midpoint); } double fmodresult; fmodresult = n  floor(n); if (fmodresult >= 0.500000) return (n + (1.0  fmodresult)); else return (n  fmodresult); }





inline double round(double in){ return floor(0.5 + in); }





CString FloatToText(double dVal, int nDecPlaces) { CString sNum; sNum.Format("%.*lf", nDecPlaces, dVal); return sNum; }





Well, that does the float to string convert, but doesn't do what I'd use this particular function for, namely, stripping trailing 0's.
I'd add a while loop after the sNum.Format to start at the end of the string, and while the current char is a 0, replace it with a null until you hit the decimal, or the beginning of the string.





Have you actually tried it?
The asterisk in the format string tells the Format funciton that there's an identifier in the string which defines the number of decimal places to include.
Hence, calling FloatToString(123.450000, 2) would result in "123.45" How is that any different than what you're trying to do?





I was thinking about your statement after posting my reply, and I thought I'd add this:
If you want a function to strip trailing 0's from a double, you should write a function called "StripTrailingZeros". This function has (according to the prototype) a single purpose, converting a double to a string with a specified precision. It is considered by many to be poor programming technique to make a funciton do something that is not apparent by its prototype or parameter list.
My version of this function does *exactly* what the prototype defines, maintains the positive/negative status of the double, as well as ommitting the '.' from the string if the programmer specified 0 decimal places.
Here's a StripTrailingZeros function for you:
CString StripTrailingZeros(double dValue, int nPrecision) { // first we convert it to a string CString sValue = FloatToString(dValue, nPrecision);
// then we reverse it to make finding 0's easier sValue.MakeReverse();
// find first NON zero character int nPos = sValue.FindOneOf(".,123456789"); // if we found one of those chars somewhere other than the 1st char of string if (nPos > 0) { // strip zeros out sValue.Mid(nPos); } // if 1st char is now a dot or comma if (sValue.GetAt(0) == '.'  sValue.GetAt(0) == ',') { // strip it out sValue.Mid(1); }
// reverse the string again sValue.MakeReverse();
// return the massaged string return sValue; }
I haven't tested this function, but it should work fine. Just thought I'd throw that out there...







General News Suggestion Question Bug Answer Joke Praise Rant Admin Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.

