|
Thanks for clearing that up. Didn't make JS look any better to me though 
Weird architecture that, just because there is a structure doesn't mean that it's actually helpfull. I'm sure there is a special part of Hell reserved for script designers putting subtle twists to a product.
I will certainly go for your first suggestion, the second wouldn't conform to the Revealing Module Pattern (or should that have been in all caps?).
"God doesn't play dice" - Albert Einstein
"God not only plays dice, He sometimes throws the dices where they cannot be seen" - Niels Bohr
|
|
|
|
|
jan larsen wrote: I'm sure there is a special part of Hell reserved for script designers putting subtle twists to a product.
Well, in Mr. Eich's defense, he did only have 10 days to design the language.
|
|
|
|
|
That's probably part of the reason why Allman style is not very popular in JS. And I agree: The optional semicolon is just terrible.
|
|
|
|
|
|
|
What do you get when you cross a joke with a rhetorical question?
The metaphorical solid rear-end expulsions have impacted the metaphorical motorized bladed rotating air movement mechanism.
Do questions with multiple question marks annoy you???
|
|
|
|
|
![Green Alien | [Alien]](https://codeproject.global.ssl.fastly.net/script/Forums/Images/alien.gif)
Bastard Programmer from Hell 
If you can't read my code, try converting it here[^]
|
|
|
|
|
Kitty at my foot and I waAAAant to touch it...
|
|
|
|
|
|
Kitty at my foot and I waAAAant to touch it...
|
|
|
|
|
![Sheep | [baah]](https://codeproject.global.ssl.fastly.net/script/Forums/Images/sheep.gif)
What do you get when you cross a joke with a rhetorical question?
The metaphorical solid rear-end expulsions have impacted the metaphorical motorized bladed rotating air movement mechanism.
Do questions with multiple question marks annoy you???
|
|
|
|
|
|
What do you get when you cross a joke with a rhetorical question?
The metaphorical solid rear-end expulsions have impacted the metaphorical motorized bladed rotating air movement mechanism.
Do questions with multiple question marks annoy you???
|
|
|
|
|
"the debugger doesn't tell me anything because this code compiles just fine" - random QA comment
"Facebook is where you tell lies to your friends. Twitter is where you tell the truth to strangers." - chriselst
"I don't drink any more... then again, I don't drink any less." - Mike Mullikins uncle
|
|
|
|
|
I just stuck this in a small data import utility that I don't particularly care about:
catch ( System.Data.DataException err )
{
if ( !err.ToString().Contains ( "Cannot insert duplicate key" ) )
{
throw ;
}
}
If they don't care enough to send me clean data, why should I spend a Friday afternoon writing good code?
modified 7-Aug-15 16:45pm.
|
|
|
|
|
that's the way to do it... why should always we developers have the pressure of being exact and clean
would've done it too this way... if it was friday afternoon in the mid of summer 
|
|
|
|
|
PIEBALDconsult wrote: err.ToString()
Whatever happened to err.Message ? 
Marc
|
|
|
|
|
Nah, I tried that first, but the text is in an InnerException.
I have code that spelunks the Exceptions looking for the actual Error code from SQL Server, but I didn't have it handy.
|
|
|
|
|
If it's in the innermost exception:
catch ( System.Data.DataException err )
{
if ( !err.GetBaseException().Message.Contains ( "Cannot insert duplicate key" ) )
{
throw;
}
}
Exception.GetBaseException Method | MSDN[^]
If it can be anywhere in the chain:
catch ( System.Data.DataException err )
{
bool isDuplicateKey = false;
Exception currentErr = err;
while (currentErr != null && !isDuplicateKey)
{
isDuplicateKey = currentErr.Message.Contains ( "Cannot insert duplicate key" );
currentErr = currentErr.InnerException;
}
if ( !isDuplicateKey )
{
throw;
}
}
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Though I can see the improvement; wouldn't the weak spot here being the check for a localized message? IIRC, then different (localized) versions of .NET will give different results.
"Kan geen rij met dubbele sleutel invoegen in object 'dbo.aa673 met unieke index 'IX_673'."
Next you'll hear "It worked on Win7, and then I opened it on another machine and it crashed. We didn't change anything and it should still be working. Why does Windows do that?" 
Bastard Programmer from Hell 
If you can't read my code, try converting it here[^]
|
|
|
|
|
Indeed. Checking the SQL error codes would be a more robust approach.
However, it sounds like this is a program that's only ever run on one computer, so it's unlikely to suddenly start throwing errors in Dutch. 
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Richard Deeming wrote: However, it sounds like this is a program that's only ever run on one computer
I wish I had gotten a penny everytime that assumption fell apart
Bastard Programmer from Hell
If you can't read my code, try converting it here[^]
|
|
|
|
|
When I do it right, I walk the InnerExceptions to find the first System.Data.SqlClient.SqlException with one of the following error codes:
errorcodes = new System.Collections.Generic.Dictionary<int,PIEBALD.Data.ErrorCode>() ;
errorcodes [ 1205 ] = PIEBALD.Data.ErrorCode.Deadlock ;
errorcodes [ 2601 ] = PIEBALD.Data.ErrorCode.Duplicate ;
errorcodes [ 2627 ] = PIEBALD.Data.ErrorCode.Duplicate ;
errorcodes [ 547 ] = PIEBALD.Data.ErrorCode.ReferentialIntegrity ;
errorcodes [ -2 ] = PIEBALD.Data.ErrorCode.Timeout ;
Then wrap it in a custom Exception:
public partial class DuplicateException : PIEBALD.Data.OperationFailedException ...
public partial class ReferentialIntegrityException : PIEBALD.Data.OperationFailedException ...
public partial class TimeoutException : PIEBALD.Data.OperationFailedException ...
Then my code can catch and act on specific error codes.
|
|
|
|
|
What if locale is not english
TVMU^P[[IGIOQHG^JSH A#@RFJ\c^JPL>;"[, /|+&WLEZGc
AFXc!L<br />
%^]*IRXD#@GKCQ R\^SF_WcHbORY87֦ʻ6ϣN8ȤBcRAV\Z^&SU~%CSWQ@#2
W_ADEPABIKRDFVS)EVLQK)JKQUFK[MUKs$GwU#QDXBER@CBN%
R0~53%eYrd8mt^7Z6]iTF+(EWfJ9zaK-iTV.C\y<pjxsg-b$f4ia> -----------------------------------------------
128 bit encrypted signature, crack if you can
|
|
|
|
|
ALTER TABLE [tablename] ADD DEFAULT (NULL) FOR [fieldname]
Well yes - that should make a huge difference....
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
![Badger | [badger,badger,badger,badger...]](https://codeproject.global.ssl.fastly.net/script/Forums/Images/badger.gif)
![Java | [Coffee]](https://codeproject.global.ssl.fastly.net/script/Forums/Images/coffee.gif)
