Click here to Skip to main content

The Weird and The Wonderful

The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.

We all come across code that simply boggles the mind. Lazy kludges, embarrassing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.

Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.

Re: Redundancy at its finest

ZurdoDev7-Oct-13 2:32

7-Oct-13 2:32

Wow, you can say that again.

Smile | :)

Smile | :)

There are only 10 types of people in the world, those who understand binary and those who don't.

Re: Redundancy at its finest

Bernhard Hiller6-Oct-13 22:14

Bernhard Hiller

6-Oct-13 22:14

Great code.
SystemInformation.PowerStatus.BatteryLifePercent is a float.
And if the battery is empty, he'll say it's not available...

Re: Redundancy at its finest

Edward Giles11-Nov-13 23:34

11-Nov-13 23:34

Is the VB.NET equivalent of a float a Double (64-bit float) or a Single (32-bit float)?

Re: Redundancy at its finest

OriginalGriff6-Oct-13 22:29

6-Oct-13 22:29

D'Oh! | :doh:

The idiot! That should so obviously be a Select Case... Laugh | :laugh:

Laugh | :laugh:

The only instant messaging I do involves my middle finger.

Re: Redundancy at its finest

ZurdoDev7-Oct-13 2:33

7-Oct-13 2:33

Good thing the battery can't give 110% like some developers do. Smile | :)

Smile | :)

There are only 10 types of people in the world, those who understand binary and those who don't.

Re: Redundancy at its finest

0bx7-Oct-13 23:48

7-Oct-13 23:48

I wonder what he would have done if they suddenly wanted to display the battery life at 0.1% accuracy...

.

Re: Redundancy at its finest

MacSpudster5-Nov-13 5:47

5-Nov-13 5:47

An idiot did not write this, for I'm sure they used copy/paste to comprise most of it with assistance from type-ahead. Poke tongue | ;-P

Poke tongue | ;-P

Besides, being the float that it is, he merely wanted to float himself more hours to enable himself to float (er, buy a boat) on the lake.

Thus, he used the float associatively correct.

How to zero-pad a number?

SortaCore1-Oct-13 0:27

1-Oct-13 0:27

A padded number in a file name!

C#

// Set to padded number
int fileCount = Directory.GetFiles("[censored]", "*.csv", SearchOption.AllDirectories).Length + 1;
string fileCountStr = (fileCount <= 999 ? fileCount <= 99 ? fileCount <= 9 ? "000" : "00" : "0" : "") + fileCount;

I think this should win an award for readability in a triply-nested ternary condition Roll eyes | :rolleyes:

Roll eyes | :rolleyes:

.

Re: How to zero-pad a number?

Nagy Vilmos1-Oct-13 0:49

1-Oct-13 0:49

And what about when someone deletes 085.csv? Big Grin | :-D

Big Grin | :-D

speramus in juniperus

Re: How to zero-pad a number?

SortaCore1-Oct-13 0:55

1-Oct-13 0:55

Oh, don't worry. None of the accounts have delete permissions. Unsure | :~

Unsure | :~

Poke tongue | ;-P

Re: How to zero-pad a number?

PIEBALDconsult1-Oct-13 4:18

1-Oct-13 4:18

It's so good to know that the hard work of the developers of String.PadLeft[^] and Int32.ToString[^] is providing so much joy to so many, other than you.

By the way, what language is that? It can't be C#, or did you also override the + operator? OMG | :OMG:

OMG | :OMG:

Re: How to zero-pad a number?

Richard Deeming1-Oct-13 4:27

Richard Deeming

1-Oct-13 4:27

PIEBALDconsult wrote:
It can't be C#

Really?

Poke tongue | ;-P

http://msdn.microsoft.com/en-GB/library/k1a63xkz.aspx[^]

When one or both operands are of type string, + concatenates the string representations of the operands.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: How to zero-pad a number?

PIEBALDconsult1-Oct-13 6:27

1-Oct-13 6:27

Richard Deeming wrote:
When one or both operands are of type string

Yes, and are they?

Re: How to zero-pad a number?

Richard Deeming1-Oct-13 7:09

Richard Deeming

1-Oct-13 7:09

PIEBALDconsult wrote:
Yes, and are they?

Yes, the first operand is a string. It's the result of the ternary operator:

C#

fileCount <= 999 
    ? fileCount <= 99 
        ? fileCount <= 9 
            ? "000" 
            : "00"
        : "0"
    : ""

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: How to zero-pad a number?

PIEBALDconsult1-Oct-13 10:43

1-Oct-13 10:43

And the second?

Re: How to zero-pad a number?

Richard Deeming1-Oct-13 10:57

Richard Deeming

1-Oct-13 10:57

PIEBALDconsult wrote:
And the second?

Doesn't matter. The documentation clearly states, "When one or both operands are of type string...", so the type of the other operand is irrelevant.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: How to zero-pad a number?

Big Daddy Farang1-Oct-13 11:23

Big Daddy Farang

1-Oct-13 11:23

I missed that the first time also. Smile | :)

Smile | :)

BDF

The internet makes dumb people dumber and clever people cleverer.
-- PaulowniaK

Re: How to zero-pad a number?

PIEBALDconsult1-Oct-13 13:44

1-Oct-13 13:44

Where do you see that in the documentation? I don't even see + in the documentation.

And what idiot thought that was a good idea? WTF | :WTF:

WTF | :WTF:

Time to find a new language; this one's becoming VB. Dead | X|

Dead | X|

Edit: I finally found it; it's not documented with String; what a POS. Thumbs Down | :thumbsdown:

Thumbs Down | :thumbsdown:

I'm fairly sure that no self-respecting C# professional uses it that way.

modified 1-Oct-13 20:03pm.

Re: How to zero-pad a number?

Richard Deeming2-Oct-13 1:44

Richard Deeming

2-Oct-13 1:44

It's the link that I posted in my previous message:
http://msdn.microsoft.com/en-GB/library/k1a63xkz.aspx[^]

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: How to zero-pad a number?

SortaCore2-Oct-13 2:07

2-Oct-13 2:07

PIEBALDconsult wrote:
I'm fairly sure that no self-respecting C# professional uses it that way.

Heh, I go for the shorter version. If it doesn't make sense with a mishmash of ints/strings I use brackets or ToString() to clarify.

C#

int i = 124, j = 253;
string s = "JD" + i + j;   // Could be two things and no one wants to look up operator precedence, so instead...
string t = "JD" + (i + j);

But yeah, usually I don't bother.
Although, theoretically, I could now do

C#

string s = 0;      // won't initialise
string t = "" + 0; // will work fine O.o

So, let's get back to self-respecting... Roll eyes | :rolleyes:

Roll eyes | :rolleyes:

Re: How to zero-pad a number?

PIEBALDconsult2-Oct-13 3:12

2-Oct-13 3:12

string t = System.String.Format ( "JD{0}" , i + j ) ;

Re: How to zero-pad a number?

Richard Deeming2-Oct-13 3:19

Richard Deeming

2-Oct-13 3:19

Make that:

C#

string t = string.Format(CultureInfo.InvariantCulture, "JD{0:D}", i + j);

You typically don't want culture-specific formatting or group separators in the result.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: How to zero-pad a number?

PIEBALDconsult2-Oct-13 3:28

2-Oct-13 3:28

I've never had that problem.

Re: How to zero-pad a number?

SortaCore2-Oct-13 9:21

2-Oct-13 9:21

And of course don't forget to set the string to "" at the end, else if the garbage collector is a little slow you might run out of memory!
Better yet, just keep re-using global strings.

Re: How to zero-pad a number?

SortaCore1-Oct-13 10:48

1-Oct-13 10:48

I think I wrote it in one of those points in the week where I just couldn't think. Dead | X|

Dead | X|

Methinks I'll replace it tomorrow.

General News Suggestion Question Bug Answer Joke Praise Rant Admin

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.