|
Don't use string concatenation to generate SQL commands. Apart from leaving you wide open to SQL Injection Attacks[^], you can introduce other errors.
Use Parameterized queries instead: see Query Parameterization Cheat Sheet - OWASP[^]
So you would have some code like this
Dim update1 As String = ("update datamahasiswa set no= @parm1 where nama=@parm2")and then some code to add the parameters.
Note I have not included the single quotes ( ' ) in the sql to surround the variable name. You have actually used a ’ character - which is not the same as '. Using parameterised queries removes errors like that.
|
|
|
|
|
You have not connected your update1 string to your table adapter. So your call to DatamahasiswaTableAdapter1.Update has nothing to work from.
|
|
|
|
|
Dear Mr Richard,
Please tell me how to connect the update command method with update1.
Dim i As Integer
Dim update1 As String = (“update datamahasiswa set no= & TextBox1.Text & where nama= &
TextBox2.Text & ”)
Try
Me.Validate()
Me.LatihanDataSetBindingSource.EndEdit()
Me.LatihanDataSet.Tables(0).Rows(1).Item(1) = TextBox1.Text
i = DatamahasiswaTableAdapter1.Update(LatihanDataSet.datamahasiswa)
Catch ex As Exception
MessageBox.Show(ex.Message)
End Try
MessageBox.Show("no of rows updated=" & i)
The message : this needs valid update command
I propose this question, because it has not yet solved my problem.
Thank you for your time and attention,
My best regards,
Muljanto
|
|
|
|
|
|
Member 12813074 wrote: (“update datamahasiswa set no= & TextBox1.Text & where nama= & TextBox2.Text & ”)
You also seem to be failing String Handling 101.
That code will NOT put the value in TextBox1 into the string. Your actual SQL query will read like this every single time you execute it no matter what you type into the TextBoxes:
"update datamahasiswa set no= & TextBox1.Text & where nama= & TextBox2.Text & "
Again, it will NOT place the values of TextBox1.Text and TextBox2.Text into the SQL string you're building.
You might want to read up on this & Operator (Visual Basic) | Microsoft Docs[^].
Also, NEVER build SQL strings like this. You are blindly trusting user input. That is a bad thing. You're opening yourself up to destroying your database, either accidentally or maliciously. Google for "SQL Injection Attack" to find out why what you're doing is so bad.
|
|
|
|
|
Dear All,
I have revised this code based on my update information, but the record has not yet updated.
Please help me in adding and updating a data table.
My code is below, like that
Dim i As Integer
Dim latihandataset As New latihanDataSet()
Dim datamahasiswatableadapter As New latihanDataSetTableAdapters.datamahasiswa1TableAdapter
Try
Me.Validate()
Me.LatihanDataSetBindingSource.EndEdit()
Me.LatihanDataSet.Tables(0).Rows(1).Item(1) = TextBox1.Text
i = DatamahasiswaTableAdapter1.Update(Me.LatihanDataSet.datamahasiswa)
Me.DatamahasiswaTableAdapter1.Update(Me.LatihanDataSet.datamahasiswa)
Catch ex As Exception
MessageBox.Show(ex.Message)
End Try
MessageBox.Show("no of rows updated=" & i)
The result : It have no a bug error, but the updated program have not run well.
Please help me to create the valid code for update a data.
Thank you for you time and attention,
My best regards,
Muljanto
modified 8-Aug-18 5:21am.
|
|
|
|
|
Dear Mr Dave,
I have done the some feedback.
- by restructuring the table adapter
- by putting the primary key
The result : It is no error bug, but the record has not yet updated succesfully.
The code :
Dim i As Integer
Dim latihandataset As New latihanDataSet()
Dim datamahasiswatableadapter As New latihanDataSetTableAdapters.datamahasiswa1TableAdapter
Try
Me.Validate()
Me.LatihanDataSetBindingSource.EndEdit()
Me.LatihanDataSet.Tables(0).Rows(1).Item(1) = TextBox1.Text
i = DatamahasiswaTableAdapter1.Update(latihandataset.datamahasiswa)
Me.DatamahasiswaTableAdapter1.Update(latihandataset.datamahasiswa)
Me.DatamahasiswaTableAdapter1.Fill(latihandataset.datamahasiswa)
Catch ex As Exception
MessageBox.Show(ex.Message)
End Try
MessageBox.Show("no of rows updated=" & i)
Please help me to rectify this code.
Thank so much for your time and attention,
My best regards,
Muljanto
|
|
|
|
|
Dear All,
I have revised this code, and putted the primary key on one field in DatamahasiswaTableAdapter1.
It does not run well.
Please help me in obtaining a solution about creating a code for adding and updating a data table.
My code is below, like that
Dim i As Integer
Dim update1 As DataTable = Me.DataGridView1.DataSource
Try
Me.Validate()
Me.LatihanDataSetBindingSource.EndEdit()
Me.LatihanDataSet.Tables(0).Rows(1).Item(1) = TextBox1.Text
i = DatamahasiswaTableAdapter1.Update(LatihanDataSet.datamahasiswa)
Me.DatamahasiswaTableAdapter1.Update(update1)
Catch ex As Exception
MessageBox.Show(ex.Message)
End Try
MessageBox.Show("no of rows updated=" & i)
The result : This happened the same bug error, like the previous one
Please help me to create the valid code for update a data.
Thank you for you time and attention,
My best regards,
Muljanto
|
|
|
|
|
|
Dear Mr Richard,
Thanks so much for your reply
I have tried by following your feedback.
I attach my code :
Private Sub Form1_Load(sender As Object, e As EventArgs) Handles MyBase.Load
Me.DatamahasiswaTableAdapter1.Fill(Me.LatihanDataSet.datamahasiswa)
End Sub
Private Sub Button2_Click(sender As Object, e As EventArgs) Handles Button2.Click
Dim i As Integer
Dim latihandataset As New latihanDataSet()
Dim datamahasiswatableadapter1 As New latihanDataSetTableAdapters.datamahasiswa1TableAdapter
Try
Me.Validate()
Me.LatihanDataSetBindingSource.EndEdit()
Me.LatihanDataSet.Tables(0).Rows(1).Item(1) = TextBox1.Text
i = datamahasiswatableadapter1.<big>Update</big>(latihandataset.datamahasiswa)
Me.DatamahasiswaTableAdapter1.Update(LatihanDataSet.datamahasiswa)
Me.DatamahasiswaTableAdapter1.Fill(latihandataset.datamahasiswa)
Catch ex As Exception
MessageBox.Show(ex.Message)
End Try
MessageBox.Show("no of rows updated=" & i)
End Sub
The result : Update is red underlined in vb.net
Please help me to solving this code, because the updating method has not yet run well.
This is supporting code for grid view, like below
Private Sub DataGridView1_CellClick(sender As Object, e As DataGridViewCellEventArgs) Handles DataGridView1.CellClick
TextBox2.Text = Me.LatihanDataSet.Tables(0).Rows(1).Item(0)
TextBox1.Text = Me.LatihanDataSet.Tables(0).Rows(1).Item(1)
End Sub
Thanks so much for your time and attention,
My best regards,
Muljanto
|
|
|
|
|
I do not know what more I can say. I have told you repeatedly what you need to do, and where to find the documents that explain how to do it. It is up to you to configure your system correctly, I cannot do it for you.
|
|
|
|
|
Dear Mr Richard,
I am so sorry for your time and attention.
I have rectified this program, the result is no error bug again, but the update program have not yet updated.
The revised code :
Dim i As Integer
Dim latihandataset As New latihanDataSet()
Dim datamahasiswatableadapter As New latihanDataSetTableAdapters.datamahasiswa1TableAdapter
Try
Me.Validate()
Me.LatihanDataSetBindingSource.EndEdit()
Me.LatihanDataSet.Tables(0).Rows(1).Item(1) = TextBox1.Text
i = DatamahasiswaTableAdapter1.Update(latihandataset.datamahasiswa)
Me.DatamahasiswaTableAdapter1.Update(latihandataset.datamahasiswa)
Me.DatamahasiswaTableAdapter1.Fill(latihandataset.datamahasiswa)
Catch ex As Exception
MessageBox.Show(ex.Message)
End Try
MessageBox.Show("no of rows updated=" & i)
I have re-structured the tableadapter to dismiss a bug error...
But the record have not updated successfully......
Please help me for this case.
Thanks so much for your time and attention,
My best regards,
Muljanto
|
|
|
|
|
i want to do a car park booking system in vb, i use picbox to let user click, my questions is, how to link picbox to sql 2014, i means i need to know what picbox user selected, and it will auto record to sql 2014
|
|
|
|
|
Capture the information from the picture box and use that to construct an SQL command. Execute the SQL command to update the database.
|
|
|
|
|
There is no "auto record" function. You give the pictureboxes a name, and save that name in a database when the user clicks it.
Bastard Programmer from Hell 
If you can't read my code, try converting it here[^]
"If you just follow the bacon Eddy, wherever it leads you, then you won't have to think about politics." -- Some Bell.
|
|
|
|
|
how to display user data after login in vb
|
|
|
|
|
Collect the data, format it into the layout necessary for display and update the window with the new information.
|
|
|
|
|
1. Choose which forum you want to ask your questions in and stick to that forum. In other words, don't post here and in Quick Answers - one or the other!
2.Read the posting guidelines that come up when you click the appropriate link, or are in the tagged message at the top of some forums.
3. Follow the posting guidelines.
You are posting questions without any detail of your problem. We will not just write code for you, but we do want to help you fix your problems. Help us to help you.
|
|
|
|
|
Hola a todos, necesito de su valiosa ayuda para vincular dos DataGridView pero estoy teniendo un problema debido que me muestra el siguiente mensaje justamente en esta parte de codigo y es el siguiente: (El argumento 'column' no puede ser nulo. Nombre del parametro: Column) y no me permite vincularlo, me gustaria que me pudieran ayudar a encontrar el error de antemano muchas gracias
Parte del código donde muestra el mensaje de error
With ds
.Relations.Add("Indice", _
ds.Tables("pa_Listar_Empresa").Columns("db_codigo_empresa"), _
ds.Tables("pa_Listar_Unidad").Columns("db_codigo_empresa"))
End With
Codigo Completo
Imports System.Data
Imports System.Data.SqlClient
Public Class Form_Maestro_Detalle_Procedure
Dim adaptador As New SqlDataAdapter()
Dim ds As New DataSet
Dim cmd As New SqlCommand
Private Sub Form_Maestro_Detalle_Procedure_Load(sender As Object, e As EventArgs) Handles MyBase.Load
CargarDatos()
End Sub
Private Sub Dv_Maestro_CellContentClick(sender As Object, e As DataGridViewCellEventArgs) Handles Dv_Maestro.CellContentClick
Me.lblDetalle.Text = ""
Me.lblDetalle.Text = "Unidades: " & Dv_Detalle.RowCount - 1
End Sub
Public Sub CargarDatos()
Try
conectarse()
'''''''''''''''''''''''''''''''''''''''''''''''''''''
'DataGridView maestro
' ''''''''''''''''''''''''''''''''''''''''''''''''''''
With cmd
' Asignar el sql para seleccionar los datos del objeto Maestro
cmd = New SqlCommand("pa_Listar_Empresa", conn)
cmd.CommandType = CommandType.StoredProcedure
End With
'Enlazamos el procedimiento almacenado y rellenamos el dataset
With adaptador
.SelectCommand = cmd
' llenar el dataset
adaptador.Fill(ds, "pa_Listar_Empresa")
End With
' Enlazar el DataGridView al dataset
With Dv_Maestro
.DataMember = "pa_Listar_Empresa"
.DataSource = ds
.SelectionMode = DataGridViewSelectionMode.FullRowSelect
'.DefaultCellStyle.BackColor = Color.AliceBlue
End With
' ''''''''''''''''''''''''''''''''''''''''''''''''''''
'DataGridView detalles
' ''''''''''''''''''''''''''''''''''''''''''''''''''''
With cmd
' cadena sql para cargar el objeto detalle de ingresos
cmd = New SqlCommand("pa_Listar_Unidad", conn)
cmd.CommandType = CommandType.StoredProcedure
End With
With adaptador
.SelectCommand = cmd
' llenar el dataset
adaptador.Fill(ds, "pa_Listar_Unidad")
End With
With ds
.Relations.Add("Indice", _
ds.Tables("pa_Listar_Empresa").Columns("db_codigo_empresa"), _
ds.Tables("pa_Listar_Unidad").Columns("db_codigo_empresa"))
End With
With Dv_Detalle
Dv_Detalle.DataSource = ds
Dv_Detalle.DataMember = "pa_Listar_Empresa.Indice"
.SelectionMode = DataGridViewSelectionMode.FullRowSelect
'.DefaultCellStyle.BackColor = Color.AliceBlue
End With
lblMaestro.Text = "Empresas: " & ds.Tables("pa_Listar_Empresa").Rows.Count
lblDetalle.Text = "Unidades: " & Dv_Detalle.RowCount - 1
desconectarse()
Catch ex As Exception
MsgBox(ex.Message.ToString)
End Try
End Sub
Los procedimientos almacenados: ambas tablas están vinculados por db_codigo_empresa
ALTER PROCEDURE [dbo].[pa_Listar_Empresa]
AS
SELECT
a.db_codigo_empresa as Codigo,
a.db_razon_social as [Razon Social],
a.db_ruc as Ruc,
a.db_rep_legal as [Representante Legal],
a.db_direccion as Direccion,
a.db_telefono as Telefono,
a.db_correo as Correo,
b.db_denominacion as Actividad,
a.db_estado_empresa as Estado,
FROM tb_Empresa a
INNER JOIN tb_Actividad_Empresa b ON a.db_actividad = b.db_codigo_actividad
WHERE a.db_estado_empresa = 'A'
ORDER BY a.db_razon_social
ALTER PROCEDURE [dbo].[pa_Listar_Unidad]
AS
SELECT
db_codigo as Id,
db_codigo_empresa as Codigo,
db_denominacion as Denominacion,
db_direccion as Direccion,
db_estado_unidad as Estado,
FROM tb_Unidad
WHERE db_estado_unidad = 'A'
|
|
|
|
|
First up, it will be helpful if you can post in English.
The error comes because the columns names you have given are not present in the tables you are using. You will need to verify if the column names you are giving are accurate and also the parent and child tables are in correct order.
"It is easy to decipher extraterrestrial signals after deciphering Javascript and VB6 themselves.", ISanti[ ^]
|
|
|
|
|
I would like to change Settings->Typing->Change Cursor Thickness to 8 on startup of my application for instance.
Sorry, currently using VB.NET 2.0
Migrating soon to .NET 4.5
|
|
|
|
|
|
I agree on principal. But this application is locked to the forefront, user doesn't have a real mouse or keyboard, so ours is the only application that runs.
|
|
|
|
|
You can change the setting via the registry, but the user will need to sign out and sign in again for that to take effect:
Change Cursor Thickness in Windows 10 | Windows 10 Tutorials[^]
But if you don't own the machine, then don't mess with the user's settings.
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Richard Deeming wrote: but the user will need to sign out and sign in again for that to take effect:
I think he could just post a WM_SETTINGCHANGE message to the HWND_BROADCAST handle with the wParam set to SPI_SETCURSORS/0x0057 after modifying that registry key.
Best Wishes,
-David Delaune
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
