C / C++ / MFC Discussion Boards

Re: c libraries needed to deal with bitmaps

Calin Negru12-Mar-20 0:18

Calin Negru

12-Mar-20 0:18

At the end of code posted above I try to do this:

StringCchPrintfA(message,1024,"dib at 34 %d",pDib[34]);
	MessageBox(NULL, message, "Textures.exe", MB_OK);

I expect pDib[34] to be 255 since the bitmap is 10 white pixels ( in a row) 40 bytes in total.

Re: c libraries needed to deal with bitmaps

Richard MacCutchan12-Mar-20 2:31

Richard MacCutchan

12-Mar-20 2:31

I think you are missing something in your code. You read the BITMAPFILEHEADER but then assume that the remaining data is the actual bitmap, whereas the BITMAPFILEHEADER is followed by another header as described at BITMAPFILEHEADER (wingdi.h) - Win32 apps | Microsoft Docs[^].

Re: c libraries needed to deal with bitmaps

Calin Negru12-Mar-20 4:40

Calin Negru

12-Mar-20 4:40

yeah I was a bit in a hurry, I was expecting to find pixels right after the first header.

Re: c libraries needed to deal with bitmaps

Richard MacCutchan12-Mar-20 5:10

Richard MacCutchan

12-Mar-20 5:10

It is all explained at Bitmap Header Types - Win32 apps | Microsoft Docs[^]. But take special care of the different header types that may exist.

Re: c libraries needed to deal with bitmaps

Calin Negru13-Mar-20 3:22

Calin Negru

13-Mar-20 3:22

I was only using a part of the bitmap processing code I was using as reference. I don`t need the palette part so I trimmed out a bit too much.

m_pDib = pDib;
	m_dwDibSize = dwDibSize;

	// Pointer our BITMAPINFOHEADER and RGBQUAD
	// variables to the correct place in the Dib data.
	m_pBIH = (BITMAPINFOHEADER *) m_pDib;
	m_pPalette =
		(RGBQUAD *) &m_pDib[sizeof(BITMAPINFOHEADER)];

	//	get image width and height
	m_width = m_pBIH->biWidth;
	m_height = m_pBIH->biHeight;

	// Calculate the number of palette entries.
	m_nPaletteEntries = 1 << m_pBIH->biBitCount;
	if( m_pBIH->biBitCount > 8 )
		m_nPaletteEntries = 0;
	else if( m_pBIH->biClrUsed != 0 )
		m_nPaletteEntries = m_pBIH->biClrUsed;

	// Point m_pDibBits to the actual Dib bits data.
	m_pDibBits =
		&m_pDib[sizeof(BITMAPINFOHEADER)+
			m_nPaletteEntries*sizeof(RGBQUAD)];

	// If we have a valid palette, delete it.
	if( m_Palette.GetSafeHandle() != NULL )
		m_Palette.DeleteObject();

I know I must go past the bitmapinfoheader to get to the pixels

modified 13-Mar-20 14:06pm.

Re: c libraries needed to deal with bitmaps

Richard MacCutchan13-Mar-20 4:22

Richard MacCutchan

13-Mar-20 4:22

Please use proper <pre> tags around code blocks (and proper indentation), not Quoted text. The following code sample is preceded by
<pre lang="c++">
and followed by
</pre>

C++

// Calculate the number of palette entries.
m_nPaletteEntries = 1 << m_pBIH->biBitCount;
if( m_pBIH->biBitCount > 8 )
    m_nPaletteEntries = 0;
else if( m_pBIH->biClrUsed != 0 )
    m_nPaletteEntries = m_pBIH->biClrUsed;

Much more readable.

Re: c libraries needed to deal with bitmaps

Calin Negru13-Mar-20 7:50

Calin Negru

13-Mar-20 7:50

I`m having trouble understanding how this code works. The problem is I`m not a c expert.

cf.Read( &BFH, sizeof( BITMAPFILEHEADER )

For instance how does the portion of data read from my file fits into a structure. It`s not a structure of identical items BITMAPFILEHEADER is a mix of WORDs and DWORDS

Re: c libraries needed to deal with bitmaps

Richard MacCutchan13-Mar-20 8:07

Richard MacCutchan

13-Mar-20 8:07

The sizeof operator gives the number of bytes in the object referred to. So in your case it will be the size of a BITMAPFILEHEADER, and the read operation will read the correct number of bytes into the structure. When complete each field of the structure should be correctly aligned*.

*There are conditions where this may not be true, so beware if you have a structure containing single byte elements. You may ignore that for the moment.

Re: c libraries needed to deal with bitmaps

Calin Negru13-Mar-20 21:07

Calin Negru

13-Mar-20 21:07

thanks that makes sense. In the code above do I need m_nPaletteEntries at all? Is used to calculate the offset at which individual pixels are stored?

Re: c libraries needed to deal with bitmaps

Richard MacCutchan13-Mar-20 23:04

Richard MacCutchan

13-Mar-20 23:04

You need to examine the different items in the info table as described at BITMAPINFOHEADER structure (Windows) | Microsoft Docs[^]. The values of the items related to colours will tell you whether a colour table is included or not.

Re: c libraries needed to deal with bitmaps

Calin Negru14-Mar-20 3:30

Calin Negru

14-Mar-20 3:30

I have to take a short break. Your insight (last post included) is priceless Richard, thanks

`DreamLand Page` is my projects facebook page.

Re: c libraries needed to deal with bitmaps

Richard MacCutchan14-Mar-20 3:47

Richard MacCutchan

14-Mar-20 3:47

Sorry to disappoint you, but my 'insight' is actually just a matter of reading the documentation.

Re: c libraries needed to deal with bitmaps

Calin Negru14-Mar-20 7:11

Calin Negru

14-Mar-20 7:11

the code you quoted is the bit that throws me into fog. What does the line that has the overload operator do?

Re: c libraries needed to deal with bitmaps

Richard MacCutchan14-Mar-20 7:13

Richard MacCutchan

14-Mar-20 7:13

fearless_ wrote:
What does the line that has the overload operator do?

What line?

Re: c libraries needed to deal with bitmaps

Calin Negru14-Mar-20 8:18

Calin Negru

14-Mar-20 8:18

m_nPaletteEntries = 1 << m_pBIH->biBitCount;

Re: c libraries needed to deal with bitmaps

phil.o14-Mar-20 8:37

phil.o

14-Mar-20 8:37

This is a bitwise left-shift operation which is equivalent to

C++

m_nPaletteEntries = pow(2, m_pBIH->biBitCount); // 2 to the power of bpp

What are shift operators in C++?[^]
This trick is used quite often, since a bitwise shift operation is way quicker than the pow() method, which is rather intense on processing time.

Edit: here's an interesting list of useful bitwise tricks:
Bit Twiddling Hacks[^]

"Five fruits and vegetables a day? What a joke!
Personally, after the third watermelon, I'm full."

Re: c libraries needed to deal with bitmaps

Richard MacCutchan14-Mar-20 9:27

Richard MacCutchan

14-Mar-20 9:27

It's not pow, it's multiply by 2.

Re: c libraries needed to deal with bitmaps

phil.o14-Mar-20 9:34

phil.o

14-Mar-20 9:34

For a left-shift by a single bit, yes, a multiplication by 2.
But a left-shift by n bits, in the end, is the same as a multiplication by 2 to the power of n; since original value is 1, this leads to 2 to the power of n. Or am I missing something?

"Five fruits and vegetables a day? What a joke!
Personally, after the third watermelon, I'm full."

Re: c libraries needed to deal with bitmaps

Richard MacCutchan14-Mar-20 21:58

Richard MacCutchan

14-Mar-20 21:58

I found myself thinking about this when I woke up this morning and you are, of course, quite correct.

Re: c libraries needed to deal with bitmaps

Calin Negru12-Mar-20 0:35

Calin Negru

12-Mar-20 0:35

Richard I appreciate your willingness to help

Re: c libraries needed to deal with bitmaps

Victor Nijegorodov11-Mar-20 22:45

Victor Nijegorodov

11-Mar-20 22:45

fearless_ wrote:
Would you mind helping me further? I loaded the bitmap, however when I check the values from the array into which the bitmap is loaded they show up as 0 (null).

1. How did you load the bitmap?
2. How did you "check the values from the array into which the bitmap is loaded"?
3. Did you try to open this bitmap with some graphic editor/viewer?

Re: c libraries needed to deal with bitmaps

Calin Negru12-Mar-20 0:43

Calin Negru

12-Mar-20 0:43

Victor thanks for offering to help, take a look at my reply to Richard

Re: c libraries needed to deal with bitmaps

leon de boer12-Mar-20 5:31

leon de boer

12-Mar-20 5:31

You are messing around with stuff you do not have to do on Windows and there is no advantage in doing what you are doing other than learning.

You can load a bitmap with one line of code using the API LoadBitmap()

LoadBitmapA function (winuser.h) - Win32 apps | Microsoft Docs[^]

One line of code will load it for you and it doesn't care what the bitmap format is.

HBITMAP MyBmp = LoadBitmap(0, "Yourbitmapname.bmp");

Once you have a HBITMAP (handle to a bitmap) in Windows you can basically do everything with it.
If you want the details from the bitmap once you have it loaded you just ask windows to extract them for you
So with my handle above I can extract the header with 2 lines of code the 3rd line is just to throw the details out (it assumes you are doing a console app).

BITMAP bm;
GetObject(MyBmp, sizeof(bm), &bm);
printf("Bitmap is wth: %u ht: %u bitdepth: %u\r\n", bm.bmWidth, bm.bmHeight, bm.bmBitsPixel);

So I can load the bitmap and extract the header with 3 lines in absolute safety.
If you are messing around with the actual header etc in Windows you are doing it all wrong Smile | :)

The only time you might play with a BMP file header is writing a BMP in a specific format.

That is why there is no need for libraries on Windows to handle bitmaps. Now JPEGS are a little trickier it's about 20 lines of code to get windows to load one of those most of the issue the filename has to be in UNICODE. Let me know if you need to know how to do it.

In vino veritas

modified 12-Mar-20 11:48am.

Re: c libraries needed to deal with bitmaps

Victor Nijegorodov12-Mar-20 8:39

Victor Nijegorodov

12-Mar-20 8:39

leon de boer wrote:
One line of code will load it for you and it doesn't care what the bitmap format is.
HBITMAP MyBmp = LoadBitmap(0, "Yourbitmapname.bmp");

You probaly meant the [LoadImageA function (winuser.h) - Win32 apps | Microsoft Docs](https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-loadimagea) function that can load the bitmap from the file.
LoadBitmap only loads the bitmap from resources.

Re: c libraries needed to deal with bitmaps

leon de boer12-Mar-20 13:19

leon de boer

12-Mar-20 13:19

Yep sorry needed more coffee last night, clearly Smile | :)

In vino veritas

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.